osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-05-15 16:13:13 +08:00

Files

T

Bartłomiej Dach 197c318180 Fix HealthProcessor potentially incorrectly reverting failed state

This stems from me looking into `TestSceneFailAnimation` failures
(https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
not have been mad by CI, and rather should have been mad at myself for
failing to read.

`FailedAtJudgement` in fact does not mean "this judgement, and only this
judgement, triggered failure". If any further judgements occur
post-fail, they will also have `FailedAtJudgement` set to true. It is
essentially a *dump* of the state of `HealthProcessor.Failed` prior to
applying the judgement.

	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57

Because of this, reverting several judgements which occur post-fail
could lead to failed state reverting earlier than intended, and thus
potentially trigger a second fail, thus tripping the `Player` assertion.

197c318180 · 2025-08-27 12:27:11 +02:00

History

Legacy

Add HP and AR to LegacyBeatmapConversionDifficultyInfo

2024-03-28 22:30:39 +09:00

AccumulatingHealthProcessor.cs

Fix missing tiny droplet not triggering fail with perfect on

2024-02-14 14:21:48 +01:00

DefaultHitWindows.cs

Refactor hit windows class structure to reduce rigidity

2025-06-25 08:40:12 +02:00

DrainingHealthProcessor.cs