mirror of
https://github.com/ppy/osu.git
synced 2026-05-31 09:10:03 +08:00
Dan Balasescu
67eb691c83
Tests will [preserve](https://github.com/ppy/osu/blob/f4c96ecb54ff7650e617597faa583f1f40ce323b/osu.Game/Tests/Visual/OnlinePlay/TestRoomRequestsHandler.cs#L270) the incoming `RoomId` value if non-null. But since now everything goes through `MultiplayerClient.CreateRoom(MultiplayerRoom)` which internally creates a representative `Room` to return in requests, this would previously return a `Room` with `RoomId == 0` and not the expected `null` value. The only consumer of this outside of tests is [server-spectator](https://github.com/ppy/osu-server-spectator/blob/c1f33672cc2245614bdcfeb3109801b20a89c709/osu.Server.Spectator/Services/SharedInterop.cs#L147), but only in the context of creating rooms at which point RoomId is irrelevant.
67eb691c83
·
2025-03-28 21:49:52 +09:00
History