1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 15:07:44 +08:00
osu-lazer/osu.Game
Bartłomiej Dach 05bd912a21
Revert internal access modifier application
Unfortunately breaks a few classes (which is fixable), and also breaks
Moq/Castle dynamic proxies (which is unfortunate).

Relevant error:

    System.TypeLoadException : Method 'GetPanelBackground' in type 'Castle.Proxies.IWorkingBeatmapProxy' from assembly 'DynamicProxyGenAssembly2, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
    Stack Trace:
        at System.Reflection.Emit.TypeBuilder.CreateTypeNoLock()
        at System.Reflection.Emit.TypeBuilder.CreateTypeInfo()
        at Castle.DynamicProxy.Generators.Emitters.AbstractTypeEmitter.BuildType()
        at Castle.DynamicProxy.Generators.BaseInterfaceProxyGenerator.GenerateType(String typeName, INamingScope namingScope)
        at Castle.DynamicProxy.Generators.BaseProxyGenerator.<>c__DisplayClass13_0.<GetProxyType>b__0(CacheKey cacheKey)
        at Castle.Core.Internal.SynchronizedDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
        at Castle.DynamicProxy.Generators.BaseProxyGenerator.GetProxyType()
        at Castle.DynamicProxy.DefaultProxyBuilder.CreateInterfaceProxyTypeWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options)
        at Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyTypeWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options)
        at Castle.DynamicProxy.ProxyGenerator.CreateInterfaceProxyWithoutTarget(Type interfaceToProxy, Type[] additionalInterfacesToProxy, ProxyGenerationOptions options, IInterceptor[] interceptors)
        at Moq.CastleProxyFactory.CreateProxy(Type mockType, IInterceptor interceptor, Type[] interfaces, Object[] arguments) in C:\projects\moq4\src\Moq\Interception\CastleProxyFactory.cs:line 50

In theory it would be possible to fix this via application of

    [assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]

onto the `osu.Game` assembly, but I think this would be bad precedent.
2023-06-08 15:23:09 +02:00
..
Audio Merge branch 'master' into sample-set-controls 2023-05-24 14:03:04 +09:00
Beatmaps Revert internal access modifier application 2023-06-08 15:23:09 +02:00
Collections Ensure collection edit textbox commits on focus loss 2023-06-04 12:51:03 +09:00
Configuration Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
Database Merge pull request #23711 from timiimit/add-last-edit-time 2023-06-07 16:57:24 +02:00
Extensions Handle culture code differences of Traditional Chinese 2023-06-08 03:27:05 +03:00
Graphics Merge pull request #23808 from peppy/working-beatmap-get-background 2023-06-08 12:23:07 +02:00
Input Change default bindings to account for mouse wheel rotation 2023-06-07 18:07:56 +09:00
IO Also support hard links on macOS 2022-12-29 22:35:13 +08:00
IPC Handle osu:// scheme links via IPC in desktop game 2022-06-20 21:26:22 +02:00
Localisation Fix new localisations using lookup keys of existing ones 2023-06-07 23:43:21 +02:00
Models Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
Online Supply Accept-Language header in API requests 2023-06-08 02:59:34 +03:00
Overlays Merge pull request #23808 from peppy/working-beatmap-get-background 2023-06-08 12:23:07 +02:00
Performance Partial everything 2022-11-27 00:00:27 +09:00
Properties Automated #nullable processing 2022-06-17 16:37:17 +09:00
Replays Show smoke in replays 2022-09-18 17:55:06 -07:00
Rulesets Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
Scoring Split out multiplier retrieval into a function and use a default multiplier for all rulesets 2023-05-30 14:20:26 +09:00
Screens Merge branch 'master' into crop-texture-uploads-song-select 2023-06-08 12:24:16 +02:00
Skinning Remove usages of [ExcludeFromDynamicCompile] 2023-05-08 18:12:56 +09:00
Storyboards Fix storyboard video-only check being inverted 2023-05-16 21:51:32 -07:00
Tests Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
Updater Partial everything 2022-11-27 00:00:27 +09:00
Users Use image@2x from tournament banner api 2023-03-25 13:08:46 -07:00
Utils Extract common part of regex to separate method 2022-12-03 16:59:43 +01:00
.editorconfig Add localisation length hinting 2022-04-28 19:26:28 +09:00
BackgroundBeatmapProcessor.cs Partial everything 2022-11-27 00:00:27 +09:00
osu!.res And then everything became one 2017-09-19 16:06:58 +09:00
osu.Game.csproj Update framework 2023-06-01 00:44:13 +09:00
OsuGame.cs Disable all tablet handlers to guard against a grim future 2023-06-02 08:48:47 +09:00
OsuGameBase_Importing.cs Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
OsuGameBase.cs Expose currently selected language from IAPIProvider 2023-06-08 02:59:34 +03:00
PerformFromMenuRunner.cs Partial everything 2022-11-27 00:00:27 +09:00