h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 17:57:29 +08:00
Code Issues Releases Wiki Activity
035163a792
osu-lazer/osu.Game.Rulesets.Taiko/Objects
History
Bartłomiej Dach 9915fac2c8
Fix sample silence being one level too low 
4a7b011a53 inadvertently unearthed that
nested strong hits could play samples of their own accord, rather than
delegating to `DrumSampleTriggerSource` as they were supposed to. This
was an unfortunate omission due to how the inheritance structure of
`TaikoHitObject` looks like (some irrelevant classes omitted for
brevity):

	DrawableTaikoHitObject
		DrawableTaikoHitObject<TObject> <-- `GetSamples()` was overridden to empty here
			DrawableTaikoStrongableHitObject
				DrawableHit
				DrawableDrumRoll
				DrawableDrumRollTick
			DrawableSwell
			DrawableSwellTick
		DrawableStrongNestedHit <-- all strong nested hits are here => didn't receive `GetSamples()` override
			DrawableHit.StrongNestedHit
			DrawableDrumRoll.StrongNestedHit
			DrawableDrumRollTick.StrongNestedHit

To fix, move the `GetSamples()` override one level higher, to the
non-generic `DrawableTaikoHitObject`, to suppress the spurious sample
playbacks.

The stale reference in the comment was also updated to match current
code.
2023-05-21 18:58:26 +02:00
..
Drawables Fix sample silence being one level too low 2023-05-21 18:58:26 +02:00
BarLine.cs Change bindable properties in all HitObjects to be lazily initialised 2022-07-19 05:39:10 +03:00
DrumRoll.cs Propagate samples to strong nested hits too 2023-05-21 18:58:05 +02:00
DrumRollTick.cs Propagate samples to strong nested hits too 2023-05-21 18:58:05 +02:00
Hit.cs Propagate samples to strong nested hits too 2023-05-21 18:58:05 +02:00
HitType.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IgnoreHit.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
StrongNestedHitObject.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
Swell.cs Propagate samples to drum roll/swell ticks for correct playback 2023-05-21 18:57:01 +02:00
SwellTick.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
TaikoHitObject.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
TaikoStrongableHitObject.cs Rename GetSampleInfo to better describe what method does 2023-05-17 14:07:48 +09:00