Bartłomiej Dach 9915fac2c8 Fix sample silence being one level too low ... 4a7b011a53 inadvertently unearthed that nested strong hits could play samples of their own accord, rather than delegating to `DrumSampleTriggerSource` as they were supposed to. This was an unfortunate omission due to how the inheritance structure of `TaikoHitObject` looks like (some irrelevant classes omitted for brevity): DrawableTaikoHitObject DrawableTaikoHitObject<TObject> <-- `GetSamples()` was overridden to empty here DrawableTaikoStrongableHitObject DrawableHit DrawableDrumRoll DrawableDrumRollTick DrawableSwell DrawableSwellTick DrawableStrongNestedHit <-- all strong nested hits are here => didn't receive `GetSamples()` override DrawableHit.StrongNestedHit DrawableDrumRoll.StrongNestedHit DrawableDrumRollTick.StrongNestedHit To fix, move the `GetSamples()` override one level higher, to the non-generic `DrawableTaikoHitObject`, to suppress the spurious sample playbacks. The stale reference in the comment was also updated to match current code.		2023-05-21 18:58:26 +02:00
..
Beatmaps	pass new hitobject properties through beatmap converters	2023-04-30 19:20:42 +02:00
Configuration	Removed unnecessary directives that were added automatically and I forgot to remove	2023-01-10 12:44:27 +00:00
Difficulty	Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace.	2022-11-19 16:53:35 +01:00
Edit	Move blueprint validity conditions to allow more correct external usage of EndPlacement	2023-05-12 16:02:22 +09:00
Judgements	Fix test, make strong hits have LargeBonus judgement	2022-08-30 15:00:46 +02:00
Mods	Limit taiko playfield aspect ratio to 5:4 - 16:9	2023-04-26 18:05:47 +02:00
Objects	Fix sample silence being one level too low	2023-05-21 18:58:26 +02:00
Properties	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Replays	Use AsNonNull() instead.	2022-07-02 19:48:32 +08:00
Resources	Add conversion tests	2023-02-09 23:23:58 +01:00
Scoring	Partial everything	2022-11-27 00:00:27 +09:00
Skinning	Move judgement text creation to base class and tidy things up	2022-12-24 12:22:36 +08:00
UI	Merge remote-tracking branch 'upstream/master' into sample-control-points	2023-04-30 19:47:03 +02:00
osu.Game.Rulesets.Taiko.csproj	Update netstandard2.1 references to net6.0	2022-12-16 17:16:13 +09:00
TaikoInputManager.cs	Partial everything	2022-11-27 00:00:27 +09:00
TaikoRuleset.cs	Initial Taiko single tap implementation (still needs code to allow for Strong hits)	2023-02-27 13:18:08 +00:00
TaikoSettingsSubsection.cs	Updated touch control scheme setting capitalization to be consistent with the rest of the settings menu	2023-01-10 11:57:21 +00:00
TaikoSkinComponentLookup.cs	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
TaikoSkinComponents.cs	Add legacy taiko kiai glow element	2022-11-30 00:44:20 +01:00