mirror of
https://github.com/ppy/osu.git
synced 2024-09-21 22:07:25 +08:00
7e5533e205
Closes #23862.
Score V2 is a scoring algorithm, which aside from the raw numerical
values of each judgement, incorporates a combo component, wherein each
judgement's "combo score" is derived from both the raw numerical value
of the object and the current combo after the given judgement. In
particular, this means that Score V2 is sensitive to the _order_ of
judging objects, as if two objects with the same start time are judged
using different ordering, they can end up having a different "combo
score".
The issue that this change is fixing is an instance of one such
reordering. Upon inspection, it turned out that the simulated autoplay
run, which is used to determine max possible score so that it can be
standardised to 1 million again, was processing a slider repeat before a
slider tail circle, while actual gameplay was processing the same slider
repeat _after_ the slider tail circle.
The cause of that behaviour is unfortunately due to `LegacyLastTick`.
The sliders which cause the issue are extremely short. Stable had a
behaviour, in which to provide leniency, slider tails were artificially
offset back by 36ms. However, if the slider is not long enough to make
this possible, the last tick is placed in the middle of the slider. If
that slider also happens to have exactly 1 repeat, then this means that
the last tick and the repeat have the same time instant.
Because of the time equality, what begins to matter now is the _order_
of processing the elements of the drawable slider in the hierarchy. For
the purposes of legacy skins, tail circles were moved below ticks in
|
||
|---|---|---|
| .. | ||
| Drawables | ||
| HitCircle.cs | ||
| ISliderProgress.cs | ||
| OsuHitObject.cs | ||
| Slider.cs | ||
| SliderEndCircle.cs | ||
| SliderHeadCircle.cs | ||
| SliderRepeat.cs | ||
| SliderTailCircle.cs | ||
| SliderTick.cs | ||
| Spinner.cs | ||
| SpinnerBonusTick.cs | ||
| SpinnerTick.cs | ||