35823 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into fix-transform-carousel
  Dean Herbert · 2021-01-06 21:03:22 +09:00
  ffafdf2209
• Merge pull request #11426 from peppy/fix-transform-mutation-loading-layer
  Bartłomiej Dach · 2021-01-05 23:45:17 +01:00
  1f0af747ad
• Merge branch 'master' into fix-transform-mutation-loading-layer
  Bartłomiej Dach · 2021-01-05 23:10:51 +01:00
  52687fc37c
• Mark background dim layer as possibly-null
  Bartłomiej Dach · 2021-01-05 22:56:53 +01:00
  0880e76da8
• Make auto-property get-only
  Bartłomiej Dach · 2021-01-05 22:56:53 +01:00
  ac1d6d4444
• Remove now-unused fields & locals
  Bartłomiej Dach · 2021-01-05 22:56:53 +01:00
  2b253f6d01
• Merge pull request #11405 from peppy/fix-carousel-centering-on-window-resize
  Bartłomiej Dach · 2021-01-05 22:03:40 +01:00
  e9282e9a2b
• Merge branch 'master' into fix-carousel-centering-on-window-resize
  Bartłomiej Dach · 2021-01-05 21:30:39 +01:00
  fbbc26d7d8
• Merge pull request #11419 from peppy/fix-transform-mutation-from-disposal-thread

  Fix RemoveBlockingOverlay causing transform mutation from disposal threads

  Bartłomiej Dach · 2021-01-05 20:45:32 +01:00
  11e228b781
• Merge branch 'master' into fix-transform-mutation-from-disposal-thread
  Bartłomiej Dach · 2021-01-05 19:52:10 +01:00
  847d2d8deb
• Match code between updateSelectedBeatmap/Ruleset
  Dean Herbert · 2021-01-05 20:38:58 +09:00
  4b539b01c1
• Fix carousel beatmap set panels applying transforms to difficulties while they are loading
  Dean Herbert · 2021-01-05 18:41:45 +09:00
  83dbba3cbf
• Fix test (and remove no longer valid test)
  Dean Herbert · 2021-01-05 18:10:39 +09:00
  0639429a23
• Merge pull request #11420 from kyekiller/master

  Fix to toolbar tooltips

  Dean Herbert · 2021-01-05 17:43:32 +09:00
  3b98782964
• Remove unused dispose logic
  Dean Herbert · 2021-01-05 17:42:19 +09:00
  0b1ee2e267
• Refactor LoadingLayer to avoid applying effects to external drawables

  In theory this seemed like a good idea (and an optimisation in some
  cases, due to lower fill rate), but in practice this leads to weird edge
  cases.
  
  This aims to do away with the operations on external drawables by
  applying a dim to the area behind the `LoadingLayer` when required.
  I went over each usage and ensured they look as good or better than
  previously.
  
  The specific bad usage here was the restoration of the colour on dispose
  (if the `LoadingLayer` was disposed in a still-visible state).
  
  I'm aware that the `BeatmapListingOverlay` will now dim completely during
  load. I think this is fine for the time being.

  Dean Herbert · 2021-01-05 17:31:45 +09:00
  54982dcdd7
• Merge pull request #11415 from frenzibyte/fix-ready-button-crash

  Fix multiplayer ready button crashing when deleting selected beatmap set

  Dean Herbert · 2021-01-05 15:58:09 +09:00
  60fc60fa00
• Remove hacky code
  Dean Herbert · 2021-01-05 14:54:59 +09:00
  ed6ffe2ef1
• Add simple test coverage
  Salman Ahmed · 2021-01-05 06:00:15 +03:00
  81355652fa
• Should pass all checks again now.
  KyeKiller · 2021-01-04 22:11:52 +00:00
  77e660e426
• Applied all tooltips to the right
  KyeKiller · 2021-01-04 22:01:12 +00:00
  1234d0fa04
• Merge branch 'master' into master
  kyekiller · 2021-01-04 21:07:12 +00:00
  254698d9a2
• Hit another oopie
  KyeKiller · 2021-01-04 21:05:28 +00:00
  0e42d415c1
• Moved tooltip to the left to stop the overflow
  KyeKiller · 2021-01-04 21:04:30 +00:00
  3468df840b
• Moved "ToolbarSocialButton" back
  KyeKiller · 2021-01-04 21:03:51 +00:00
  73f5e5aaf9
• Merge pull request #11418 from peppy/fix-storyboard-skip-starttime-regression
  Bartłomiej Dach · 2021-01-04 20:08:59 +01:00
  a86a7b08df
• Should remove codeFactor error
  KyeKiller · 2021-01-04 17:26:42 +00:00
  2e2b3ab5d4
• Moved "ToolbarSocialButton"

  This will remove it from coming off the screen.

  KyeKiller · 2021-01-04 17:21:31 +00:00
  2d1b52be0d
• Fix RemoveBlockingOverlay causing transform mutation from disposal threads
  Dean Herbert · 2021-01-04 17:49:11 +09:00
  3b08faa0ea
• Fix hasBeatmap potentially checking on outdated DeletePending value
  Salman Ahmed · 2021-01-04 10:28:41 +03:00
  485a57776b
• Schedule all calls to updateBeatmapState()
  Salman Ahmed · 2021-01-04 10:27:08 +03:00
  ea38b00b29
• Remove unused using
  Dean Herbert · 2021-01-04 15:40:22 +09:00
  9e0c490141
• Fix Storyboard's FirstEventTime not finding the true earliest event
  Dean Herbert · 2021-01-04 15:16:01 +09:00
  20d04d6933
• Add failing test for storyboard start time ordering
  Dean Herbert · 2021-01-04 15:15:23 +09:00
  cb7df0fe11
• Re-query beatmap info on database changes
  Salman Ahmed · 2021-01-04 09:00:16 +03:00
  445a4bd01c
• Revert database-side changes
  Salman Ahmed · 2021-01-04 08:50:30 +03:00
  ca5f2bcd4c
• Remove unnecessary using directive
  Salman Ahmed · 2021-01-04 08:12:31 +03:00
  1463ff2886
• Update soft-deletion logic to use model store's consumable items instead
  Salman Ahmed · 2021-01-04 07:47:08 +03:00
  738c94d193
• Add failing test case
  Salman Ahmed · 2021-01-04 07:45:29 +03:00
  df04dd21de
• Fix incorrect initial conditional

  Turns out this wasn't actually required.

  Dean Herbert · 2021-01-03 22:44:32 +09:00
  53e6a349bb
• Fix null condition inhibiting deselection events
  Dean Herbert · 2021-01-03 22:43:02 +09:00
  efb71713ef
• Merge pull request #11413 from peppy/fix-mod-settings-transfer-issues

  Fix difficulty adjust settings not being transferred correctly in multiplayer/playlists

  Dean Herbert · 2021-01-03 22:38:41 +09:00
  cd7a5ca23a
• Clarify & cleanup comments some
  Bartłomiej Dach · 2021-01-03 13:44:29 +01:00
  9e4a925ab1
• Rename parameters for readability
  Bartłomiej Dach · 2021-01-03 13:25:44 +01:00
  a3e29b9154
• Copy values using Bind to also copy defaults
  Dean Herbert · 2021-01-03 20:45:03 +09:00
  2501707d7d
• Update osu.Game/Online/API/APIMod.cs

  Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>

  Dean Herbert · 2021-01-03 17:04:16 +09:00
  6ad1b7767e
• Switch back to FirstOrDefault to allow for weird testing logic to pass
  Dean Herbert · 2021-01-03 16:46:24 +09:00
  99fa0e25dc
• Add internal pathway for ensuring correct application of bindable mods
  Dean Herbert · 2021-01-03 15:48:28 +09:00
  29dbb1cc0d
• Simplify some default value checks (we are sure the return is an IBindable)
  Dean Herbert · 2021-01-03 15:47:15 +09:00
  23e216fa0b
• Use SingleOrDefault for added safety when looking up mod acronyms
  Dean Herbert · 2021-01-03 15:38:30 +09:00
  1a44338124