Dean Herbert
e664690fe2
Remove unnecessary LoadTrack call
2022-07-28 22:19:46 +09:00
Dean Herbert
3005ff1b9f
Merge branch 'master' into pie-chart-progress
2022-07-28 22:19:27 +09:00
Dan Balasescu
a59d7f6710
Merge branch 'master' into collections-track-beatmap-updates
2022-07-28 22:05:34 +09:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
...
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
Dan Balasescu
5003eb5629
Merge pull request #19430 from peppy/realm-collections
...
Move beatmap collections to realm
2022-07-28 22:05:10 +09:00
Dan Balasescu
11e0022fad
Merge branch 'master' into realm-collections
2022-07-28 21:00:08 +09:00
Dan Balasescu
ce694123eb
Move spectator begin/end playing to SubmittingPlayer
2022-07-28 20:44:04 +09:00
Dean Herbert
4b140e1f5a
Adjust metrics
2022-07-28 18:50:46 +09:00
Dean Herbert
86c2b7e449
Apply nullability to DefaultSongProgress and clean up more stuff
2022-07-28 18:37:17 +09:00
Dean Herbert
ea027eda46
Move initial show to base implementation and add transition for legacy version
2022-07-28 18:29:49 +09:00
Dean Herbert
bfa026879c
Remove pointless null check
2022-07-28 18:28:03 +09:00
Dean Herbert
d5e5761892
Fix DefaultSongProgress graph not resetting if time is in intro
2022-07-28 18:25:24 +09:00
Dean Herbert
7108553883
Tidy up various things everywhere
2022-07-28 18:25:14 +09:00
Dean Herbert
a21aee4e9c
Reduce calls to LoadTrack by implicitly running on test/dummy classes
2022-07-28 18:11:40 +09:00
Dan Balasescu
1039338d80
Fix intermittent HUD tests
2022-07-28 17:58:07 +09:00
Dean Herbert
628a30193f
Remove incorrect TrackLoaded override from TestWorkingBeatmap
2022-07-28 17:49:17 +09:00
Dan Balasescu
1da9830145
Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
...
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
Dean Herbert
8cb4fb35e0
Rename parameter to read better (and still use local cache if no online API is available)
2022-07-28 17:08:59 +09:00
Dan Balasescu
6d4023b933
Adjust comment
2022-07-28 16:56:11 +09:00
Dan Balasescu
ebe64422d6
Merge pull request #19433 from peppy/beatmap-model-documentation
...
Add more comprehensive xmldoc for beatmap model classes
2022-07-28 16:40:29 +09:00
Dan Balasescu
cd01c5d3ac
Fix assertion
2022-07-28 16:34:31 +09:00
Dean Herbert
c35da62224
Add flow for bypassing local cache lookups when refreshing beatmap metadata
2022-07-28 16:33:51 +09:00
Dean Herbert
17a3fd30fb
Move scheduler from OnlineLookupQueue to BeatmapUpdater
2022-07-28 16:32:22 +09:00
Nitrous
0d36907cad
apply code quality fixes
2022-07-28 15:30:45 +08:00
Nitrous
bca3994d91
set FirstHitTime and LastHitTime once
2022-07-28 15:25:12 +08:00
Dan Balasescu
fe6b487d75
Merge pull request #19432 from peppy/fix-update-test-failures
...
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 16:19:46 +09:00
Nitrous
70ed347b06
simplify helper methods
2022-07-28 15:19:35 +08:00
Dean Herbert
2b9d46d803
Remove unused RulesetStore from BeatmapManager constructor
2022-07-28 16:19:05 +09:00
Nitrous
db62d4be3a
apply suggestions
...
- refactor `SongProgress`
- make`UpdateProgress` more readable
- enable NRT on new classes
- refactor `TestSceneSongProgress` to use `GameplayClockContainer`
2022-07-28 15:15:41 +08:00
Dan Balasescu
c1aaf27c54
Link to correct model in xmldoc
2022-07-28 16:02:19 +09:00
Dean Herbert
525e4a2019
Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting
2022-07-28 15:51:18 +09:00
Dan Balasescu
6bf293e130
Fix managed object reused between test runs
2022-07-28 15:45:33 +09:00
Dean Herbert
452d82f292
Add more comprehensive xmldoc for beatmap model classes
2022-07-28 15:41:28 +09:00
Salman Ahmed
ce48984bda
Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset
...
Remove nullable disable annotation in mods for taiko ruleset.
2022-07-28 09:32:35 +03:00
Dean Herbert
8ac886a247
Update test to account for sort order
2022-07-28 15:20:25 +09:00
Dean Herbert
67c44552cb
Add realm Refresh calls to ensure tests are stable
2022-07-28 15:18:04 +09:00
Dean Herbert
485d140a21
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 15:15:41 +09:00
Dean Herbert
070f56c30c
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 15:03:23 +09:00
Dean Herbert
2209afd0e8
Mark Live methods as InstantHandleAttribute
2022-07-28 15:03:08 +09:00
Dean Herbert
2ae5a34c0e
Add test coverage of beatmap updates transferring collection hashes
2022-07-28 15:02:58 +09:00
Salman Ahmed
1f13d89205
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset
2022-07-28 09:01:50 +03:00
Salman Ahmed
61bdcab651
Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset
...
Remove nullable disable annotation in mods for mania ruleset.
2022-07-28 08:57:12 +03:00
Dean Herbert
ca68574473
Make NotificationOverlay dependency optional in CollectionSettings
2022-07-28 14:35:27 +09:00
Salman Ahmed
c74ffea236
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset
2022-07-28 08:21:23 +03:00
Dean Herbert
392cb352cc
Force alphabetical ordering for now
2022-07-28 14:07:42 +09:00
Salman Ahmed
72961ec336
Flip method parameters to make sense
...
See 537f64c75e (r931785228)
2022-07-28 08:04:55 +03:00
Dean Herbert
da06467891
Add missing realm subscription cleanup
2022-07-28 13:57:21 +09:00
Dean Herbert
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
Dean Herbert
226eefcc5c
Add note about hash storage
2022-07-28 13:57:21 +09:00
Dean Herbert
1669208a54
Add migration of existing collections database
2022-07-28 13:57:21 +09:00
