928 Commits

• Merge pull request #24566 from peppy/multiplayer-spectator-score-diff

  Add score difference display to multiplayer spectator

  Bartłomiej Dach · 2023-08-16 12:57:17 +02:00
  ed84be2f26
• Update TournamentMatchScoreDisplay to share base implementation
  Dean Herbert · 2023-08-16 17:26:10 +09:00
  d309865b0d
• Improve visuals of tournament song bar

  This is a stop-gap until we add new versions (and share between game and tournament client).

  Dean Herbert · 2023-08-16 17:16:36 +09:00
  f02416f877
• let MatchIPCInfo .Beatmap be nullable
  cdwcgt · 2023-08-09 19:13:49 +09:00
  5ad80879b7
• Revert "use no null when true"

  This reverts commit 6ad8339c66.

  cdwcgt · 2023-08-09 19:11:36 +09:00
  5898a9986b
• Fix weird usage of Cast
  Dean Herbert · 2023-08-09 18:21:57 +09:00
  c88045dfc7
• remove useless using
  cdwcgt · 2023-07-30 02:50:16 +09:00
  99dd156d53
• remove nullable for Box
  cdwcgt · 2023-07-30 02:49:13 +09:00
  ba80d1e2d5
• string mod should not null

  Already assigned in the constructor

  cdwcgt · 2023-07-30 02:41:45 +09:00
  0590121309
• move to initialiser
  cdwcgt · 2023-07-30 02:41:45 +09:00
  bc2ca11bb0
• remove null check for b.Beatmap
  cdwcgt · 2023-07-30 02:41:44 +09:00
  a1f0e59784
• use no null when true
  cdwcgt · 2023-07-30 02:41:25 +09:00
  6ad8339c66
• remove all canBeNull from attribute
  cdwcgt · 2023-07-30 01:57:54 +09:00
  88a1cf4005
• fix nullable for TeamList
  cdwcgt · 2023-07-30 01:49:57 +09:00
  9482f74456
• RemoveTeam shouldn't have nullable arg
  cdwcgt · 2023-07-30 01:40:13 +09:00
  cb4adf115c
• debug assert closest != null
  cdwcgt · 2023-07-30 01:39:56 +09:00
  625ed729ee
• use cast instead AsNonNull
  cdwcgt · 2023-07-30 01:39:31 +09:00
  033c9091c0
• remove #nullable disable in tournament
  cdwcgt · 2023-07-29 22:25:06 +09:00
  8a06914438
• Merge branch 'master' into ladder-grid-expand
  Bartłomiej Dach · 2023-07-28 22:51:33 +02:00
  0c10d875ce
• Fix potential startup crash due to early application of animations

  This was always haphazard code, but by luck it never triggered before
  drawable load until now. With the recently nullability changes, this
  would be triggered when `flash` is not yet constructed.
  
  Switching to `AddOnce` seems safer to avoid multiple applications,
  regardless.

  Dean Herbert · 2023-07-28 17:17:15 +09:00
  f58c69e639
• Always place first match at (0,0)
  Dean Herbert · 2023-07-28 16:29:55 +09:00
  aa91000505
• Fix placing new match via right click not using original click position
  Dean Herbert · 2023-07-28 16:29:39 +09:00
  b5c3e2a648
• Allow ladder editor grid to scale with content

  Closes https://github.com/ppy/osu/issues/24378.

  Dean Herbert · 2023-07-28 16:26:03 +09:00
  b5f0d739e6
• Merge pull request #24357 from peppy/tournament-fix-null-population

  Fix startup tournament population not recovering from null beatmaps

  Dean Herbert · 2023-07-28 14:31:48 +09:00
  57e51f4d5b
• make SetupScreen scrollable
  Dao Heng Liu · 2023-07-28 14:18:48 +09:00
  c7717da232
• Merge branch 'master' into tournament-fix-null-population
  Bartłomiej Dach · 2023-07-27 22:36:11 +02:00
  780b8f0ec8
• Remove fallbacks to empty APIBeatmap on population failure

  Was causing there to be two kinds of missing `TournamentBeatmap`s: one
  with missing `Beatmap == null`, and one with `Beatmap == new
  APIBeatmap()`. In particular, they would appear differently in UI
  (either as "unknown - unknown", or the intensely enigmatic " - ").

  Bartłomiej Dach · 2023-07-27 22:33:00 +02:00
  b7ddb5c946
• Fix even more missed nullability-related inspections
  Bartłomiej Dach · 2023-07-27 22:10:41 +02:00
  3c923b9e81
• Fix some missed null checks
  Dean Herbert · 2023-07-27 17:41:27 +09:00
  1e9b927b50
• Apply NRT and avoid throws from null RoundBeatmap.Beatmaps
  Dean Herbert · 2023-07-26 17:49:07 +09:00
  fa4992f05a
• Merge branch 'master' into fix-scheduler-screen-selection-alignment
  Bartłomiej Dach · 2023-07-25 18:44:44 +02:00
  72db0c17ca
• Privatise currentMatchSelectionBox

  Because nobody else should need to do anything as cursed as what
  `ScheduleScreen` was doing (which is 95% of the reason why the selection
  box even broke there).

  Bartłomiej Dach · 2023-07-25 18:41:54 +02:00
  43876ba2b0
• Cache IDialogOverlay in a simpler way
  Dean Herbert · 2023-07-25 18:33:41 +09:00
  0130c356ed
• Merge branch 'master' into tourney-dangerous-action-confirm
  Dean Herbert · 2023-07-25 18:27:58 +09:00
  2c5a329b04
• Merge branch 'master' into tourney-fix-screen-auto-switch
  Dean Herbert · 2023-07-25 17:18:43 +09:00
  7d5305c5e8
• Separate out each type of scheduled operation and refactor tidy-up code
  Dean Herbert · 2023-07-25 17:18:13 +09:00
  c84381d802
• Fix startup tournament population not recovering from null beatmaps
  Dean Herbert · 2023-07-25 16:35:00 +09:00
  219ba00fb2
• Fix misalignment of selection box on schedule screen
  Dean Herbert · 2023-07-25 16:32:48 +09:00
  d41fb98350
• Merge pull request #24346 from cdwcgt/tournament-no-unload-cover

  Use `DelayedLoadWrapper` in `TournamentBeatmapPanel` to avoid beatmap cover unload in map pool

  Dean Herbert · 2023-07-25 16:27:52 +09:00
  04c1333b59
• Reword comments to make more sense
  Dean Herbert · 2023-07-25 16:15:16 +09:00
  7b3bd0b042
• Fix typo in xmldoc
  Dean Herbert · 2023-07-25 14:51:51 +09:00
  718d94a937
• Merge pull request #24353 from bdach/fix-uneven-connectors

  Fix uneven spacing on match connectors in tournament ladder screen

  Dean Herbert · 2023-07-25 08:21:04 +09:00
  0cdf07ab12
• set LoadDelay to 0
  cdwcgt · 2023-07-25 07:45:48 +09:00
  6f66e2fdd7
• Fix uneven spacing on match connectors in tournament ladder screen

  Noticed in passing during review of #24347.

  Bartłomiej Dach · 2023-07-24 23:39:01 +02:00
  e3560d2a10
• Merge branch 'master' into tournament-resolution-fixes
  Bartłomiej Dach · 2023-07-24 21:27:20 +02:00
  3ccd0ca1b0
• Merge pull request #24349 from peppy/tournament-bindable-fixes

  Fix tournament client crashing occasionally when editing bracket

  Bartłomiej Dach · 2023-07-24 21:21:39 +02:00
  3af5c2b4f3
• Fix crash when switching ladder match selection multiple times
  Dean Herbert · 2023-07-25 01:46:45 +09:00
  4fdf885959
• Fix dodgy implementation of current bindable in DateTextBox
  Dean Herbert · 2023-07-25 01:46:45 +09:00
  e0c0797f55
• Add non-black background to right of tournament system
  Dean Herbert · 2023-07-25 01:44:32 +09:00
  62121ea14c
• Set a fixed minimum window size for the tournament client
  Dean Herbert · 2023-07-25 01:44:32 +09:00
  b7f706ad2b