35812 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into fix-carousel-centering-on-window-resize
  Bartłomiej Dach · 2021-01-05 21:30:39 +01:00
  fbbc26d7d8
• Merge pull request #11419 from peppy/fix-transform-mutation-from-disposal-thread

  Fix RemoveBlockingOverlay causing transform mutation from disposal threads

  Bartłomiej Dach · 2021-01-05 20:45:32 +01:00
  11e228b781
• Merge branch 'master' into fix-transform-mutation-from-disposal-thread
  Bartłomiej Dach · 2021-01-05 19:52:10 +01:00
  847d2d8deb
• Match code between updateSelectedBeatmap/Ruleset
  Dean Herbert · 2021-01-05 20:38:58 +09:00
  4b539b01c1
• Merge pull request #11420 from kyekiller/master

  Fix to toolbar tooltips

  Dean Herbert · 2021-01-05 17:43:32 +09:00
  3b98782964
• Merge pull request #11415 from frenzibyte/fix-ready-button-crash

  Fix multiplayer ready button crashing when deleting selected beatmap set

  Dean Herbert · 2021-01-05 15:58:09 +09:00
  60fc60fa00
• Remove hacky code
  Dean Herbert · 2021-01-05 14:54:59 +09:00
  ed6ffe2ef1
• Add simple test coverage
  Salman Ahmed · 2021-01-05 06:00:15 +03:00
  81355652fa
• Should pass all checks again now.
  KyeKiller · 2021-01-04 22:11:52 +00:00
  77e660e426
• Applied all tooltips to the right
  KyeKiller · 2021-01-04 22:01:12 +00:00
  1234d0fa04
• Merge branch 'master' into master
  kyekiller · 2021-01-04 21:07:12 +00:00
  254698d9a2
• Hit another oopie
  KyeKiller · 2021-01-04 21:05:28 +00:00
  0e42d415c1
• Moved tooltip to the left to stop the overflow
  KyeKiller · 2021-01-04 21:04:30 +00:00
  3468df840b
• Moved "ToolbarSocialButton" back
  KyeKiller · 2021-01-04 21:03:51 +00:00
  73f5e5aaf9
• Merge pull request #11418 from peppy/fix-storyboard-skip-starttime-regression
  Bartłomiej Dach · 2021-01-04 20:08:59 +01:00
  a86a7b08df
• Should remove codeFactor error
  KyeKiller · 2021-01-04 17:26:42 +00:00
  2e2b3ab5d4
• Moved "ToolbarSocialButton"

  This will remove it from coming off the screen.

  KyeKiller · 2021-01-04 17:21:31 +00:00
  2d1b52be0d
• Fix RemoveBlockingOverlay causing transform mutation from disposal threads
  Dean Herbert · 2021-01-04 17:49:11 +09:00
  3b08faa0ea
• Fix hasBeatmap potentially checking on outdated DeletePending value
  Salman Ahmed · 2021-01-04 10:28:41 +03:00
  485a57776b
• Schedule all calls to updateBeatmapState()
  Salman Ahmed · 2021-01-04 10:27:08 +03:00
  ea38b00b29
• Remove unused using
  Dean Herbert · 2021-01-04 15:40:22 +09:00
  9e0c490141
• Fix Storyboard's FirstEventTime not finding the true earliest event
  Dean Herbert · 2021-01-04 15:16:01 +09:00
  20d04d6933
• Add failing test for storyboard start time ordering
  Dean Herbert · 2021-01-04 15:15:23 +09:00
  cb7df0fe11
• Re-query beatmap info on database changes
  Salman Ahmed · 2021-01-04 09:00:16 +03:00
  445a4bd01c
• Revert database-side changes
  Salman Ahmed · 2021-01-04 08:50:30 +03:00
  ca5f2bcd4c
• Remove unnecessary using directive
  Salman Ahmed · 2021-01-04 08:12:31 +03:00
  1463ff2886
• Update soft-deletion logic to use model store's consumable items instead
  Salman Ahmed · 2021-01-04 07:47:08 +03:00
  738c94d193
• Add failing test case
  Salman Ahmed · 2021-01-04 07:45:29 +03:00
  df04dd21de
• Fix incorrect initial conditional

  Turns out this wasn't actually required.

  Dean Herbert · 2021-01-03 22:44:32 +09:00
  53e6a349bb
• Fix null condition inhibiting deselection events
  Dean Herbert · 2021-01-03 22:43:02 +09:00
  efb71713ef
• Merge pull request #11413 from peppy/fix-mod-settings-transfer-issues

  Fix difficulty adjust settings not being transferred correctly in multiplayer/playlists

  Dean Herbert · 2021-01-03 22:38:41 +09:00
  cd7a5ca23a
• Clarify & cleanup comments some
  Bartłomiej Dach · 2021-01-03 13:44:29 +01:00
  9e4a925ab1
• Rename parameters for readability
  Bartłomiej Dach · 2021-01-03 13:25:44 +01:00
  a3e29b9154
• Copy values using Bind to also copy defaults
  Dean Herbert · 2021-01-03 20:45:03 +09:00
  2501707d7d
• Update osu.Game/Online/API/APIMod.cs

  Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>

  Dean Herbert · 2021-01-03 17:04:16 +09:00
  6ad1b7767e
• Switch back to FirstOrDefault to allow for weird testing logic to pass
  Dean Herbert · 2021-01-03 16:46:24 +09:00
  99fa0e25dc
• Add internal pathway for ensuring correct application of bindable mods
  Dean Herbert · 2021-01-03 15:48:28 +09:00
  29dbb1cc0d
• Simplify some default value checks (we are sure the return is an IBindable)
  Dean Herbert · 2021-01-03 15:47:15 +09:00
  23e216fa0b
• Use SingleOrDefault for added safety when looking up mod acronyms
  Dean Herbert · 2021-01-03 15:38:30 +09:00
  1a44338124
• Ensure SelectionChanged events are only sent once when selection is null
  Dean Herbert · 2021-01-03 12:53:25 +09:00
  a6d4992997
• Add precautionary null checks to update methods in SongSelect
  Dean Herbert · 2021-01-03 12:18:35 +09:00
  caa5109e3a
• Merge pull request #11380 from bdach/unobserved-exceptions-pt-2

  Catch multiplayer client-related unobserved exceptions better

  Dean Herbert · 2021-01-02 23:36:49 +09:00
  8511112e28
• Merge pull request #11344 from Susko3/master

  Fix file and share associations on Android

  Dean Herbert · 2021-01-02 22:44:12 +09:00
  f8fe22df8f
• Fix the beatmap carousel not returning to centre correctly after resizing window
  Dean Herbert · 2021-01-02 22:05:41 +09:00
  e2de5bb8f9
• Merge pull request #11401 from peppy/fix-signalr-reconnect

  Allow signalr to retry connecting when connection is closed without an exception

  Dean Herbert · 2021-01-02 21:50:29 +09:00
  33d8d60717
• Merge branch 'master' into fix-signalr-reconnect
  Bartłomiej Dach · 2021-01-02 13:18:02 +01:00
  9ab1091281
• Merge pull request #11404 from bdach/bump-inspectcode
  Bartłomiej Dach · 2021-01-02 13:17:34 +01:00
  8d8e6d7bba
• Replace using static with explicit nested reference

  This seems to be an inspectcode bug, as the code is correct and
  compiles, but let's just work around it for now.

  Bartłomiej Dach · 2021-01-02 12:25:59 +01:00
  924af58f5b
• Disable "merge sequential patterns" suggestions

  As they were considered to be detrimental to code readability.

  Bartłomiej Dach · 2021-01-02 12:21:53 +01:00
  18ac97ca56
• Bump InspectCode tool to 2020.3.2
  Bartłomiej Dach · 2021-01-02 11:53:06 +01:00
  66bd847b45