73430 Commits

This Branch

This Branch

All Branches

• Merge pull request #33209 from bdach/mania-combo-accounting-rewind

  Fix combo accounting when rewinding mania replays

  Dean Herbert · 2025-05-23 16:47:36 +09:00
  fa92fbb9d1
• Merge pull request #33236 from bdach/disclaim-harder

  Attempt to give users better disclaimer on how not to nuke their data

  Dean Herbert · 2025-05-23 15:12:32 +09:00
  1e29753c1f
• Adjust wording
  Bartłomiej Dach · 2025-05-23 08:09:29 +02:00
  af5a1cea94
• Fix github code quality ping
  Dean Herbert · 2025-05-23 14:52:41 +09:00
  68264eb1ad
• Attempt to give users better disclaimer on how not to nuke their data

  I can't count the number of times where someone backed up just the file
  store without the realm database and lost data. As such this moves the
  "IMPORTANT READ ME" disclaimer a directory higher and attempts to
  describe the "proper" backup procedure in detail.
  
  People don't read, but maybe this will at least partially lower the
  volume.

  Bartłomiej Dach · 2025-05-22 19:16:42 +02:00
  6a3e9a9093
• Merge pull request #33222 from frenzibyte/ssv2-no-results-transitions

  SongSelectV2: Fix "no results" placeholder having weird transitions

  Dean Herbert · 2025-05-23 01:51:55 +09:00
  9bee290063
• Merge pull request #33216 from frenzibyte/user-tags-transition

  SongSelectV2: Show loading spinner underneath user tags during transitions

  Dean Herbert · 2025-05-23 01:49:05 +09:00
  335427b420
• Merge pull request #33229 from frenzibyte/ssv2-select-recommended-diff

  SongSelectV2: Choose recommended difficulty on beatmap selection

  Dean Herbert · 2025-05-23 01:09:35 +09:00
  07de5d5131
• Merge pull request #33228 from frenzibyte/ssv2-leaderboard-total-count

  SongSelectV2: Display total scores count in personal best score

  Dean Herbert · 2025-05-22 22:52:34 +09:00
  2ddd789248
• Remove unnecessary initial text content duplicate
  Dean Herbert · 2025-05-22 22:52:19 +09:00
  4d309ded2e
• Code quality fixes
  Dean Herbert · 2025-05-22 22:41:11 +09:00
  41feba120b
• Merge pull request #33232 from bdach/editor-playback-speed-application-safer

  Improve reliability of unapplying speed adjustment on exiting editor

  Dan Balasescu · 2025-05-22 19:19:11 +09:00
  99e342043a
• Merge pull request #33234 from bdach/editor-player-instantiate-correct-result-type

  Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Dan Balasescu · 2025-05-22 18:58:40 +09:00
  1ba4c9d0d6
• Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Closes https://github.com/ppy/osu/issues/33231.
  
  I'm not sure how to reproduce the instances of this reported to sentry
  with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
  by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
  in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
  just start gameplay test while editor is seeked to a time instant where
  a hold note is mid-hold.
  
  There's possibly an argument here that `CreateResult()` should live on
  `HitObject` and not `DrawableHitObject`, and I'd even be partial to such
  an argument, but doing that would be a rather hard ruleset API break
  (albeit trivial one to resolve), and also may dredge up past
  conversations about `Judgement` and `JudgementResult` (cf.
  https://github.com/ppy/osu/pull/26563) that I would rather not get into
  again.
  
  Notably this is not source-breaking for rulesets. It may be
  binary-breaking, I haven't tested.

  Bartłomiej Dach · 2025-05-22 10:20:39 +02:00
  70c6ddbe30
• Improve reliability of unapplying speed adjustment on exiting editor

  Probably closes https://github.com/ppy/osu/issues/33230.
  
  I say "probably" because I couldn't reproduce this myself using the
  scenario provided in the issue but looking at the code involved I can
  see why it would happen. Long and short of it is that the speed
  adjustment cleanup code was much too reliant on disposal executing
  quickly, which as we've learned on several occasions before, cannot be
  relied upon.

  Bartłomiej Dach · 2025-05-22 09:28:47 +02:00
  b7c695b47c
• Merge pull request #33223 from frenzibyte/nominations-incorrect

  Fix nominations count logic not updated to newer API structure

  Bartłomiej Dach · 2025-05-22 08:01:45 +02:00
  c632383ccb
• Add test coverage
  Salman Alshamrani · 2025-05-22 01:44:30 +03:00
  aacb1ea58d
• Choose recommended difficulty when selecting a beatmap set
  Salman Alshamrani · 2025-05-22 01:44:24 +03:00
  f6c3dc502a
• Display total scores count in personal best score
  Salman Alshamrani · 2025-05-22 00:58:07 +03:00
  9e720509db
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Simplify test
  Salman Alshamrani · 2025-05-21 23:53:25 +03:00
  a8dc954efd
• Fix test not working due to incorrect setup
  Dean Herbert · 2025-05-22 04:54:03 +09:00
  08c8b6f17a
• Add test coverage
  Salman Alshamrani · 2025-05-21 19:01:47 +03:00
  17afea431b
• Fix nominations count system not updated to newer API structure
  Salman Alshamrani · 2025-05-21 17:35:13 +03:00
  bd2851c386
• Fix "no results" placeholder having weird transitions
  Salman Alshamrani · 2025-05-21 15:44:49 +03:00
  3f2ba893ba
• Merge pull request #33210 from bdach/strict-tracking-rewind

  Fix Strict Tracking running miss-on-tracking-loss logic during rewind

  Dan Balasescu · 2025-05-21 21:27:01 +09:00
  0ca7e359b8
• Merge pull request #33191 from peppy/fix-aggressive-diffcalc

  Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

  Dan Balasescu · 2025-05-21 20:48:14 +09:00
  662cbfcc48
• Resolve inspections
  Dan Balasescu · 2025-05-21 20:00:05 +09:00
  f967091aad
• Merge pull request #33208 from tsunyoku/increase-diff-calc-ci-timeout

  Increase diff calc processor timeout minutes

  Dan Balasescu · 2025-05-21 19:55:30 +09:00
  ec7e82ddfa
• Merge pull request #33203 from frenzibyte/carousel-select-first-visible

  Fix carousel potentially selecting filtered difficulty

  Dean Herbert · 2025-05-21 18:15:48 +09:00
  275dcca4b5
• Show loading spinner underneath user tags during transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  135fc47766
• Add test for metadata wedge loading transitions
  Salman Alshamrani · 2025-05-20 23:52:40 +03:00
  c23abe818c
• Use better method to select first difficulty
  Salman Alshamrani · 2025-05-20 21:42:19 +03:00
  59b0ab7f46
• Merge pull request #33200 from frenzibyte/fix-song-select-test

  Fix song select tests not loading footer buttons with dependencies

  Dean Herbert · 2025-05-21 00:40:30 +09:00
  23bd1e5d72
• Merge pull request #33207 from frenzibyte/ssv2-hook-mod-to-selected-beatmap

  SongSelectV2: Hook mod select overlay to selected beatmap

  Dean Herbert · 2025-05-21 00:38:36 +09:00
  c5ec25358d
• Merge pull request #33205 from frenzibyte/carousel-disable-status-animation

  Disable status pill animation on carousel panels

  Dean Herbert · 2025-05-21 00:37:49 +09:00
  420a49b812
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Merge pull request #33202 from frenzibyte/hidden-beatmap-difficulties

  Fix hidden beatmap difficulties not handled in new carousel

  Dean Herbert · 2025-05-21 00:33:36 +09:00
  875414a47a
• Add very basic transition for DifficultyIcon colour changes
  Dean Herbert · 2025-05-20 22:12:03 +09:00
  d9c376067d
• Fix Strict Tracking running miss-on-tracking-loss logic during rewind

  Probably closes https://github.com/ppy/osu/issues/29945.

  Bartłomiej Dach · 2025-05-20 14:17:16 +02:00
  3a136a4c81
• Add failing test case
  Bartłomiej Dach · 2025-05-20 14:17:15 +02:00
  b2de486aec
• Increase diff calc processor timeout minutes
  tsunyoku · 2025-05-20 11:29:46 +01:00
  a1bdbd8ec3
• Add demonstrative test coverage of combo accounting being order-agnostic
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  1576001491
• Adjust combo accounting in score processor to be order-agnostic

  Closes https://github.com/ppy/osu/issues/21732.
  
  While the problem of multiple judgements in one frame and ordering of
  `RevertResult()` calls as described in the issue is a real one, this
  commit is a bit of a sidestep of the entire issue.
  
  The idea here that while *snapshots* of instantaneous combo values are
  susceptible to such ordering foibles on revert, *deltas* are not - and
  such, when deltas are using to update the combo counts on revert,
  ordering stops mattering so much.

  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  237de1ef72
• Add protective test coverage of combo accounting
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  561578c0e9
• Add failing test case
  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  b60cf08635
• Fix solo results screen tests better

  See 12b09586c7.

  Bartłomiej Dach · 2025-05-20 12:10:07 +02:00
  6a56ed1d3b
• Merge pull request #33199 from pe1agio/iss32064

  Fix inconsistent display of rotation in tooltip when dragging selection box rotation handles

  Bartłomiej Dach · 2025-05-20 12:02:08 +02:00
  687c0e5cc0
• Fix solo results screen test failure

  As spotted in https://github.com/ppy/osu/pull/33191/checks?check_run_id=42460062656
  
  Seems like just a bog-standard race. Could be reproduced via
  
  diff --git a/osu.Game/Screens/Ranking/SoloResultsScreen.cs b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  index d11e7db178..1a594fd21b 100644
  --- a/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  +++ b/osu.Game/Screens/Ranking/SoloResultsScreen.cs
  @@ -45,6 +45,8 @@ protected override async Task<ScoreInfo[]> FetchScores()
               if (Score.BeatmapInfo!.OnlineID <= 0 || Score.BeatmapInfo.Status <= BeatmapOnlineStatus.Pending)
                   return [];
  
  +            await Task.Delay(5000).ConfigureAwait(false);
  +
               var criteria = new LeaderboardCriteria(
                   Score.BeatmapInfo!,
                   Score.Ruleset,

  Bartłomiej Dach · 2025-05-20 11:09:18 +02:00
  12b09586c7
• Merge pull request #33194 from bdach/mania-hold-rewind

  Fix hold notes getting incorrectly missed after rewinding gameplay

  Dan Balasescu · 2025-05-20 16:48:26 +09:00
  17819ba592