73352 Commits

This Branch

This Branch

All Branches

• Split beatmap set if either sort or group mode is difficulty
  Salman Alshamrani · 2025-05-18 01:31:43 +03:00
  f8cec19f04
• Add test coverage
  Salman Alshamrani · 2025-05-18 01:28:56 +03:00
  2b37e7f26c
• Add grouping support for most modes
  Salman Alshamrani · 2025-05-18 01:28:56 +03:00
  82923e6769
• Tidy up GroupMode enum
  Salman Alshamrani · 2025-05-18 01:28:56 +03:00
  25a3ac2c00
• Merge pull request #33148 from bdach/emit-important-replay-frames-on-judgements

  Emit important replay frames on every judgement

  Dean Herbert · 2025-05-17 23:41:12 +09:00
  8c053e856f
• Add matching comment in SpectatorClient for clarity
  Dean Herbert · 2025-05-17 23:33:46 +09:00
  7c44883042
• Merge pull request #33161 from bdach/replay-decode-float-woes

  Fix possible replay playback inaccuracy with very large lead-in time

  Dean Herbert · 2025-05-17 12:31:38 +09:00
  6346cff380
• Merge pull request #33142 from frenzibyte/ssv2-score-opens-results

  SongSelectV2: Open results screen when clicking leaderboard scores

  Bartłomiej Dach · 2025-05-16 14:10:07 +02:00
  fdd489992c
• Merge branch 'master' into ssv2-score-opens-results
  Bartłomiej Dach · 2025-05-16 13:23:38 +02:00
  ea55fa2703
• Fix code quality
  Bartłomiej Dach · 2025-05-16 13:23:05 +02:00
  4992e4e5e1
• Merge pull request #33160 from peppy/carousel-animation-fixes

  Fix multiple inconsistencies in beatmap carousel animations

  Bartłomiej Dach · 2025-05-16 13:20:56 +02:00
  31fe6e4ec0
• Merge pull request #33159 from peppy/song-select-v2-mod-reset-right-click

  SongSelectV2: Add support for deselecting all mods by right clicking mod button

  Bartłomiej Dach · 2025-05-16 13:13:46 +02:00
  8f5d97157c
• Fix possible replay playback inaccuracy with very large lead-in time

  Closes https://github.com/ppy/osu/issues/22086
  
  While this *is* a case of aspire-tier breakage, I hesitate to dismiss it
  as wontfix, because the fix is somewhat easy, and probably results in
  better accuracy across the board.
  
  The issue in question here manifests when there is a significant amount
  of lead-in time, like what the beatmap linked in the aforementioned
  issue (https://osu.ppy.sh/beatmapsets/948643#osu/1981090) does.
  
  Both stable and lazer record replay frames using absolute timestamps,
  *but* the legacy replay format after the first frame uses time *deltas*,
  i.e. amounts of time elapsed since the previous frame. This means that
  the decoding process of the replay has to reconstruct absolute timestamps
  by doing cumulative summation starting from the first frame.
  
  When the very first frame has a timestamp that is very large in
  magnitude (say, like the negative 2 billion that the beatmap in question
  uses), this will lead to error if the cumulative summation is using
  floating point numbers, because it will be adding a small magnitude
  frame delta to a large magnitude cumulative absolute time. Which means
  that sometimes adding the frame delta to the cumulative time *will not
  change the cumulative time*, leading to the loss of time and thus replay
  de-synchronisation.
  
  Knowing that the legacy replay format only deals in integral time
  values, however, this can be circumvented by just using a large enough
  integral number type for the cumulative time tracking instead. I think
  `long` in this case can be safely used "large enough" for our purposes:
  
  	> Console.WriteLine(long.MaxValue);
  	9223372036854775807
  
  	9 223 372 036 854 775 807 ms equals 292 277 024,6269277149 years

  Bartłomiej Dach · 2025-05-16 12:52:49 +02:00
  56e17dd7ba
• Add failing test case
  Bartłomiej Dach · 2025-05-16 12:45:47 +02:00
  8854db0264
• Use larger offset to ensure depth is still backmost even with DepthLayer is in use
  Dean Herbert · 2025-05-16 19:08:54 +09:00
  bfc23c98f1
• Add test coverage of opening score from song select v2
  Dean Herbert · 2025-05-16 18:35:38 +09:00
  c642d06576
• Rename new song select interface to be more generic and add score presentation to it
  Dean Herbert · 2025-05-16 18:22:42 +09:00
  bc35b58db6
• Open results screen when clicking leaderboard scores
  Salman Alshamrani · 2025-05-16 18:22:42 +09:00
  4ec4923c17
• SongSelectV2: Add support for deselecting all mods by right clicking mod button

  Addresses https://github.com/ppy/osu/discussions/28301.
  
  No sound effects on click because right click handling is weird. I would
  have liked to call `DeselectAll` on the mod select overlay, but this
  doesn't work unless it's displayed due to queued operation.

  Dean Herbert · 2025-05-16 18:22:25 +09:00
  a8b247f7f1
• Rename and expose some song select test properties better
  Dean Herbert · 2025-05-16 18:21:57 +09:00
  7474a7a251
• Avoid animating list tail

  At very high scroll speeds (using pageup/pagedown) you would see a weird
  animation of panels appearing. This removes the animation for that edge
  case.

  Dean Herbert · 2025-05-16 17:45:32 +09:00
  a32da2ea10
• Add new panels to carousel with a better initial Y position

  Previously, carousel panels would appear immediately at their required Y
  position. This didn't look great when they appear with other panels
  surrounding them.
  
  Now they will spawn in underneath the nearest item before them, making
  the animation feel much more correct.

  Dean Herbert · 2025-05-16 17:23:08 +09:00
  615d4accfb
• Add fade animation when carousel panels are expired

  This fixes the hard cut that was previously very jarring.

  Dean Herbert · 2025-05-16 17:21:49 +09:00
  6a2337dbea
• Fix depth flip-flopping during initial animation
  Dean Herbert · 2025-05-16 17:14:27 +09:00
  7efa724a8a
• Remove misplaced assert
  Dean Herbert · 2025-05-16 17:14:11 +09:00
  0302a37190
• Also perform time-based frame de-duplication at frame bundle level

  See https://github.com/ppy/osu/pull/33148#discussion_r2092467082

  Bartłomiej Dach · 2025-05-16 09:39:29 +02:00
  baf069ccf7
• Adjust failing replay recording tests

  cd4ab9307c made these tests fail because
  they were basically pressing and releasing a key in a single frame,
  which hopefully never actually happens in real scenarios. (It's a bit
  tricky to determine if it can.)

  Bartłomiej Dach · 2025-05-16 08:59:56 +02:00
  953a93309c
• Do not emit multiple consequent replay frames with the exact same data

  With judgements occurring forcing emission of important frames, there's
  the question of emitting redundant frames. In a majority of cases
  still, a judgement *will* be tied to a specific user input, which means
  that there's a high likelihood of duplicate frames, as one will be
  emitted by the input change, and another by the judgement.
  
  To a degree this is a pre-existing issue. The replay recording code
  responds to both mouse movement and key presses by recording frames, so
  depending on the intrinsic (basically undefined) ordering between
  handling mouse move and key presses, it was possible for multiple frames
  to be emitted with the same timestamp to the replay, each containing
  partial input state changes (e.g. first frame with mouse position
  changed, and the second with a key pressed).
  
  The extent to which this increases the frame count will obviously depend
  on the beatmap, but in my ballpark testing across all rulesets on a
  single "relatively standard" beatmap (think no aspire chicanery), around
  4-10% of frames can end up being duplicates / not meaningful. This has
  implications both on replay size and on playback performance.
  
  This commit therefore performs de-duplication of the frames based on
  timestamp - only the last frame with a given timestamp ends up in the
  final replay.
  
  The CPU cost of this is negligible to the point of not being useful to
  profile - it's a single condition gated behind a single float comparison

  Bartłomiej Dach · 2025-05-16 08:40:07 +02:00
  cd4ab9307c
• Tidy up TestSceneFooterButtonMods tests
  Dean Herbert · 2025-05-16 15:04:45 +09:00
  45d248cd26
• Merge pull request #33149 from peppy/song-select-v2-footer-beatmap-options
  Bartłomiej Dach · 2025-05-15 16:12:26 +02:00
  199da9c48c
• Fix line lost in merge resolution causing footer to disappear
  Dean Herbert · 2025-05-15 21:37:53 +09:00
  bc5c222953
• Fix compile failure
  Bartłomiej Dach · 2025-05-15 13:59:56 +02:00
  4924563eb1
• Hook up footer beatmap options via new ISongSelectBeatmapActions class
  Dean Herbert · 2025-05-15 20:31:54 +09:00
  9fea4a2ed0
• Fix screen footer buttons not having access to screen dependencies
  Dean Herbert · 2025-05-15 20:27:51 +09:00
  5a17d3c290
• Merge pull request #33147 from peppy/tidy-screen-footer

  Tidy some `ScreenFooter` code

  Dean Herbert · 2025-05-15 20:27:12 +09:00
  6897d53dbe
• Merge branch 'master' into tidy-screen-footer
  Bartłomiej Dach · 2025-05-15 12:55:28 +02:00
  0132b78eec
• Fix nullability inspections
  Bartłomiej Dach · 2025-05-15 12:55:21 +02:00
  840e51e6a1
• Merge pull request #33141 from frenzibyte/footer-fix-back-button

  Fix back button not displaying when transitioning to non-footer screen

  Dean Herbert · 2025-05-15 19:34:58 +09:00
  7f16feb92c
• Emit important replay frames on every judgement

  - Closes https://github.com/ppy/osu/issues/4287
  - Probably closes https://github.com/ppy/osu/issues/25405 (but not
    retroactively)
  
  Up until now, whether or not a replay frame is emitted depended solely
  on the user's input, i.e. mouse movement or key presses/releases. This,
  intersected with the replay playback system which is given allowance to
  perform interpolation between replay frames, leads to potential
  situations wherein a replay can play inaccurately when a judgement takes
  place without user input meaningfully changing. One such case is slider
  ends with their 36ms of judgement leniency; see
  https://github.com/ppy/osu/issues/25405#issuecomment-2879031106 for
  details on that.
  
  To that end, this commit aims to counteract that issue by *forcing* an
  important replay frame to be emitted on every new judgement recorded
  during gameplay. This will only benefit rulesets wherein judgements can
  occur that are not inherently tied to user input changing, which are
  going to be osu! as mentioned above, and maybe possibly catch. I don't
  foresee this doing anything relevant for taiko or mania.

  Bartłomiej Dach · 2025-05-15 11:43:09 +02:00
  9f91c2e25c
• Tidy up ScreenFooter and back button action flow
  Dean Herbert · 2025-05-15 18:37:42 +09:00
  087e054708
• Improve code quality
  Salman Alshamrani · 2025-05-15 12:26:28 +03:00
  60f56a0729
• Merge pull request #33118 from frenzibyte/ssv2-autoplay-shortcut

  SongSelectV2: Allow starting beatmap with autoplay via ctrl-enter

  Dean Herbert · 2025-05-15 18:18:15 +09:00
  137de6ed18
• Code quality fixes
  Dean Herbert · 2025-05-15 12:14:54 +03:00
  bb8d3bcf66
• Remove pointless dependency from ScreenFooter
  Dean Herbert · 2025-05-15 17:18:28 +09:00
  856693d7ee
• Fix song select test not waiting for initial filtering
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  da163c1751
• Allow starting beatmap with autoplay via ctrl-enter
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  8e7c093476
• Make carousel handle pressing enter with modifier keys
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  87c97ad0b5
• Add test coverage
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  e2ae3f2ad0
• Fix back button not displaying when transitoning to non-footer screen
  Salman Alshamrani · 2025-05-14 21:46:15 +03:00
  1829253b5a
• Add failing test case
  Salman Alshamrani · 2025-05-14 21:45:30 +03:00
  7dc9ea6774