179 Commits

• Default DrawableStoryboard to a completed state to avoid state change on empty storyboards
  Dean Herbert · 2021-06-18 16:08:49 +09:00
  06d1bd971c
• Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
  Dean Herbert · 2021-05-31 21:39:04 +09:00
  00b3eea840
• Remove no longer necessary conditional access
  Dean Herbert · 2021-05-28 15:42:35 +09:00
  631d217f78
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-05-28 14:47:35 +09:00
  6268bbea85
• Remove allowFallback parameters completely
  Dean Herbert · 2021-05-27 14:50:42 +09:00
  70a844ac10
• Change LINQ query for better readability
  Dean Herbert · 2021-05-25 18:51:51 +09:00
  342acadae2
• Rename classes as per review feedback
  Dean Herbert · 2021-05-25 18:50:33 +09:00
  871ca8054f
• Bypass 640x480 coordinate space for video storyboard elements

  This allows the `FillMode.Fill` to take up the full space of the
  storyboard container.

  Dean Herbert · 2021-05-25 16:17:29 +09:00
  5ea948aabe
• Allow storyboards to be widescreen if only a video element exists

  This matches stable behaviour, which will allow videos to display
  filling the screen if they are the only thing contained within the
  "storyboard".

  Dean Herbert · 2021-05-25 16:07:19 +09:00
  0c55bba220
• Move DrawableStoryboard's aspect application to inside its own class
  Dean Herbert · 2021-05-25 16:06:39 +09:00
  e3507d5453
• Cache last event time value to avoid super expensive LINQ
  Dean Herbert · 2021-05-04 16:48:13 +09:00
  18779b1d1e
• Implement Duration via the interface
  Dean Herbert · 2021-05-04 16:04:59 +09:00
  ffc88db47a
• Merge branch 'master' into play-storyboard-outro
  Dean Herbert · 2021-05-04 14:01:34 +09:00
  bb9fa1a25e
• Fix storyboard sample lifetimes not set if seeked past
  smoogipoo · 2021-04-20 17:14:48 +09:00
  d28eb399a4
• Rename IStoryboardElementHasDuration, remove unnecessary step in tests, add Duration field
  Christine Chen · 2021-04-18 20:20:14 -04:00
  98460c8feb
• Add further xmldoc
  Salman Ahmed · 2021-04-18 07:25:49 +03:00
  f6a09be62d
• Show score after the end of the storyboard after it was toggled
  Christine Chen · 2021-04-17 18:10:21 -04:00
  97bacbdc76
• Use GetEndTime() to get storyboard endtime
  Christine Chen · 2021-04-17 15:27:48 -04:00
  e40cb6797d
• Add remarks back to LatestEventTime
  Christine Chen · 2021-04-17 12:34:38 -04:00
  5a015290b9
• Move storyboard outro logic to DrawableStoryboard
  Christine Chen · 2021-04-16 00:59:10 -04:00
  b15838b220
• Add IHasDuration interface with EndTime for storyboard elements to implement
  Christine Chen · 2021-04-15 17:17:02 -04:00
  0e545e1ed9
• Allow skipping storyboard outro

  Reuses SkipOverlay by calculating the endtime of the storyboard and using that as a "start point". Upon skipping the outro the score is instantly shown.
  When the end of the storyboard is reached the score screen automatically shows up. If the player holds ESC (pause) during the outro, the score is displayed
  
  The storyboard endtime is calculated by getting the latest endtime of the storyboard's elements, or simply returning 0 if there is no storyboard.
  
  Co-Authored-By: Marlina José <marlina@umich.edu>

  Christine Chen · 2021-04-15 13:20:40 -04:00
  25b8c2f257
• Expose the latest end time of storyboard elements

  Co-authored-by: Marlina Bowring <marlina@umich.edu>

  Christine Chen · 2021-04-12 23:08:43 -04:00
  16d34bcc0a
• Fix xmldoc explaining incorrect behaviour

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-03-11 12:15:59 +09:00
  efb4a366d4
• Fix storyboard commands occurring before the earliest point of visibility delaying gameplay

  In osu-stable, storyboard intros start from the first command, but in
  the case of storyboard drawables which have an initial hidden state, all
  commands before the time at which they become visible (ie. the first
  command where `Alpha` increases to a non-zero value) are ignored.
  
  This brings lazer in line with that behaviour. It also removes several
  unnecessary LINQ calls.
  
  Note that the alpha check being done in its own pass is important, as
  it must be the "minimum present alpha across all command groups,
  including loops". This is what makes the implementation slightly
  complex.
  
  Closes #11981.

  Dean Herbert · 2021-03-09 15:55:12 +09:00
  8aaba32431
• Update HasFlag usages to HasFlagFast
  smoogipoo · 2021-02-25 15:38:56 +09:00
  dff1d80f39
• Add more comprehensive commenting and simplify base call logic

  We can call the base method regardless for better safety. Worst case
  it's just going to run `Stop()` twice anyway.

  Dean Herbert · 2021-02-01 16:43:54 +09:00
  05982f42ab
• Removed blank line
  Mysfit · 2021-01-26 23:12:26 -05:00
  ee89aa159c
• Allow looping storyboard samples to follow the base samplePlaybackDisabled event logic.
  Mysfit · 2021-01-26 23:08:51 -05:00
  690feb1c1e
• DrawableStoryboardSample event method override for SamplePlaybackDisabledChanged
  Mysfit · 2021-01-26 00:36:32 -05:00
  3307e8357f
• Simplify condition from two to one operand
  Bartłomiej Dach · 2021-01-22 20:35:34 +01:00
  b692abd3c2
• introduce overrideable bool instead of copying event logic entirely
  Mysfit · 2021-01-22 12:09:40 -05:00
  e0f8f6a23f
• Use callback method override
  Mysfit · 2021-01-21 20:06:24 -05:00
  5b1bdfbdc5
• Updated DrawableStoryboardSample to use GetBoundCopy()
  Mysfit · 2021-01-21 17:46:47 -05:00
  07ec0c0e0b
• Fix storyboard samples continuing to play when the beatmap is paused or the intro is skipped.
  Mysfit · 2021-01-21 17:10:11 -05:00
  b220939650
• Remove unused using
  Dean Herbert · 2021-01-04 15:40:22 +09:00
  9e0c490141
• Fix Storyboard's FirstEventTime not finding the true earliest event
  Dean Herbert · 2021-01-04 15:16:01 +09:00
  20d04d6933
• Fix a couple of simple cases of incorrect TextureLoaderStore initialisation
  Dean Herbert · 2020-12-21 13:35:46 +09:00
  a8569fe15c
• Better API for dealing with the contained drawable samples
  smoogipoo · 2020-11-30 19:26:25 +09:00
  c29ad8edf8
• Fix storyboard imlpementation
  smoogipoo · 2020-11-19 22:30:41 +09:00
  a53848ef9b
• Add initial hit sample pooling
  smoogipoo · 2020-11-19 19:51:09 +09:00
  730b14b5bb
• Remove redundant class name qualifier
  Bartłomiej Dach · 2020-11-10 12:20:49 +01:00
  61093030ee
• Rename variables
  Bartłomiej Dach · 2020-11-10 12:20:26 +01:00
  ce837eaba0
• Rewrite - Add empty drawable whenever sprite not found
  cadon0 · 2020-11-10 23:52:37 +13:00
  539806e9d6
• Fix paths for storyboard animation sprites
  cadon0 · 2020-11-10 23:52:37 +13:00
  6446074976
• Fix regression causing storyboard sprites to have incorrect origin support
  Dean Herbert · 2020-10-23 15:46:24 +09:00
  4f746792fb
• Centralise and share logic for storyboard frame lookup method
  Dean Herbert · 2020-10-23 15:34:00 +09:00
  1b84402b96
• Utilise UseSkinSprites value in storyboard sprite logic
  Bartłomiej Dach · 2020-10-20 23:01:25 +02:00
  58a54c5b6c
• Read UseSkinSprites when decoding storyboards
  Bartłomiej Dach · 2020-10-20 22:49:56 +02:00
  cdd56ece87
• Use SkinnableSprite to avoid unnecessary reloads
  Bartłomiej Dach · 2020-10-20 22:49:56 +02:00
  e54836a63e