81 Commits

• Remove unused using statement
  Dean Herbert · 2021-06-18 19:39:01 +09:00
  2dadc9d686
• Fix renaming a ruleset DLL causing a startup crash
  Dean Herbert · 2021-06-18 19:32:40 +09:00
  78c5ccda60
• Ignore possible nulls in Type.GetType() calls

  They're mostly used in extensibility scenarios, so everything happens in
  runtime. There is no better resolution than to crash with a null
  reference exception.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  628e7a71ed
• Remove unused using directive
  Salman Ahmed · 2021-04-02 02:45:26 +03:00
  5b1dc7d2b4
• Guard against same ruleset file with loaded assembly filenames instead
  Salman Ahmed · 2021-04-02 02:12:25 +03:00
  fcd56dba44
• Change .StartsWith() to .Equals()

  In line with planned-but-delayed breaking change.

  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  68352782db
• Replace with local tolist
  smoogipoo · 2020-10-16 23:40:44 +09:00
  6385d5f369
• Silence EF warning due to ordinal being unsupported
  smoogipoo · 2020-10-16 23:31:37 +09:00
  81cc5e1c42
• Add missing string function ordinal specifications
  Dean Herbert · 2020-10-16 12:49:31 +09:00
  cc41845f56
• Fix crash when same ruleset loaded more than once

  If the same ruleset assembly was present more than once in the current
  AppDomain, the game would crash. We recently saw this in Rider EAP9.
  While this behaviour may change going forward, this is a good safety
  measure regardless.

  Dean Herbert · 2020-08-11 11:09:02 +09:00
  471ed968e3
• Use OrderByDescending
  Dean Herbert · 2020-07-31 16:21:47 +09:00
  62ba214dad
• Fix dynamic compilation loading wrong ruleset versions
  smoogipoo · 2020-07-30 21:10:13 +09:00
  23ab6f8f94
• Fix incorrect usage of Directory.GetFiles
  Dean Herbert · 2020-06-02 14:55:10 +09:00
  6c8c95677f
• Remove unnecessary use of and remove StartupStorage
  Salman Ahmed · 2020-05-31 19:49:03 +03:00
  2c6887e610
• Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory

  Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).

  Salman Ahmed · 2020-05-31 02:24:49 +03:00
  82fe99cf4a
• Change comparison direction
  Dean Herbert · 2020-05-08 20:33:02 +09:00
  5c2778d5f0
• Fix loading a ruleset with a new version specification causing a crash
  Dean Herbert · 2020-05-08 18:05:06 +09:00
  a59db976d6
• Add spaces to comments
  alex · 2020-05-04 18:36:24 -07:00
  0e2ccac33b
• Resolve ruleset dependencies on game core / framework assemblies by checking already loaded assemblies in AppDomain.
  Lucas A · 2020-04-20 13:56:15 +02:00
  a541f92682
• Fix whitespace formatting
  Bartłomiej Dach · 2020-04-19 16:29:32 +02:00
  1dcb0f53a2
• Add comment in regards to the attaching of event handler to the assembly lookup event before call to loadUserRulesets().
  Lucas A · 2020-04-19 15:26:00 +02:00
  ba1c465edf
• Fix comment wording

  Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Lucas A · 2020-04-19 15:15:04 +02:00
  a7179d1c87
• Don't search for user rulesets if rulesetsStorage isn't set (Testing environnment)
  Lucas A · 2020-04-07 16:01:47 +02:00
  2087d8d09e
• Apply review suggestions
  Lucas A · 2020-04-07 12:22:09 +02:00
  08308e07e7
• Add back cached ruleset assembly lookup
  Lucas A · 2020-04-04 20:13:46 +02:00
  0e45a4d54e
• Load user rulesets from the game data directory
  Lucas A · 2020-04-03 21:40:09 +02:00
  8cdae790c3
• Update RulesetStore to read from populated defaults
  Dean Herbert · 2019-12-24 16:16:55 +09:00
  fcb7a9ade5
• Remove LegacyID from Ruleset
  Dean Herbert · 2019-12-24 13:48:27 +09:00
  a324bfbc2c
• Remove RulesetInfo parameter from Ruleset constructor
  Dean Herbert · 2019-12-18 14:49:09 +09:00
  6e0802e50c
• Apply brace style.
  Huo Yaoyuan · 2019-11-11 20:13:13 +08:00
  ccc8aa6fa4
• Remove finalizer
  smoogipoo · 2019-10-17 11:27:23 +09:00
  9b9138253c
• Remove out-of-date todo
  smoogipoo · 2019-10-15 16:16:33 +09:00
  96c6aeefe9
• Make RulestStore initialise at construction time
  smoogipoo · 2019-10-15 16:14:06 +09:00
  12cd57744b
• Fix CI error
  smoogipoo · 2019-10-01 15:41:09 +09:00
  ce609302ed
• Log the exception that caused to loading of rulesets to fail.
  miterosan · 2019-09-29 19:25:44 +02:00
  9f498d2990
• Fix rulesets not matching in dictionary lookups due to missing GetHashCode implementation
  Dean Herbert · 2019-07-15 15:42:54 +09:00
  9c1badd2e3
• More methods
  Dean Herbert · 2019-07-03 18:42:10 +09:00
  8120bb36bc
• Fix typo
  Dean Herbert · 2019-07-03 18:41:01 +09:00
  06ef8f71e9
• Refactor comment slightly
  Dean Herbert · 2019-07-03 18:36:04 +09:00
  62dd89197c
• Remove whitespaces and lowercase the comments
  miterosan · 2019-07-03 10:57:09 +02:00
  5ecb764cdc
• Add comment about the android ruleset situation.
  miterosan · 2019-07-03 10:54:10 +02:00
  43d7f66c5b
• Only log that the rulesets could not be loaded from a directory.
  miterosan · 2019-07-03 10:21:18 +02:00
  ab244d1b7f
• Use addRuleset inside loadRulesetFromFile
  miterosan · 2019-07-03 09:51:09 +02:00
  d9e646d9ef
• style fixes
  miterosan · 2019-07-02 17:25:12 +02:00
  f1ceea8361
• Allow discover of rulesets that are already loaded.
  miterosan · 2019-07-02 17:05:04 +02:00
  778c36c7d7
• Fix test dlls being loaded as actual rulesets (and failing)
  Dean Herbert · 2019-02-19 12:13:55 +09:00
  133c002d02
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Fix rulesets not loading in debug builds after running a release build
  Dean Herbert · 2018-07-01 18:03:15 +09:00
  98fb2e03c0
• Fix mania maps not being treated as mania maps in release builds
  Dean Herbert · 2018-06-28 17:10:30 +09:00
  b1a3f01212
• Logexceptions when loading ruleset DLLs
  Dean Herbert · 2018-06-03 00:28:29 +09:00
  88628812c6