osu-lazer

Allow setting Entry of PoolableDrawableWithLifetime

It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
Also, the object initializer syntax can be used.

ekrctb · 2021-06-16 16:00:08 +09:00

117e94bc94

Add missing CurrentSkin null check in DHO disposal

Bartłomiej Dach · 2021-06-11 09:18:58 +02:00

296761ade5

Fix incorrect method referenced in xmldco

Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>

Dean Herbert · 2021-06-09 14:20:01 +09:00

b8df3fff9e

Add one missing obsoletion removal date

Dean Herbert · 2021-06-09 14:11:50 +09:00

62199a38a8

Remove more obsoleted members

Dean Herbert · 2021-06-09 14:10:48 +09:00

f41e34ae2c

Fix comment grammar

ekrctb · 2021-05-30 13:06:28 +09:00

abb77b95b4

Fix wrong/misleading comment of InitialLifetimeOffset

ekrctb · 2021-05-28 17:19:36 +09:00

1d5e8f4a91

Add a mention that OnApply/OnFree is performed after ApplyDefaults

Dean Herbert · 2021-05-27 15:20:35 +09:00

122bb05aa8

Fix DHOs not receiving initial skin changed events

smoogipoo · 2021-05-24 14:07:40 +09:00

7494ddeef4

Merge pull request #12592 from ekrctb/fix-entry-lifetime

Fix Setting DHO's lifetime doesn't update its entry lifetime

Dan Balasescu · 2021-04-28 01:38:19 +09:00

5fc731967b

Update osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

Derrick Timmermans · 2021-04-27 11:29:16 +02:00

3ea55314f2

Use overriding instead of hiding in HitObjectLifetimeEntry

Hidden properties are used when the type is the base class. It caused issues when `DrawableHitObject` logic is factored out to `PoolableDrawableWithLifetime` because it is using the base `LifetimeEntry`, not `HitObjectLifetimeEntry`.

ekrctb · 2021-04-27 15:23:33 +09:00

a2c0951d94

Add method to safely refresh DrawableHitObject transforms

Derrick Timmermans · 2021-04-26 20:08:40 +02:00

08a232f7fa

Rename DrawableObject -> PoolableDrawableWithLifetime

ekrctb · 2021-04-26 12:06:21 +09:00

6561a7c7d6

Remove redundant statement (lifetime is set in base)

ekrctb · 2021-04-26 11:47:38 +09:00

e6474e6ff7

Factor out pooling and lifetime management logic of DHO to a base class

ekrctb · 2021-04-21 17:37:42 +09:00

b877a29737

Remove SkinReloadableDrawable inheritance from DHO

ekrctb · 2021-04-21 17:34:57 +09:00

bbf2ec369b

Deprecate old overload of Apply

ekrctb · 2021-04-21 14:32:37 +09:00

3fbeadf318

Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.

HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.

ekrctb · 2021-04-21 11:32:01 +09:00

73d3da1687

Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO."

This reverts commit 67fcfd9d

ekrctb · 2021-04-21 10:02:50 +09:00

44ff08cce4

Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.

HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.

ekrctb · 2021-04-21 09:48:16 +09:00

67fcfd9dbc

Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry

"Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.

ekrctb · 2021-04-21 09:23:23 +09:00

e80c3c317a

Ensure a non-null hitobject entry has a non-null Result

ekrctb · 2021-04-20 15:18:36 +09:00

c6ee4e900e

Make single-argument overloead of DHO.Apply public

ekrctb · 2021-04-20 10:11:36 +09:00

8a8b9084ef

Now, DHO.lifetimeEntry can be non-null even it is not fully applied

ekrctb · 2021-04-20 09:22:16 +09:00

1bc63a4c61

Create synthetic LifetimeEntry for a DHO when not supplied

Now, a DHO is always associated with a HitObjectLifetimeEntry while used.
Result is always stored in the entry, and not in the DHO.

ekrctb · 2021-04-19 21:54:19 +09:00

2c487ddb70

Make DHO application logic clearer with Entry/HitObject separation

ekrctb · 2021-04-19 19:56:17 +09:00

5afdc3ff66

Remove usage of Lazy<List<...>> for NestedHitObjects

ekrctb · 2021-04-15 18:26:01 +09:00

50fad47ebc

Remove empty <returns> xmldoc

Dean Herbert · 2021-04-12 17:46:14 +09:00

b5954a55ad

Remove unused using

smoogipoo · 2021-04-09 13:58:24 +09:00

76981f2547

Remove obsolete code

smoogipoo · 2021-04-09 13:56:58 +09:00

8293b06c0a

Fix mistaken obsoletion notice

It was added in c9f38f7bb6, which
specified 2021 in another place (and was committed in October of 2020
anyway). Update the year so that it doesn't get culled prematurely.

Bartłomiej Dach · 2021-01-06 18:38:24 +01:00

09742998cd

Add guard when clearing samples

Bartłomiej Dach · 2020-12-20 15:42:24 +01:00

a31e8d137f

Merge branch 'master' into fix-sample-expire

Dean Herbert · 2020-12-04 13:49:08 +09:00

a0f92628ac

Merge branch 'master' into dho-remove-onparentreceived

Dean Herbert · 2020-12-04 11:04:56 +09:00

5ded4b9faa

Remove OnParentReceived()

smoogipoo · 2020-12-03 20:08:42 +09:00

0bdf99b97a

Change order of OnParentReceived()

smoogipoo · 2020-12-03 20:06:26 +09:00

73e99718bc

Fix DHO expires while hit sound is playing

ekrctb · 2020-12-03 12:32:49 +09:00

6c46046c24

Merge branch 'master' into hit-sample-pooling

Dean Herbert · 2020-11-30 22:25:28 +09:00

51741c4791

Merge branch 'master' into hit-sample-pooling

smoogipoo · 2020-11-30 18:31:58 +09:00

4bbeb9ebd4

Merge branch 'master' into improve-dho-time-offsets

smoogipoo · 2020-11-30 18:01:48 +09:00

8f48389f89

Merge branch 'master' into fruit-bindables

Dan Balasescu · 2020-11-30 16:48:22 +09:00

11d1450c76

Remove unnecessary schedule logic from Apply's local updateState call

There were cases in the editor where rewinding of transforms would
leave the `DrawableHitObject` in a non-`IsPresent` state, resulting in
this scheduled logic never running.

This would in turn cause ghost hitobjects, which disappear under certain
circumstances.

Reproduction:

- Open editor to empty beatmap
- Place single hitcircle at current point in time
- Drag editor timeline backwards to seek before zero, and wait for
  return to zero
- Select hitcircle in playfield
- Drag hitcircle to right in timeline, triggering a start time change

Dean Herbert · 2020-11-27 16:32:05 +09:00

18bb0cb45b

Merge branch 'master' into improve-dho-time-offsets

Dean Herbert · 2020-11-27 15:03:56 +09:00

bcc197f9fe

Fix colour not updated when index changes

ekrctb · 2020-11-27 11:41:39 +09:00

e36bb7631d

Remove hitObject argument from OnApply and OnFree

ekrctb · 2020-11-27 10:13:05 +09:00

57454bbb1c