Henry Lin
3c37140426
Remove an unused local variable
2021-07-05 09:52:13 +08:00
Henry Lin
bfb603cfeb
Change the test for unimplemented mod to use a mock ruleset and mod
2021-07-05 09:51:24 +08:00
Dean Herbert
f510ef9153
Move previousContext assign within lock to make things look safer
...
Not an actual requirement, but no harm.
2021-07-05 10:49:56 +09:00
Dan Balasescu
b6542a835b
Merge pull request #13757 from peppy/fix-import-optimisation
...
Fix incorrect `base` call causing import optimisation to not work
2021-07-05 10:26:52 +09:00
Dan Balasescu
5f10edee39
Merge branch 'master' into playlist-empty-romanised
2021-07-05 10:20:33 +09:00
smoogipoo
cc877f88e2
Fix inspection (create a new ruleset every time)
2021-07-05 10:13:01 +09:00
Derrick Timmermans
216e52d6d0
Avoid using single letter variable names
2021-07-04 23:24:17 +02:00
Derrick Timmermans
1facdcf483
Apply changes to tests
2021-07-04 23:23:24 +02:00
Derrick Timmermans
6d2ffe3a94
Add basic tests
2021-07-04 22:51:35 +02:00
Derrick Timmermans
32b068fbdc
Fix typo causing nested windows to be ignored
2021-07-04 21:50:58 +02:00
Bartłomiej Dach
0fb16cb55f
Merge pull request #13746 from ekrctb/move-caught-object-vertical-offset
...
Move caught object stack vertical offset logic
2021-07-04 18:10:34 +02:00
Bartłomiej Dach
ff56a554f3
Merge branch 'master' into move-caught-object-vertical-offset
2021-07-04 17:26:24 +02:00
Bartłomiej Dach
f3cd0be230
Merge pull request #13765 from peppy/fix-initial-volume-display-when-zero
...
Fix volume metre not correctly showing volume when initially zero
2021-07-04 16:55:24 +02:00
PercyDan54
356f5dceef
Add more test case
2021-07-04 22:34:31 +08:00
Bartłomiej Dach
5e148b273e
Merge branch 'master' into fix-initial-volume-display-when-zero
2021-07-04 16:16:01 +02:00
Bartłomiej Dach
a7de3dd81c
Merge pull request #13766 from peppy/fix-zero-hit-score-submit
...
Don't attempt to submit score when nothing has been hit
2021-07-04 16:10:55 +02:00
PercyDan54
44d540eb53
Add test
2021-07-04 22:09:23 +08:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit
2021-07-04 15:31:38 +02:00
Bartłomiej Dach
d5fa972215
Merge pull request #13762 from peppy/remove-lazer-references
...
Remove some mentions of "lazer"
2021-07-04 15:01:56 +02:00
Bartłomiej Dach
19f02dc3d9
Ensure tests with no token have at least one hit
...
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
2021-07-04 14:34:52 +02:00
Bartłomiej Dach
3291f15dcc
Mention GetForWrite() as another alternative to Context accesses
2021-07-04 12:08:15 +02:00
Bartłomiej Dach
b89521314f
Mention alternatives to Context when not on update thread in xmldoc
2021-07-04 12:07:34 +02:00
Dean Herbert
3ec7dc3bb9
Update tests in line with thread safety check
2021-07-04 17:59:39 +09:00
Dean Herbert
2a74b1c539
Add test coverage of new scenarios
2021-07-04 17:27:02 +09:00
Dean Herbert
7a710ceffe
Check count as well (statistics can be populated with zero counts)
2021-07-04 16:41:09 +09:00
Dean Herbert
567e9f33a9
Fix thread safety of realm Refresh operation
...
Due to the lack of locking, there was a chance the the update thread
`context` was retrieved just before the `flushContexts` call, followed
by `.Refresh()` being run while the blocking behaviour was invoked.
This can be seen in test failures such as
https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests .
As an aside, I tried multiple different methods to avoid `lock()` on the
update thread but they felt flaky. The overhead of lock when there's no
contention is reportedly around 30-50ns, so likely not of concern. We
can address it at a later point if it becomes one.
2021-07-04 16:24:43 +09:00
Dean Herbert
ef82528309
Don't attempt to submit score when nothing has been hit
2021-07-04 15:16:18 +09:00
Dean Herbert
149a200f34
Fix volume metre not correctly showing volume when initially zero
...
Closes https://github.com/ppy/osu/issues/13761 .
2021-07-04 14:56:17 +09:00
Dean Herbert
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
ekrctb
623ba15919
Relax caught object stacking test
...
The stacking code currently uses an unseeded RNG and there is a non-zero chance the stack will be very flat (small Y position difference).
Technically, `RNG.NextSingle(0, 5)` can return `0`, but extremely unlikely that the all RNG calls return 0.
2021-07-04 10:23:49 +09:00
PercyDan54
12371f7424
Fix playlist item displays as empty string if no unicode title is present
2021-07-04 08:09:38 +08:00
Bartłomiej Dach
05c612f9a1
Merge branch 'master' into move-caught-object-vertical-offset
2021-07-03 18:22:08 +02:00
Bartłomiej Dach
8a23dfa6f5
Fix optimised import path buffering events without flush
2021-07-03 17:58:12 +02:00
Bartłomiej Dach
49090a0d1b
Merge pull request #7674 from LeNitrous/linkify-metadata
...
Linkify metadata in beatmap details and overlay
2021-07-03 16:43:53 +02:00
Bartłomiej Dach
fbe3b447e5
Merge branch 'master' into linkify-metadata
2021-07-03 15:51:08 +02:00
Bartłomiej Dach
6fb8ed4d07
Trim no longer used constant
2021-07-03 15:47:47 +02:00
Dean Herbert
0be75cc4ed
Fix incorrect base call causing import optimisation to not work
2021-07-03 22:35:46 +09:00
Bartłomiej Dach
7dae93ad66
Remove unused using directives
2021-07-03 15:23:26 +02:00
Bartłomiej Dach
16d08df5e2
Remove mention of direct from xmldoc
2021-07-03 15:22:03 +02:00
ekrctb
333caca386
Add test for catcher plate flipping configuration
2021-07-02 23:23:23 +09:00
ekrctb
83c80291d4
Don't flip catcher plate contents in legacy skin
2021-07-02 23:23:21 +09:00
ekrctb
fbba32647e
Decouple direction of catcher from its scale
2021-07-02 23:22:39 +09:00
Dan Balasescu
ace57a9ee9
Merge pull request #13727 from peppy/update-disclaimer
...
Update disclaimer
2021-07-02 21:08:43 +09:00
Dan Balasescu
5a7706edee
Merge pull request #13726 from nekodex/notch-tick-sfx
...
Add audio feedback for changing volume
2021-07-02 21:08:31 +09:00
Dean Herbert
6e31c781bb
Merge pull request #13382 from ribbanya/clamp-skin-scale
...
Fix skin elements flipping when scaled below zero
2021-07-02 20:50:47 +09:00
ekrctb
170513568b
Move caught object stack vertical offset logic
2021-07-02 20:43:47 +09:00
Dan Balasescu
4d85df6bbc
Merge branch 'master' into notch-tick-sfx
2021-07-02 20:38:30 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
...
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
Dean Herbert
8847915c6a
Update framework
2021-07-02 18:51:14 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
...
Submit scores on player exit
2021-07-02 18:25:26 +09:00
