Dan Balasescu
41cf261286
Merge pull request #12177 from peppy/fix-comment-parsing-regression
...
Don't strip comments from metadata during parsing
2021-03-25 15:02:10 +09:00
Dean Herbert
e0b12abcc1
Merge pull request #12173 from frenzibyte/osk-ignore-case
2021-03-25 14:58:09 +09:00
Dean Herbert
0324bfa857
Change checks back to Contains
2021-03-25 14:14:38 +09:00
Dean Herbert
4269cb7124
Extract majority of token retrieval code out of LoadComponentAsync for legibility
2021-03-25 13:48:41 +09:00
Dean Herbert
ff139c2056
Merge branch 'master' into solo-score-submission
2021-03-25 13:46:29 +09:00
Dean Herbert
4f8edcd336
Don't strip comments from metadata during parsin
2021-03-25 13:35:54 +09:00
Dean Herbert
e22650293d
Remove unnecessary second call to StripComments in skin parsing logic
2021-03-25 13:35:42 +09:00
Salman Ahmed
fc5719e445
Fix SkinManager not handling extensions casing comparsion properly
2021-03-24 21:31:53 +03:00
Dean Herbert
f95175983a
Make code more concise and move method to a more appropriate place
2021-03-24 13:37:37 +09:00
Dean Herbert
d55324585d
Change RoomSubmittingPlayer's request implementation to return null on RoomID missing, rather than silently succeeding
2021-03-24 13:23:23 +09:00
Dean Herbert
84b2f9a848
Make token private
2021-03-24 13:20:44 +09:00
Dean Herbert
a0c6c4da35
Rename and refactor token request process to be easier to understand
2021-03-24 13:17:29 +09:00
Dean Herbert
e372e355ef
Reorder overrides in SoloPlayer to better follow chronological request order
2021-03-24 13:12:51 +09:00
Dean Herbert
8bed7748d6
Rename token request method to avoid double Request terminology
2021-03-24 13:02:37 +09:00
Dean Herbert
a1c35677ef
Add more xmldoc
2021-03-24 13:02:17 +09:00
Owen Young
c8542d2434
Merge branch 'master' into default-fullscreen
2021-03-23 19:44:22 -05:00
Owen Young
437dadc85f
Changed comment on GetFrameworkConfigDefaults() to be more accurate
2021-03-23 19:37:55 -05:00
Owen Young
67a03ebc23
Fixed formatting issues to be in line with osu coding standards
2021-03-23 19:31:16 -05:00
Owen Young
fbb992fc7e
Added a comment to new method
2021-03-23 19:18:32 -05:00
Dean Herbert
e649a330a4
Implement SoloPlayer's request construction
2021-03-23 18:23:25 +09:00
Dean Herbert
242b847516
Add flow for allowing gameplay to continue even when an error occurs with token retrieval
2021-03-23 18:23:25 +09:00
Dean Herbert
3cd8bf2d7f
Move token request construction to LoadAsyncComplete to better allow DI usage
2021-03-23 18:20:55 +09:00
Dean Herbert
571124669d
Remove all references to "score submission" from Player
2021-03-23 18:20:55 +09:00
Dean Herbert
194b2d05d3
Update SoloPlayer to derive SubmittingPlayer
2021-03-23 18:20:55 +09:00
Dean Herbert
12f050264a
Further split out a player class which submits to "rooms"
2021-03-23 18:20:55 +09:00
Dean Herbert
7045fce555
Move score submission logic in general out to its own Player type
2021-03-23 18:20:55 +09:00
Dean Herbert
6cb14e91c9
Make Player abstract and introduce SoloPlayer
2021-03-23 18:18:49 +09:00
Dean Herbert
5267fb74c4
Add submission requests
2021-03-23 18:18:49 +09:00
Dean Herbert
aeff9bd853
Add return bool to HandleRequest to better trigger failures
2021-03-23 18:17:29 +09:00
Dean Herbert
ce452565f4
Avoid firing any kind of failures after success
2021-03-23 17:50:31 +09:00
Dean Herbert
f5ba746ae5
Fail all API requests sent to DummyAPIAccess
...
Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.
Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.
2021-03-23 17:37:45 +09:00
Dan Balasescu
17a28f4f65
Merge pull request #12136 from peppy/remove-skin-sample-workarounds
...
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-23 16:44:29 +09:00
Dan Balasescu
d758343a45
Merge pull request #12149 from peppy/fix-score-token-data-type
...
Fix APIScoreToken's data type not matching server side
2021-03-23 14:54:02 +09:00
Dean Herbert
1171214541
Update framework
2021-03-23 14:51:22 +09:00
Owen Young
254b0f5dc3
removed line (?) - tried doing testing to see if it launched in fullscreen (i.e., overriding the method ppy mentioned), but to no avail :(
2021-03-23 00:24:33 -05:00
Dean Herbert
9c690f9545
Fix second usage
2021-03-23 14:08:00 +09:00
Dean Herbert
58c60100b4
Fix APIScoreToken's data type not matching server side
2021-03-23 14:04:47 +09:00
Owen Young
d9e2c44a34
implemented GetFrameworkConfigDefaults for overriding framework default, removed previous code that added a new OsuSetting and modified settings layout.
2021-03-22 23:36:55 -05:00
Owen Young
9f788f5854
removed code from OsuGameBase for fullscreen.....OsuSetting still exists but cannot figure out a way to set it to a default and have it actually work
2021-03-22 22:52:16 -05:00
Joehu
16b3f22caf
Fix incorrect trash icon being used on deleted comments counter
2021-03-22 19:32:17 -07:00
Owen Young
bdcb9451f7
added code to OsuGameBase to default to fullscreen, but that might not be a good place to put it.
2021-03-22 20:17:05 -05:00
Owen Young
8ea7271d5c
moved windowmode code to LoadComplete (?)
2021-03-22 19:48:52 -05:00
Owen Young
fc632fd48a
Added WindowSetting setting to OsuSetting enum so that it can be set by default at startup. Modified LayoutSettings.cs so that when it is changed in the settings, it is written to the local settings as well.
2021-03-22 01:30:20 -05:00
Dean Herbert
073dba5330
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-22 14:05:37 +09:00
owen-young
f7bf23dbe9
first attempt at changing windowMode to be fullscreen on default
2021-03-21 21:50:19 -05:00
Joehu
9bc6cdf042
Fix singular format regression on forum post text
2021-03-21 11:19:07 -07:00
Joehu
e31d583a7f
Add comments count to user profile overlay
2021-03-21 11:16:59 -07:00
Bartłomiej Dach
a16c0641b2
Revert EF Core to version 2.2
...
This reverts commit f3faad74d5712e7bc7bf
2021-03-21 11:05:15 +01:00
Bartłomiej Dach
86b569f5f7
Fix typo in identifier
2021-03-20 12:37:51 +01:00
Bartłomiej Dach
d28bed6ed2
Schedule adding transforms on tablet changes
...
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
