Salman Ahmed
|
f09c46238d
|
Merge branch 'master' into fix-channel-id-clash
|
2022-07-02 10:21:47 +03:00 |
|
Dean Herbert
|
b611540bf3
|
Merge pull request #18967 from frenzibyte/remove-ios-ci-workaround
Remove iOS build CI workaround
|
2022-07-02 13:19:10 +09:00 |
|
Dean Herbert
|
2cc9c579d4
|
Merge pull request #18969 from smoogipoo/fix-multiplayer-cross-pollution
Fix cross-pollution of server- and client-side multiplayer objects in tests
|
2022-07-02 13:18:35 +09:00 |
|
Dean Herbert
|
2352636bf2
|
Fix ID clash with announce and PM channels in chat overlay tests
Yet Another Issue.
https://github.com/ppy/osu/runs/7159306924?check_suite_focus=true
Not sure why announce channel was using a user id for its channel ID.
Bad copy paste?
|
2022-07-02 13:11:50 +09:00 |
|
Dean Herbert
|
426c53fe65
|
Fix potential null being sent to extension method which doesn't support it
|
2022-07-02 12:50:28 +09:00 |
|
Dan Balasescu
|
6644f9a72a
|
Fix completely incorrect test
|
2022-07-01 21:14:06 +09:00 |
|
Dan Balasescu
|
3b1842a2c2
|
Merge pull request #18835 from peppy/beatmap-update-flow
Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow
|
2022-07-01 20:28:04 +09:00 |
|
Dan Balasescu
|
93c68e4329
|
More test hardening around ClientAPIRoom usages
|
2022-07-01 19:49:27 +09:00 |
|
Dean Herbert
|
0cf58646f4
|
Merge pull request #18803 from Joehuu/fix-overlay-header-tab-item-localisable-string
Fix profile header tab items not localising
|
2022-07-01 19:37:57 +09:00 |
|
Dean Herbert
|
6baccad058
|
Merge pull request #18821 from ggliv/locked-room-filter
Add room access type filter to multiplayer lounge screen
|
2022-07-01 19:37:43 +09:00 |
|
Dan Balasescu
|
084a65578c
|
Always clone messages incoming from client-side
|
2022-07-01 19:36:37 +09:00 |
|
Dan Balasescu
|
37acec1952
|
Isolate client's LocalUser from TestMultiplayerClient
|
2022-07-01 19:23:41 +09:00 |
|
Dan Balasescu
|
b64c0d011c
|
Isolate client's Room from TestMultiplayerClient
|
2022-07-01 19:23:25 +09:00 |
|
Dan Balasescu
|
0be858b5bf
|
Rename APIRoom -> ClientAPIRoom, remove unused asserts
|
2022-07-01 19:21:59 +09:00 |
|
Dan Balasescu
|
1c2ffb3bc4
|
Fix server-side objects being sent to client
|
2022-07-01 19:21:53 +09:00 |
|
Dean Herbert
|
b829884861
|
Merge pull request #18963 from peppy/more-placeholder-suggestions
Add difficulty filter reset to song select "no results" suggestions
|
2022-07-01 17:55:23 +09:00 |
|
Dean Herbert
|
b460a52faf
|
Merge pull request #18966 from smoogipoo/fix-flaky-multiplayer-test
Fix test sometimes referencing old ModSelect object
|
2022-07-01 17:55:06 +09:00 |
|
Dean Herbert
|
cdc4caa8c4
|
Merge pull request #18945 from goodtrailer/separate-ball-followcircle
Separate slider ball and followcircle skinnables into default/legacy classes
|
2022-07-01 17:54:29 +09:00 |
|
Salman Ahmed
|
5880b824d0
|
Simplify description logic for overlay tab items
|
2022-07-01 11:30:51 +03:00 |
|
Dean Herbert
|
e213c1a4ef
|
Rename enum to explicitly mention it is a filter
|
2022-07-01 17:27:03 +09:00 |
|
Salman Ahmed
|
7f9ef6c23f
|
Merge branch 'master' into fix-overlay-header-tab-item-localisable-string
|
2022-07-01 11:27:00 +03:00 |
|
Salman Ahmed
|
0cfaef3605
|
Remove iOS build CI workaround
|
2022-07-01 11:21:52 +03:00 |
|
Dean Herbert
|
9911c6cbf0
|
Merge branch 'master' into locked-room-filter
|
2022-07-01 17:17:01 +09:00 |
|
Dean Herbert
|
0e1f08eff8
|
Fix regressing BeatmapRecommendations tests due to diffcalc running at
|
2022-07-01 17:10:15 +09:00 |
|
Dan Balasescu
|
ee963f8aa7
|
Merge pull request #18964 from peppy/fix-beatmap-leaderboard-null
Fix potential crash in `BeatmapLeaderboard` during rapid refresh operations
|
2022-07-01 17:01:57 +09:00 |
|
Salman Ahmed
|
3bca439c4f
|
Merge branch 'master' into more-placeholder-suggestions
|
2022-07-01 10:52:32 +03:00 |
|
Dan Balasescu
|
58c9bb031f
|
Apply PR reviews/fixes
|
2022-07-01 16:51:15 +09:00 |
|
Dan Balasescu
|
c22e77e481
|
Fix test sometimes referencing old ModSelect object
|
2022-07-01 16:46:27 +09:00 |
|
Dean Herbert
|
58e25a3a01
|
Fix potential crash in BeatmapLeaderboard during rapid refresh operations
|
2022-07-01 15:42:35 +09:00 |
|
Dan Balasescu
|
409224560f
|
Merge pull request #18874 from peppy/realm-fix-async-write-after-disposal
Ensure all async writes are completed before realm is disposed
|
2022-07-01 15:29:01 +09:00 |
|
Dean Herbert
|
3e0f4e7609
|
Add test coverage of difficulty filter reset
|
2022-07-01 15:28:55 +09:00 |
|
Dean Herbert
|
f3af612133
|
Suggest removing difficulty filter if no matches found at song select
|
2022-07-01 15:18:04 +09:00 |
|
Dan Balasescu
|
42d56aa640
|
Merge pull request #18958 from andy840119/remove-nullable-disable-in-the-extension
Remove nullable disable annotation in the extension namespace.
|
2022-07-01 13:52:12 +09:00 |
|
Dan Balasescu
|
e9e1537d8a
|
Merge pull request #18957 from andy840119/remove-nullable-disable-in-the-utils
Remove nullable disable annotation in the utils namespace.
|
2022-07-01 13:50:46 +09:00 |
|
andy840119
|
48047f2e58
|
Move the null check in the outside.
AddCursor() should not accept the null value.
|
2022-06-30 23:29:49 +08:00 |
|
andy840119
|
a5b1f1a688
|
mark the string as nullable.
|
2022-06-30 23:23:14 +08:00 |
|
andy840119
|
26de34da84
|
Remove the nullable disable annotation.
|
2022-06-30 23:20:40 +08:00 |
|
andy840119
|
d94f700ab1
|
Remove the nullable disable annotate in the test project.
|
2022-06-30 23:06:49 +08:00 |
|
andy840119
|
e50e0f7339
|
Remove the nullable disable annotate.
|
2022-06-30 23:05:09 +08:00 |
|
Dan Balasescu
|
205de4f234
|
Merge pull request #18955 from peppy/fix-multiplayer-finalise-selection-fails
Fix various multiplayer test failures due to not waiting for ongoing operation
|
2022-06-30 21:06:57 +09:00 |
|
Dean Herbert
|
447b496eff
|
Merge branch 'master' into realm-fix-async-write-after-disposal
|
2022-06-30 19:07:15 +09:00 |
|
Dean Herbert
|
84ecd524c8
|
Move wait steps upwards
|
2022-06-30 17:58:43 +09:00 |
|
Dean Herbert
|
7ab8335935
|
Fix various multiplayer test failures due to not waiting for ongoing operation
As seen at
https://teamcity.ppy.sh/buildConfiguration/Osu_Build/1138?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true.
|
2022-06-30 17:42:45 +09:00 |
|
Dan Balasescu
|
5a346edc63
|
Merge pull request #18951 from peppy/fix-realm-missing-transaction-rollback
Fix `PerformWrite` not rolling back transaction on exception
|
2022-06-30 17:17:56 +09:00 |
|
Dean Herbert
|
2a73210865
|
Add xmldoc and update parameter naming for MemoryCachingComponent.Invalidate flow
|
2022-06-30 17:17:06 +09:00 |
|
Dean Herbert
|
aab4dcefbd
|
Remove unnecessary invalidation handling flow
|
2022-06-30 17:13:26 +09:00 |
|
Dean Herbert
|
0698471627
|
Move BeatmapOnlineLookupQueue to inside BeatmapUpdater
|
2022-06-30 17:03:19 +09:00 |
|
Dan Balasescu
|
b0dc9f7c2d
|
Merge pull request #18953 from peppy/fix-realm-test-cleanup-too-early
Fix directory cleanup occurring too early during realm tests
|
2022-06-30 16:58:22 +09:00 |
|
Dean Herbert
|
ef42c6ecdf
|
Add missing xmldoc
|
2022-06-30 16:51:31 +09:00 |
|
Dean Herbert
|
e34c2f0aca
|
Remove unnecessary nullable-enable
|
2022-06-30 16:47:26 +09:00 |
|