Bartłomiej Dach
ee6dcbd808
Fix android build again
...
Another month, another freak android build failure.
From what I can tell, this time the build is broken because the second-
-to-last workaround applied to fix it, namely explicitly specifying
the version of workloads to install, stopped working, presumably because
github pushed a new .NET SDK version to runners, and microsoft didn't
actually put up a set of workload packages whose version matches the
.NET SDK version 1:1.
Thankfully, the fix to the *last* android build breakage (which caused
the workload installation to completely and irrecoverably fail), appears
to be rolling out this week, and *also* fix that same second-last issue,
so both workarounds of specifying the workload version and pinning the
image to `windows-2019` appear to no longer be required.
Note that the newest image version, 20250209.1.0, is still not fully
rolled out yet, thus rather than just fix all builds, this will fix like
20% of builds until the newest image is fully rolled out. But I guess
a 20% passing build is better than a 0% passing build, in a sense...?
2025-02-12 14:18:03 +01:00
Dan Balasescu
0612c0af9d
Merge pull request #31861 from minetoblend/chore/globalaction-enum-comment
...
Add comment warning about enum entry order in `GlobalAction`
2025-02-12 10:52:08 +09:00
Marvin Schürz
a8f07ae7b1
Add comment warning about enum entry order in GlobalAction
2025-02-11 18:04:23 +01:00
Bartłomiej Dach
46e8187d48
Merge pull request #22932 from peppy/collection-counts
...
Show count of beatmaps in collections in manage dialog
2025-02-11 15:43:22 +01:00
Dean Herbert
1203c85d30
Merge pull request #31682 from frenzibyte/mania-fix-judgements-on-scroll-up
...
Fix osu!mania judgement position not shifted on flipped scroll direction
2025-02-11 22:13:09 +09:00
Dan Balasescu
693ef8f538
Merge pull request #31846 from bdach/fix-missing-rank-on-results
...
Fix score position not being displayed in solo results screen
2025-02-11 21:55:35 +09:00
Dean Herbert
b9c4e23595
Fix potential bad realm access to collection name
2025-02-11 20:05:48 +09:00
Bartłomiej Dach
58d040112b
Merge pull request #31854 from peppy/editor-test-button-scale-disable
...
Disable scale animation when holding editor "test" button
2025-02-11 09:58:07 +01:00
Bartłomiej Dach
d8b3c28c2e
Use more neutral terminology to avoid contentious 'beatmap' term
2025-02-11 09:17:11 +01:00
Dean Herbert
b9ed217308
Add basic brighten animation instead
2025-02-11 17:13:34 +09:00
Bartłomiej Dach
884fa20b28
Remove completely unnecessary subscriptions per collection
2025-02-11 09:13:08 +01:00
Dean Herbert
1fa8d53232
Disable scale animation when holding editor "test" button
2025-02-11 17:11:20 +09:00
Dean Herbert
9bb108311f
Merge pull request #31848 from bdach/open-beatmap-in-browser-from-editor
...
Add menu items to open beatmap info & discussion pages in browser from editor
2025-02-11 16:55:02 +09:00
Bartłomiej Dach
18965fe0a2
Merge branch 'master' into collection-counts
2025-02-11 08:54:24 +01:00
Bartłomiej Dach
7db0a6f817
Update xmldoc
2025-02-11 16:14:47 +09:00
Bartłomiej Dach
daf0130b23
Reword copy to be less verbose
2025-02-11 08:06:12 +01:00
Dean Herbert
8dc616738c
Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators
...
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 21:49:06 +09:00
Dean Herbert
310700b4e7
Space out comment
2025-02-10 21:48:27 +09:00
Bartłomiej Dach
38e2f793ca
Add menu items to open beatmap info & discussion pages in browser from editor
2025-02-10 12:47:38 +01:00
Dean Herbert
6ff1a13b67
Merge pull request #31845 from frenzibyte/ios-threading-woes
...
Fix incorrect thread access in recent iOS orientation changes
2025-02-10 20:45:19 +09:00
Bartłomiej Dach
288851c606
Fix score position not being displayed in solo results screen
...
Closes https://github.com/ppy/osu/issues/31842 .
To be honest, I recall this working too, but I don't recall when it
might have broken, nor do I want to go look for the point of breakage
because it might be borderline impossible to find it now. So I'm just
fixing as if it was just a straight omission.
Opting for a client-side fix because server-side inclusion of the score
position for an entire leaderboard has been previously rejected as too
expensive:
https://github.com/ppy/osu-web/pull/11354#discussion_r1689217450
2025-02-10 12:17:52 +01:00
Salman Alshamrani
4b8890ef0c
Fix incorrect thread access in recent iOS orientation changes
2025-02-10 05:55:21 -05:00
Bartłomiej Dach
ad642b8425
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 11:17:17 +01:00
Bartłomiej Dach
3ba56e009e
Privatise a few members
2025-02-10 10:41:10 +01:00
Bartłomiej Dach
3294450dc9
Merge pull request #31841 from peppy/add-editor-percent-progress
...
Add percent progress display to editor footer
2025-02-10 09:54:05 +01:00
Bartłomiej Dach
0e1b5802a9
Merge pull request #31825 from peppy/fix-slider-ball-rotation-rewind
...
Fix slider ball rotation not being updated when rewinding to a slider
2025-02-10 09:42:19 +01:00
Salman Alshamrani
1e06c5cc4a
Flip the Y offset of skin judgement pieces on flipped scroll direction
2025-02-10 01:52:50 -05:00
Salman Alshamrani
a3cd62ec72
Flip mania judgement anchor on flipped scroll direction
2025-02-10 01:52:12 -05:00
Dean Herbert
274b422139
Add percent progress display to editor footer
2025-02-10 14:51:48 +09:00
Dean Herbert
43822458b3
Merge branch 'master' into fix-slider-ball-rotation-rewind
2025-02-09 22:37:50 +09:00
Dean Herbert
cf4c9e7f9e
Changed the Currently Playing Text when no track is selected ( #31835 )
...
Changed the currently playing text for when the track isnt selected/loaded
2025-02-09 21:39:58 +09:00
SebastianPeP
bcd4fcbeed
Changed the Currently Playing Text when no track is selected
...
Changed the currently playing text for when the track isnt selected/loaded
2025-02-09 01:29:22 -03:00
Dean Herbert
5ace8e911b
Fix failing test
2025-02-07 21:46:00 +09:00
Dean Herbert
fab5cfd275
Fix slider ball rotation not being updated when rewinding to a slider
2025-02-07 18:57:26 +09:00
Bartłomiej Dach
a068d88b84
Merge pull request #31823 from peppy/carousel-v2-optimisation-pass
...
Refactor grouping to be much more efficient
2025-02-07 10:44:53 +01:00
Bartłomiej Dach
ae179c8feb
Merge pull request #31824 from peppy/carousel-v2-group-click-transfer-keyboard
...
Always transfer keyboard selection on activation
2025-02-07 10:12:10 +01:00
Dean Herbert
cf4b501214
Merge pull request #31804 from bdach/bss/api-setup
...
Add API request & response structures for beatmap submission
2025-02-07 17:43:38 +09:00
Bartłomiej Dach
9af5ebbca9
Merge pull request #31822 from peppy/dont-submit-zero-scores
...
Don't attempt to submit zero scores
2025-02-07 09:42:38 +01:00
Dean Herbert
177ca4fb7c
Merge pull request #31799 from frenzibyte/carousel-v2-spacing
...
Support variable spacing between beatmap carousel panels
2025-02-07 17:41:28 +09:00
Dean Herbert
29b0b62ffa
Rename variables to something more sane
2025-02-07 17:39:38 +09:00
Dean Herbert
3da615481e
Change switch to simple conditional for now
2025-02-07 17:38:24 +09:00
Dean Herbert
41c8f64806
Simplify naming of endpoints
2025-02-07 17:33:32 +09:00
Dean Herbert
cef9d2eac5
Reduce number of beatmaps added in selection test
...
This is because with the new keyboard selection logic, adding too many
can cause the re-added selection to be off-screen in the headless test
setup.
2025-02-07 17:02:53 +09:00
Dean Herbert
c935c3154b
Always transfer keyboard selection on activation
2025-02-07 17:02:53 +09:00
Dean Herbert
9d979dc3f4
Refactor grouping to be much more efficient
2025-02-07 16:35:20 +09:00
Bartłomiej Dach
a49b1b61b4
Add test coverage for scores with zero total not submitting
2025-02-07 08:21:34 +01:00
Dean Herbert
50d880e2ae
Fix unnecessary BeatmapSet.Metadata lookups
2025-02-07 16:09:36 +09:00
Dean Herbert
75ef6f6a0e
Use random generation in carousel stress test
2025-02-07 16:09:35 +09:00
Dean Herbert
0235928fda
Merge pull request #31815 from smoogipoo/score-panel-ruleset
...
Add ruleset icon to expanded score panel
2025-02-07 16:04:24 +09:00
Dean Herbert
4d1167fdcc
Don't attempt to submit zero scores
2025-02-07 15:36:59 +09:00
