89 Commits

• Replace CatchHitObject.X usage to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:14 +09:00
  96f3e0dad8
• Combine DisplayRadius and Scale to DisplaySize
  ekrctb · 2020-12-10 20:43:01 +09:00
  2634c6b8d9
• Remove unneeded check of caught object removal

  The logic was public but now it is private
  so the condition is ensured by the caller

  ekrctb · 2020-12-09 10:50:35 +09:00
  a8e2f35b62
• Reword exception message
  ekrctb · 2020-12-09 10:38:11 +09:00
  b52e279702
• Remove unnecessary copy
  ekrctb · 2020-12-09 10:36:54 +09:00
  86445e7c23
• Rename caughtFruitContainer -> caughtObjectContainer
  ekrctb · 2020-12-09 10:35:36 +09:00
  c8b0934573
• more specific type droppedObjectContainer
  ekrctb · 2020-12-09 10:35:01 +09:00
  ccca7e0b25
• Revert rename error
  ekrctb · 2020-12-09 10:25:35 +09:00
  b80204642e
• Rename to CopyStateFrom, and add comment
  ekrctb · 2020-12-08 23:35:24 +09:00
  1212ffd24f
• Fix dropped objects not removed on revert result
  ekrctb · 2020-12-08 23:07:30 +09:00
  1f36bbecd1
• Pool caught objects and dropped objects
  ekrctb · 2020-12-08 22:38:10 +09:00
  749d5380ca
• Introduce IHasCatchObjectState implemented by DHO and CaughtObject
  ekrctb · 2020-12-08 21:29:26 +09:00
  a32dac00dd
• Make object on the catcher plate separate CaughtObject class
  ekrctb · 2020-12-08 21:11:40 +09:00
  c301223d8c
• Make catch hit lighting logic not dependent on caught object
  ekrctb · 2020-12-08 20:41:26 +09:00
  94a59ac3b2
• Compute object position in stack via a pure function
  ekrctb · 2020-12-08 20:36:59 +09:00
  56721a6fa9
• Remove hit explosion on revert result
  ekrctb · 2020-12-08 15:43:17 +09:00
  02571ec7ae
• Remove caught objects on revert result
  ekrctb · 2020-12-08 15:24:39 +09:00
  1a66d8f2bc
• Restore hyper dash state on revert judgement result
  ekrctb · 2020-12-08 15:21:47 +09:00
  100b365c98
• Restore catcher state on revert judgement result
  ekrctb · 2020-12-08 15:03:03 +09:00
  cb76a2d7b5
• Move catcher state changing logic to OnNewResult method
  ekrctb · 2020-12-08 14:28:30 +09:00
  0213f77b4b
• Move public methods upwards
  Dean Herbert · 2020-12-04 14:36:40 +09:00
  d3a17b65d5
• Tidy up code formatting and remove unnecessarily publicly exposed methods
  Dean Herbert · 2020-12-04 14:35:56 +09:00
  8988023407
• Invert if
  ekrctb · 2020-12-04 10:24:25 +09:00
  23af70dd32
• Use ApplyCustomUpdateState for dropping transformation

  We cannot just apply the transforms because DHO clears transforms when state is updated

  ekrctb · 2020-12-03 18:46:58 +09:00
  7e66714c2f
• Make DroppedObjectAnimation private
  ekrctb · 2020-12-03 18:46:58 +09:00
  be456f9c6b
• Move more logic to Catcher from CatcherArea
  ekrctb · 2020-12-03 16:44:36 +09:00
  5a5c956ced
• Refactor fruit dropping code

  - The repeated `Remove` call was quadratic complexity.
    Now it is linear time.

  ekrctb · 2020-12-03 16:44:36 +09:00
  2eb2c934cc
• Simplify the fruit stacking code

  It is now more clear that
  the expression of distance checking is probably unintended (a bug)

  ekrctb · 2020-12-03 16:44:36 +09:00
  873f2363c1
• Use more specific type for caught object
  ekrctb · 2020-12-03 16:44:36 +09:00
  8d32cca5d6
• Create children in the constructor
  ekrctb · 2020-12-03 16:44:36 +09:00
  e5c8e06c4b
• Apply suggested styling changes
  ekrctb · 2020-12-01 14:46:04 +09:00
  a16b265090
• Pool osu!catch hit explosion
  ekrctb · 2020-12-01 11:32:20 +09:00
  08cb84b325
• Move members to PalpableCatchHitObject
  ekrctb · 2020-11-24 19:57:37 +09:00
  ab7251d742
• Fix unsafe manipulation of parent's children from child
  Dean Herbert · 2020-10-19 17:41:21 +09:00
  4024b44a53
• Remove fades when changing trail colour across skins
  Bartłomiej Dach · 2020-08-24 15:57:41 +02:00
  60695bee8c
• Merge branch 'master' into hyperdash-full-catch-width
  Dean Herbert · 2020-08-22 19:55:45 +09:00
  b98d4d9cff
• Fix comment
  smoogipoo · 2020-08-21 13:14:50 +09:00
  62d833d63d
• Simplify condition
  smoogipoo · 2020-08-21 13:13:08 +09:00
  6ad7a3686b
• Merge branch 'master' into add-droplet-hypers
  smoogipoo · 2020-08-21 13:09:16 +09:00
  855b5ba4ed
• Use full catcher width for hyperdash calculation
  smoogipoo · 2020-08-21 02:21:16 +09:00
  738ff7ba21
• Prevent catcher from performing invalid catches
  Bartłomiej Dach · 2020-08-20 19:06:29 +02:00
  9546fbb64b
• Clobber in a gameplay test
  smoogipoo · 2020-08-21 02:01:29 +09:00
  f956c9fe37
• Merge pull request #9556 from gagahpangeran/toggle-hit-lighting-catch
  Dean Herbert · 2020-07-17 17:06:40 +09:00
  02678c04d5
• Remove returns xmldoc
  Dan Balasescu · 2020-07-16 15:55:35 +09:00
  ab477c3be4
• Expose via CreateProxiedContent method
  Dean Herbert · 2020-07-16 15:35:19 +09:00
  c42b315abb
• Fix osu!catch dropping fruit appearing above the plate instead of behind
  Dean Herbert · 2020-07-15 20:58:09 +09:00
  2624862e32
• change hitlighting bool to bindable
  Gagah Pangeran · 2020-07-14 10:52:34 +07:00
  3e2d184a91
• disable hit explotion when hit lighting off
  Gagah Pangeran · 2020-07-14 10:35:01 +07:00
  a25f4880d6
• Standardize osu!catch coordinate system

  There were two coordinate systems used:
  - 0..512 (used in osu!stable)
  - 0..1 (relative coordinate)
  
  This commit replaces the usage of
  the relative coordinate system to
  the coordinate system of 0..512.

  ekrctb · 2020-07-02 00:21:45 +09:00
  3278a1d7d8
• Centralise trail visibility state management
  Bartłomiej Dach · 2020-05-10 17:05:30 +02:00
  5bab53b04c