10643 Commits

• Add failing test case showing visual state desync
  Dean Herbert · 2026-01-22 14:59:41 +09:00
  6f146a5ce9
• Add failing test showing incorrect behaviour on random select with collapsed groups
  Dean Herbert · 2026-01-20 21:12:48 +09:00
  76f05a4837
• Update editor slider controls to new design (#36346)

  (partially) Closes: #36233
  Surpasses: #36244 
  
  This PR meant to be one of the last steps that finally make editor use
  the new forms. Initially it meant to only change one
  SliderWithTextBoxInput in "Effects section" in timing screen, however
  soon after it was obvious that there's many other places that still
  using it. This currently won't affect
  IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for
  example, since I think it needs more consideration.
  Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at
  all, as it's going to be replaced with modern FormSliderBar
  
  Comparison:
  |master|this PR|
  |:---:|:---:|
  |<img width="510" height="316"
  alt="532203751-eb965923-d3a8-441d-a7c8-5c364a6328ad"
  src="https://github.com/user-attachments/assets/268b45b8-e235-494f-91a5-d00db057dba8"
  />|<img width="540" height="321"
  alt="535466527-3a700a8b-bc3c-4610-998f-a4e55ee03eed"
  src="https://github.com/user-attachments/assets/20cd4b58-b0bd-49bc-8c48-7de5cf8556b3"
  />|
  |<img width="694" height="639"
  alt="534509844-f00e4da4-53c4-45e8-80ea-1be62da6c83b"
  src="https://github.com/user-attachments/assets/398c4484-a867-4df1-9de3-0940aa748a01"
  />|<img width="720" height="433" alt="изображение"
  src="https://github.com/user-attachments/assets/b6359443-a224-4a55-b171-07e8f013cf46"
  />|
  |<img width="715" height="353"
  alt="534509421-a6ac950f-16e8-4a16-bca6-1a781f82135f"
  src="https://github.com/user-attachments/assets/4854312b-772f-4b81-a800-89e58d4c715d"
  />|<img width="710" height="296" alt="изображение"
  src="https://github.com/user-attachments/assets/a7fed53e-e006-4285-92c9-bb84cb603f60"
  />|
  |<img width="717" height="374"
  alt="534509478-80222623-7766-481d-8682-088276d415ee"
  src="https://github.com/user-attachments/assets/8143b6dc-4599-45d5-bd3b-f059caf3d93d"
  />|<img width="718" height="328" alt="изображение"
  src="https://github.com/user-attachments/assets/bffa04de-983c-45ae-a1ec-373701ea0e49"
  />|
  |<img width="702" height="446"
  alt="534509935-58954060-7ac1-4392-8754-a58f909e86aa"
  src="https://github.com/user-attachments/assets/2bb67a2d-3f57-42a1-96ce-b30b4891e1a4"
  />|<img width="722" height="386" alt="изображение"
  src="https://github.com/user-attachments/assets/01b7fff4-7f31-4aac-90c9-353b15f4964e"
  />|

  De4n · 2026-01-16 20:08:52 +09:00
  e05b6f44b9
• Fix double-clicking form slider bar not propagating default to other bindables when TransferValueOnCommit is true (#36354)

  - Addresses https://github.com/ppy/osu/pull/36346#discussion_r2692322683
  
  The inner slider bar binds its `Current` to
  `currentNumberInstantaneous`:
  
  
  https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L225-L236
  
  But the current bindable of the form component doesn't update because of
  this.
  
  
  https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L285-L293
  
  Fixed it by just moving the `ResetToDefault` action up another level.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Joseph Madamba · 2026-01-16 19:48:36 +09:00
  a8ada50549
• Fix toasts showing "no key bound" for operations which can't have keys bound

  Supersedes and closes https://github.com/ppy/osu/pull/35781.
  Closes https://github.com/ppy/osu/issues/36294.

  Dean Herbert · 2026-01-15 17:52:30 +09:00
  b4ba327c1c
• Merge pull request #36324 from frenzibyte/better-form-button

  Update form button UI/UX and support text wrapping

  Dean Herbert · 2026-01-14 19:47:50 +09:00
  91718447db
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2026-01-13 17:04:42 +09:00
  363b7cf3cb
• Remove unused button
  Dean Herbert · 2026-01-13 16:57:50 +09:00
  eeb4680795
• Improve form dropdown UX (#36325)

  Addresses concerns in
  https://github.com/ppy/osu/pull/36193#issuecomment-3728177951 (excluding
  the last part, that is too involved and I can't imagine any workaround
  for it due to how strict the `Dropdown` structure is). Also adds
  truncation/padding to header label and search bar.
  
  Preview:
  
  
  https://github.com/user-attachments/assets/8885cb90-44dc-42ee-af21-cb33f7723e63

  Salman Alshamrani · 2026-01-13 16:20:03 +09:00
  f892d5fbaa
• Add visual test
  Salman Alshamrani · 2026-01-12 23:38:17 -05:00
  df1304af9e
• Add star rating text gradient (#36292)

  Implements https://github.com/ppy/osu-web/pull/12363
  
  There's one less colour in the spectrum than in the [web
  code](https://github.com/ppy/osu-web/pull/12363/changes#diff-a9bdefd7233ca98f7f89cd76213aba5d869ae0424c8e79d1e322abd3e43462fbR31)
  because the spectrum was actually defined incorrectly and has [one less
  domain entry than it
  should](https://github.com/ppy/osu-web/pull/12363/changes#diff-a9bdefd7233ca98f7f89cd76213aba5d869ae0424c8e79d1e322abd3e43462fbR29).
  I've chose to not add it because of consistency with the web and because
  it looked pretty ugly (it was pretty much unreadable)
  
  <img width="1361" height="814" alt="image"
  src="https://github.com/user-attachments/assets/5f9d7a93-3e28-4b8c-952c-0abd6f8c2cc3"
  />
  <img width="805" height="647" alt="image"
  src="https://github.com/user-attachments/assets/b060cba7-3beb-4bb5-8d50-6210e8417715"
  />

  StanR · 2026-01-11 00:30:48 +09:00
  3e7f0f4c61
• Fix failing test case due to mod overlay being moved to game level
  Dean Herbert · 2026-01-10 01:44:07 +09:00
  dda1c7f75b
• Merge pull request #36242 from frenzibyte/form-controls-text-wrapping

  Support text wrapping in form controls

  Dean Herbert · 2026-01-09 18:06:24 +09:00
  7652c91a53
• Add test covering desired behaviour of dismissing beatmap set scope
  Bartłomiej Dach · 2026-01-07 11:08:51 +01:00
  7f99650a04
• Merge pull request #35931 from smoogipoo/mp-require-hold-to-exit

  Require hold-to-exit during multiplayer load

  Bartłomiej Dach · 2026-01-07 07:10:04 +01:00
  8c8ba2f3bc
• Remove HoldForMenuButton player dependency
  Dan Balasescu · 2026-01-06 17:20:28 +09:00
  86220622fb
• Add test cases requiring text wrapping
  Salman Alshamrani · 2026-01-05 16:13:37 -05:00
  4f2dfccb0f
• Merge pull request #36232 from peppy/fix-editor-undo-crash

  Fix editor crashing on undoing after hit object placement

  Bartłomiej Dach · 2026-01-05 10:28:46 +01:00
  43e5aec16e
• Add test coverage of editor placement scenarios
  Dean Herbert · 2026-01-05 15:24:15 +09:00
  25dab7258c
• Add test
  Dan Balasescu · 2026-01-05 15:21:49 +09:00
  88f80799c3
• Fix play button starting wrong beatmap before selection loads (#36104)

  * Fix play button starting wrong beatmap before selection loads
  
  When clicking the osu! cookie (play button) before a newly selected beatmap finishes loading, the previous beatmap would be played instead of the currently selected one. 
  
  This was caused by the cookie reading from the global beatmap state which is debounced by 150ms, while the Enter key correctly used the carousel's current selection.
  
  The fix makes the cookie use the same beatmap source as Enter - the carousel's current selection - which is always up-to-date regardless of debounce timing.
  
  Closes #36074
  
  * Use ensureGlobalBeatmapValid() for logo and Enter key actions
  
  * Add test for beatmap selection timing bug
  
  Tests the fix for issue #36074 where clicking the play button immediately after selecting a different difficulty would start the wrong beatmap due to the 150ms selection debounce.

  Jul · 2026-01-05 14:54:25 +09:00
  ff820f730e
• Revert no longer necessary change

  Additionally to fix the options button, I could either cache the
  interface in PlaylistsSongSelectV2 or make the interface cache itself. I
  went with the latter option.

  Dan Balasescu · 2026-01-05 14:10:26 +09:00
  ebf9c19ad3
• Merge pull request #36160 from smoogipoo/qp-beatmap-attributes

  Add beatmap attributes to quick play panels

  Dean Herbert · 2026-01-02 23:05:02 +09:00
  e0c4592dc7
• Attempt to fix flaky test
  Dean Herbert · 2026-01-01 19:41:14 +09:00
  e539660b14
• Fix/remove tests broken by screen behaviour change
  Dean Herbert · 2026-01-01 00:29:04 +09:00
  0a2fc12061
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2026-01-01 00:29:02 +09:00
  e1ce1e3188
• Add test case
  Bartłomiej Dach · 2025-12-30 12:40:06 +01:00
  ebb898f67c
• Adjust metrics
  Dan Balasescu · 2025-12-29 17:29:21 +09:00
  10ebb5286f
• Add top tag and difficulty attributes
  Dan Balasescu · 2025-12-29 16:20:14 +09:00
  69fee16eee
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2025-12-25 20:26:35 +09:00
  36de88f399
• Merge pull request #36103 from bdach/form-sample-set

  Implement form control for adding/removing custom samples in editor

  Dean Herbert · 2025-12-25 15:11:33 +09:00
  0bcb3c5839
• Fix tests not having colour providers
  Salman Alshamrani · 2025-12-23 05:58:57 -05:00
  a3a5b2ca92
• Use switch button for form checkbox controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  339aad42a7
• Add extra form controls in test scene
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c6a8d9a150
• Merge pull request #36047 from bdach/reveal-other-difficulties-thing

  Add ability to view other beatmaps in set when difficulties are split apart

  Dean Herbert · 2025-12-23 19:43:47 +09:00
  0999e3f048
• Merge branch 'master' into form-slider-bar-disabled
  Dean Herbert · 2025-12-22 23:44:33 +09:00
  dbcc7cc09d
• Merge pull request #36055 from frenzibyte/new-settings/item

  Implement new settings item component

  Dean Herbert · 2025-12-22 22:55:53 +09:00
  d9dad4c3a8
• Implement form control for adding/removing custom samples in editor

  The test scene doesn't exercise the custom sample playback, but I hope I
  can be forgiven for this as setting up a custom editor beatmap just for
  this to work is rather cumbersome.

  Bartłomiej Dach · 2025-12-22 13:48:31 +01:00
  9d07ad2761
• Add another failing test
  Bartłomiej Dach · 2025-12-22 10:04:18 +01:00
  daaea093f0
• Add failing test
  Bartłomiej Dach · 2025-12-19 12:17:06 +01:00
  32454caaa9
• Rename property to have consistent name
  Salman Alshamrani · 2025-12-18 20:01:36 -05:00
  a82d0c3b51
• Extend classic default test coverage
  Salman Alshamrani · 2025-12-18 06:17:48 -05:00
  61874e59e0
• Add test coverage
  Salman Alshamrani · 2025-12-18 05:19:54 -05:00
  7a32e0eebf
• Add ability to view other beatmaps in set when difficulties are split apart

  First part of https://github.com/ppy/osu/issues/36039, see also
  https://github.com/ppy/osu/discussions/33784.
  
  The goal is to add this back to the set panels too, but that one is more
  complicated than this if you can believe it (because it requires being
  able to tell which other difficulties of the set are filtered out to
  fade them out). I also foresee the display logic to vary significantly
  there.
  
  Of note, for this to work in beatmaps-split-apart mode, this requires a
  change of behaviour in the filtering logic. Old song select when given a
  "selected beatmap set" would *include* that in results regardless of the
  filter, but that doesn't work for beatmaps-split-apart for reasons that
  are hopefully obvious, so this changes the behaviour to *entirely
  bypass* the filter and just show the set. Unsure how angry will people
  be with that.
  
  Also of note, when in the scoped mode, altering any filter criteria will
  dismiss the scope.

  Bartłomiej Dach · 2025-12-17 12:28:20 +01:00
  5bf6a75b50
• Fix inspections
  Dean Herbert · 2025-12-17 19:32:07 +09:00
  5f9639fc3f
• Merge branch 'master' into custom-sample-set-selection
  Dean Herbert · 2025-12-17 19:30:24 +09:00
  61bf68f336
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Merge branch 'master' into legacy-pp-counter
  Dean Herbert · 2025-12-15 16:55:51 +09:00
  89d8b402af
• Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content (#35940)

  * Add failing test
  
  * Fix dragging volume meter to adjust volume closing overlays if mouse is released outside of overlay content
  
  Fixes https://osu.ppy.sh/community/forums/topics/2159553.

  Bartłomiej Dach · 2025-12-11 13:47:08 +09:00
  095a67c24e
• Fix skin editor sometimes dropping anchor/origin specification on paste (#35957)

  * Add failing test for copy->paste not being idempotent
  
  * Ensure all elements on default skins use fixed anchors
  
  `UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with
  manual anchor / origin specs on some drawables, this would get default
  skins into impossible states wherein a drawable would use "closest
  anchor" but also explicitly specify anchor / origin that aren't closest,
  which horribly fails on attempting to copy and paste.
  
  Frankly shocked this has gone unnoticed for this long, and I regret not
  vetoing this "feature" more every time I see its tentacles spread to
  produce breakage of levels yet unseen.
  
  Does this commit contain major levels of suck? For sure. Do I have any
  better ideas that wouldn't consist of a multi-day rewrite or deletion of
  this "feature"? No.
  
  * Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor
  
  Self-explanatory. Should close https://github.com/ppy/osu/issues/29111
  along with previous commit.

  Bartłomiej Dach · 2025-12-11 13:40:48 +09:00
  c4f7dee82b