74719 Commits

This Branch

This Branch

All Branches

• Fix tests

  - Move them to the correct class. They were exercising filter matching,
    not parsing.
  - Remove a bunch of unreadable tuple stuff that was mostly obfuscating
    the readability without actually improving test coverage.
  - Make tests fail everywhere rather than on CI only. They were failing
    because they were written in a way that was implicitly dependent on
    the local computer's timezone.

  Bartłomiej Dach · 2025-08-13 11:35:05 +02:00
  e31b2c08fd
• Fix code quality

  Fix code quality 2
  
  code quality fix 3
  
  Fix code quality 4
  
  Add empty line

  Valerus9 · 2025-08-13 14:59:29 +09:00
  bd90ef1bf4
• Add tests coverage for filters with not equal
  Valerus9 · 2025-08-13 14:59:20 +09:00
  997b8a0bba
• Added FilterMatchTest for InvertRange
  Valerus9 · 2025-08-13 14:59:20 +09:00
  02f835dbc3
• Simplify logic of IsInRange()
  Valerus9 · 2025-08-13 14:59:20 +09:00
  cc970ffd80
• Rename ExludeIfInRange to InvertRange, add xmldox to InvertRange
  Valerus9 · 2025-08-13 14:59:19 +09:00
  3a78cfc627
• Add test coverage
  Valerus9 · 2025-08-13 14:59:19 +09:00
  1a18aac515
• Implement not equal operator

  Added blank lines

  Valerus9 · 2025-08-13 14:59:19 +09:00
  3162478172
• Merge pull request #34553 from Esnos33/change-localisation-step-replay

  Fix inconsistent localisation string in replay key bindings

  Bartłomiej Dach · 2025-08-07 13:36:25 +02:00
  2025.808.0-tachyon 38ea95fe8a
• Remove unused .res file

  This always confuses me since stable used this for the main storage
  location of the icon. We don't reference this anywhere so it's just
  weird to still keep this around.
  
  Of note, this has a lazer icon from many years ago still inside it.

  Dean Herbert · 2025-08-07 19:23:16 +09:00
  f148f86351
• Merge pull request #34551 from peppy/update-16-ico

  Update 16x16 icon file with more modern design

  Bartłomiej Dach · 2025-08-07 12:17:05 +02:00
  bce74eed89
• Change localisation string: use 'step' instead of 'seek' for replay forward
  Oskar Werner · 2025-08-07 12:15:48 +02:00
  c73f5b8914
• Merge pull request #34539 from frenzibyte/my-maps-grouping

  Implement "my maps" grouping mode

  Dean Herbert · 2025-08-07 19:14:05 +09:00
  81db58d9a2
• Merge pull request #34550 from bdach/sqlite-adventures

  Fix various issues around metadata cache handling

  Dean Herbert · 2025-08-07 19:11:01 +09:00
  82ae1065aa
• Merge pull request #34549 from peppy/fix-velopack-update-fail

  Fix potential update failures due to not handling required velopack callbacks

  Bartłomiej Dach · 2025-08-07 11:59:13 +02:00
  f98fc343c2
• Update 16x16 icon file with more modern design

  As provided in https://github.com/ppy/osu/discussions/34435.

  Dean Herbert · 2025-08-07 18:43:16 +09:00
  c886c08a6f
• Provide BeatmapItemsCount in all filters to ensure we always use correct value
  Dean Herbert · 2025-08-07 18:15:52 +09:00
  eed88d7c9b
• Remove outdated comment
  Dean Herbert · 2025-08-07 18:15:37 +09:00
  dc4fb86e8b
• Use bindable rather than API at each point of usage
  Dean Herbert · 2025-08-07 18:11:17 +09:00
  bff07010d1
• Update test coverage
  Salman Alshamrani · 2025-08-07 18:11:17 +09:00
  eebff890a2
• Fix matched beatmap count not accounting grouping filter discards
  Salman Alshamrani · 2025-08-07 18:11:17 +09:00
  0e720f6ae7
• Fix metadata cache version queries failing hard if the image is corrupted

  This was not fatal but with this change it should recover in a slightly
  better way.
  
  Also incidentally fixes the cache refetch potentially being attempted
  twice by each of the two background population tasks that use it.

  Bartłomiej Dach · 2025-08-07 11:10:02 +02:00
  dac643121a
• Fix potential update failures due to not handling required velopack callbacks
  Dean Herbert · 2025-08-07 17:42:06 +09:00
  afcaed673f
• Fix metadata cache refetches failing on windows

  Reported at
  https://discord.com/channels/188630481301012481/1097318920991559880/1402910684320108574
  among others.
  
  Only really visible on windows for reasons outlined in inline comment.

  Bartłomiej Dach · 2025-08-07 10:24:15 +02:00
  7da94c4010
• Discard beatmaps not owned by local user
  Salman Alshamrani · 2025-08-07 09:11:13 +03:00
  5c9f2a0402
• Only fall back to username when ID is not available
  Salman Alshamrani · 2025-08-07 09:03:59 +03:00
  3484d2357b
• Merge pull request #34540 from Hiviexd/verify/check-inconsistent-settings

  Add verify check for inconsistent settings

  Dean Herbert · 2025-08-07 14:49:45 +09:00
  76b09eb677
• Merge branch 'master' into verify/check-inconsistent-settings
  Bartłomiej Dach · 2025-08-07 06:57:32 +02:00
  39ad5ecd79
• Fix looping samples again
  Bartłomiej Dach · 2025-08-06 19:24:12 +02:00
  2025.807.0-tachyon dbf60763eb
• Use strongly-typed equality comparer rather than using object equality comparer

  `EqualityComparer<object>.Default()` will be slow, will fall back to
  `object.Equals()` which may do the right thing, the wrong thing, or be
  useless due to using reference equality semantics.
  
  In practice in this call site it likely doesn't matter anyway but I'd
  rather be future-proof than not.

  Bartłomiej Dach · 2025-08-06 18:26:41 +02:00
  c2a85032a6
• Merge pull request #34526 from frenzibyte/editor-weird-selection

  Fix grid placement completely breaking selection in certain scenarios

  Bartłomiej Dach · 2025-08-06 18:00:55 +02:00
  abe07bc460
• update widescreen support tests
  Hivie · 2025-08-06 15:05:29 +01:00
  5d555bc44b
• only check widescreen bool when storyboard is present

  matches MV

  Hivie · 2025-08-06 14:57:42 +01:00
  92fda5c2b9
• move storyboard presence check to shared utils
  Hivie · 2025-08-06 14:55:20 +01:00
  9b53d340af
• Update framework
  Dean Herbert · 2025-08-06 22:17:03 +09:00
  26bc99ca06
• Reword comment to be more coherent
  Bartłomiej Dach · 2025-08-06 15:04:29 +02:00
  f1f7784272
• refactor comparison and use actual object type for field selectors
  Hivie · 2025-08-06 14:04:18 +01:00
  7f886f7534
• Merge pull request #34541 from Hiviexd/verify/small-timing-metadata-checks-changes

  Small adjustments to timing and metadata verify checks

  Bartłomiej Dach · 2025-08-06 14:17:36 +02:00
  ccf22123c4
• fix tests
  Hivie · 2025-08-06 13:06:59 +01:00
  899719e874
• mark timing checks as set-level
  Hivie · 2025-08-06 11:42:57 +01:00
  af8b133019
• use current beatmap as reference

  to be consistent with other checks that follow similar logic

  Hivie · 2025-08-06 11:42:40 +01:00
  f2953652a1
• add tests
  Hivie · 2025-08-06 11:29:31 +01:00
  53b9c2167d
• add check for inconsistent settings
  Hivie · 2025-08-06 11:29:22 +01:00
  3cd6734c10
• Add test coverage
  Salman Alshamrani · 2025-08-06 13:08:42 +03:00
  7927006608
• Add "My Maps" grouping mode
  Salman Alshamrani · 2025-08-06 13:08:42 +03:00
  e0706dd700
• Merge pull request #34532 from Hiviexd/verify/check-genre-language

  Add verify check for missing genre/language tags

  Bartłomiej Dach · 2025-08-06 11:34:42 +02:00
  93a29040bf
• Merge pull request #34538 from smoogipoo/always-msgpack

  Always use MessagePack to talk to spectator server

  Dean Herbert · 2025-08-06 17:58:32 +09:00
  a464441d04
• use already-existing framework extension method
  Hivie · 2025-08-06 08:42:19 +01:00
  2127b6ca4e
• cleaner definition

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Hivie · 2025-08-06 08:40:34 +01:00
  82f619a58a
• Always use MessagePack to talk to spectator server
  Dan Balasescu · 2025-08-06 16:36:33 +09:00
  d0e9fda874