John
e2633ae993
Removed unnecessary [Resolved] attribute (thanks bdach)
...
Moved accent color assignment from OnUpdate to ApplyCustomUpdateState. In order to get this to work, a flag needed to be added to DrawableHitObject.cs to disable combo color updates also being applied.
2023-05-16 21:08:56 -07:00
John
7a907f7207
Code quality improvements (thanks to ItsShamed): Removed #nullable disable, fixed incorrect LocalisableString, removed incorrect dependency injection for OsuColour, fixed nullable dependency for IBeatmap
...
Removed unnecessary usage of "this." caught by the CI code quality check
2023-05-12 22:13:39 -07:00
John
24f07633f3
Formatting fixes
2023-05-12 19:43:28 -07:00
John
e5884016ab
Initial commit for the snap colour mod. Implements basic functionality.
2023-05-12 19:07:25 -07:00
Dean Herbert
3e8711ed96
Merge pull request #23489 from apollo-dw/fix-strict-svs
...
Copy slider velocities to strict tracking sliders
2023-05-12 12:55:00 +09:00
js1086
3bce7ac589
Copy SliderVelocity to strict tracking sliders
2023-05-11 19:07:22 +01:00
Dean Herbert
78d2f3fe44
Merge pull request #23475 from ItsShamed/qol/import-keyword
...
Add more keywords for setup wizard
2023-05-11 23:25:47 +09:00
tsrk
2d45d602a5
feat(settings): more keyword for first run setup
2023-05-11 15:03:42 +01:00
tsrk
c1a85658b7
feat(settings): add "import" as keywords for first run setup
2023-05-11 14:58:17 +01:00
Dean Herbert
bb9adb01c6
Merge pull request #23455 from peppy/update-everything
...
Update resources and framework
2023-05-10 16:57:54 +09:00
Dean Herbert
3fc19553b4
Update resources
2023-05-10 15:19:46 +09:00
Dean Herbert
4aa241daea
Update framework
2023-05-10 15:19:43 +09:00
Dean Herbert
2097141fa5
Merge pull request #23453 from bdach/appease-the-ios-monstrosity
...
Fix iOS build workflow failing
2023-05-10 10:08:05 +09:00
Dean Herbert
c809f01db9
Merge pull request #23416 from bdach/automated-mod-definition-updates
...
Add workflow for automated osu-web mod definition updates
2023-05-10 10:03:01 +09:00
Bartłomiej Dach
6604b9f1e7
Merge pull request #23434 from peppy/tick-rate-adjust
...
Add the ability to change the beatmap tick rate in the editor
2023-05-09 22:12:23 +02:00
Bartłomiej Dach
745341ca6b
Fix iOS build workflow failing
...
A new version of `Microsoft.iOS.Sdk` was released on
2023-05-09T17:28:41.7300000. This version requires Xcode 14.3, which is
not currently available on `macos-latest` runners (which currently alias
to `macos-12`).
To fix, migrate to `macos-13`, which is currently in beta, and
explicitly use Xcode 14.3 (because even on the `macos-13` image, Xcode
14.3 is not yet the default).
2023-05-09 21:59:24 +02:00
Bartłomiej Dach
f56105d1c7
Merge branch 'master' into tick-rate-adjust
2023-05-09 21:19:48 +02:00
Bartłomiej Dach
e85afeb3f7
Merge pull request #23431 from peppy/base-s-v
...
Add beatmap-level velocity setting to difficulty settings
2023-05-09 21:16:58 +02:00
Dean Herbert
bdf8a78b42
Add the ability to adjust the beatmap tick rate in the editor
2023-05-09 20:53:20 +09:00
Dean Herbert
ca5e8b290f
Add clamping to SliderMultiplier and SliderTickRate at parsing time
2023-05-09 20:53:20 +09:00
Dean Herbert
d10dd6d5ae
Merge branch 'master' into base-s-v
2023-05-09 20:52:11 +09:00
Dean Herbert
2085833a84
Fix missing delegate unsubscribe
2023-05-09 17:08:03 +09:00
Dean Herbert
944da06c10
Rename slider multiplier variable back for now
2023-05-09 16:58:19 +09:00
Bartłomiej Dach
efc4df95eb
Merge pull request #23429 from peppy/fix-incorrect-mania-description-keys
...
Fix incorrect special style description text
2023-05-09 07:04:57 +02:00
Bartłomiej Dach
0a47ffcbdd
Match generally used casing
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-05-09 07:03:13 +02:00
Bartłomiej Dach
1d162d1d15
Merge pull request #23440 from peppy/drawable-hit-object-sync-animations
...
Fix hit object animations not being played back in sync
2023-05-08 23:44:37 +02:00
Bartłomiej Dach
9a65b364c0
Merge pull request #23439 from peppy/fix-mania-head-note-animation
...
Fix osu!mania head note incorrectly scrolling off screen on late releases
2023-05-08 23:43:54 +02:00
Bartłomiej Dach
1ff1730948
Remove no-longer-correct remark
2023-05-08 22:35:41 +02:00
Bartłomiej Dach
3f45948664
Merge branch 'master' into fix-mania-head-note-animation
2023-05-08 22:23:01 +02:00
Bartłomiej Dach
30ce86a582
Merge pull request #23437 from peppy/fix-hold-note-input-test
...
Fix `TestSceneHoldNoteInput` not displaying correctly
2023-05-08 22:22:33 +02:00
Bartłomiej Dach
2177dbf42a
Merge pull request #23436 from peppy/fix-wiki-error-return-to-main
...
Fix "Return to main page" link not working on wiki after error
2023-05-08 21:56:29 +02:00
Bartłomiej Dach
2687eac34d
Merge pull request #22866 from peppy/mania-fix-hold-note-rewind
...
Fix osu!mania hold note animations not correctly re-applying after rewind
2023-05-08 21:29:55 +02:00
Dean Herbert
64498e95a4
Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations
2023-05-08 18:56:29 +09:00
Dean Herbert
e69152fd14
Merge pull request #23438 from smoogipoo/remove-dynamic-compile-attribute
...
Remove usages of `[ExcludeFromDynamicCompile]`
2023-05-08 18:15:00 +09:00
Dean Herbert
27c10cbdb7
Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment
2023-05-08 18:14:07 +09:00
Dan Balasescu
d2380bd840
Remove usages of [ExcludeFromDynamicCompile]
2023-05-08 18:12:56 +09:00
Dean Herbert
bcabe96714
Add extra tests of hold note input in more standard scenarios
2023-05-08 17:49:41 +09:00
Dean Herbert
d6ce56e6b1
Fix GetMostCommonBeatLength returning zero in case of not timing points
2023-05-08 17:09:08 +09:00
Dean Herbert
1b7dd32eb1
Apply nullability in related classes and remove unused variable
2023-05-08 17:09:08 +09:00
Dean Herbert
814f0b3fed
Add back early return in OnReleased for safety
2023-05-08 15:43:11 +09:00
Dean Herbert
693427918b
Merge branch 'master' into mania-fix-hold-note-rewind
2023-05-08 15:42:45 +09:00
Dean Herbert
9160711470
Change "Show main page" test steps to actually load the main page
2023-05-08 15:32:00 +09:00
Dean Herbert
715b735131
Fix "Return to main page" link not working on wiki after error
2023-05-08 15:29:05 +09:00
Dean Herbert
f002038137
Add test coverage of failing wiki return to page scenario
2023-05-08 15:29:05 +09:00
Dean Herbert
8c44d528e9
Use min/max values from stable
2023-05-08 13:52:16 +09:00
Dean Herbert
a6cb1f90e4
Change difficulty popover inspector display (yet again)
...
I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.
2023-05-08 13:43:23 +09:00
Dean Herbert
a91edd68d9
Show post-multiplied velocity in main hit object inspector
2023-05-08 13:42:25 +09:00
Dean Herbert
451af9d1b5
Fix beatmap values not being updated due to a varying data type
2023-05-08 13:23:13 +09:00
Dean Herbert
d9dd35c020
Show base velocity in slider adjustment popover
2023-05-08 13:13:09 +09:00
Dean Herbert
31de4de720
Remove median/mode slider velocity display
...
The intention was to give an idea of what the most common velocity of
the beatmap is, but in hindsight, because the "base" velocity is being
set elsewhere this doesn't make sense. It will/should be 1.0x.
Showing this range is still valuable, though.
2023-05-08 13:13:09 +09:00
