1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 12:02:54 +08:00
Commit Graph

942 Commits

Author SHA1 Message Date
Dean Herbert
c0f603eb0e Fix typo in comment 2023-09-19 15:27:56 +09:00
Bartłomiej Dach
b5d88713fe
Merge pull request #24691 from peppy/file-ipc-race-fix
Fix potential race condition in song bar beatmap lookup flow
2023-08-31 21:54:38 +02:00
Dean Herbert
cf9c8120c5 Fix potential race condition in song bar beatmap lookup flow
Cancelling a web request may not necessarily cancel the callbacks.

This might help with https://github.com/ppy/osu/issues/24598.
2023-08-31 19:04:10 +09:00
Dean Herbert
4bdaca3816 Fix regression in spacing on schedule screen 2023-08-31 18:47:41 +09:00
Dean Herbert
7aa1505062 Improve legibility of LINQ queries for recent/upcoming matches 2023-08-31 18:39:51 +09:00
Dean Herbert
5fa31b7b35 Fix schedule screen not responding to new matches being added 2023-08-31 18:39:51 +09:00
Bartłomiej Dach
8398e07be9
Merge branch 'master' into tournament-remove-minimum-window-size 2023-08-30 08:21:08 +02:00
Bartłomiej Dach
0f123fd8e0
Remove unused using directive 2023-08-30 08:20:57 +02:00
Dean Herbert
24d6cbefe1 Remove tournament client minimum window size
This seemed like a good idea but people were using it with smaller
resolutions, do let's just not do it.

Addresses https://github.com/ppy/osu/discussions/24670.
2023-08-30 13:45:00 +09:00
Dean Herbert
a85f0d5791 Allow saving changes in tournament system using Ctrl+S 2023-08-30 13:29:08 +09:00
Dean Herbert
58d5c26bcd
Merge pull request #24601 from peppy/fix-tournament-song-bar-crash
Fix crash in tournament client when pick/ban is activated
2023-08-21 17:32:59 +09:00
Bartłomiej Dach
f03c64462e
Better convey meaning of zero last year placement via tooltip 2023-08-21 08:58:49 +02:00
Dean Herbert
1067769b24 Remove masking on song bar
Turns out this breaks when a border style is applied for picks/bans, and it wasn't doing much for visuals anyway.
2023-08-21 15:34:03 +09:00
FreezyLemon
8d84ea3712 Allow "none" value in LastYearPlacing
This "none" value (zero) will be the default value for
any new team and will display as "N/A" in the SeedingScreen.
2023-08-18 21:05:12 +02:00
Bartłomiej Dach
ed84be2f26
Merge pull request #24566 from peppy/multiplayer-spectator-score-diff
Add score difference display to multiplayer spectator
2023-08-16 12:57:17 +02:00
Dean Herbert
d309865b0d Update TournamentMatchScoreDisplay to share base implementation 2023-08-16 17:26:10 +09:00
Dean Herbert
f02416f877 Improve visuals of tournament song bar
This is a stop-gap until we add new versions (and share between game and tournament client).
2023-08-16 17:16:36 +09:00
cdwcgt
5ad80879b7
let MatchIPCInfo .Beatmap be nullable 2023-08-09 19:13:49 +09:00
cdwcgt
5898a9986b
Revert "use no null when true"
This reverts commit 6ad8339c66.
2023-08-09 19:11:36 +09:00
Dean Herbert
c88045dfc7 Fix weird usage of Cast 2023-08-09 18:21:57 +09:00
cdwcgt
99dd156d53
remove useless using 2023-07-30 02:50:16 +09:00
cdwcgt
ba80d1e2d5
remove nullable for Box 2023-07-30 02:49:13 +09:00
cdwcgt
0590121309
string mod should not null
Already assigned in the constructor
2023-07-30 02:41:45 +09:00
cdwcgt
bc2ca11bb0
move to initialiser 2023-07-30 02:41:45 +09:00
cdwcgt
a1f0e59784
remove null check for b.Beatmap 2023-07-30 02:41:44 +09:00
cdwcgt
6ad8339c66
use no null when true 2023-07-30 02:41:25 +09:00
cdwcgt
88a1cf4005
remove all canBeNull from attribute 2023-07-30 01:57:54 +09:00
cdwcgt
9482f74456
fix nullable for TeamList 2023-07-30 01:49:57 +09:00
cdwcgt
cb4adf115c
RemoveTeam shouldn't have nullable arg 2023-07-30 01:40:13 +09:00
cdwcgt
625ed729ee
debug assert closest != null 2023-07-30 01:39:56 +09:00
cdwcgt
033c9091c0
use cast instead AsNonNull 2023-07-30 01:39:31 +09:00
cdwcgt
8a06914438
remove #nullable disable in tournament 2023-07-29 22:25:06 +09:00
Bartłomiej Dach
0c10d875ce
Merge branch 'master' into ladder-grid-expand 2023-07-28 22:51:33 +02:00
Dean Herbert
f58c69e639 Fix potential startup crash due to early application of animations
This was always haphazard code, but by luck it never triggered before
drawable load until now. With the recently nullability changes, this
would be triggered when `flash` is not yet constructed.

Switching to `AddOnce` seems safer to avoid multiple applications,
regardless.
2023-07-28 17:17:15 +09:00
Dean Herbert
aa91000505 Always place first match at (0,0) 2023-07-28 16:29:55 +09:00
Dean Herbert
b5c3e2a648 Fix placing new match via right click not using original click position 2023-07-28 16:29:39 +09:00
Dean Herbert
b5f0d739e6 Allow ladder editor grid to scale with content
Closes https://github.com/ppy/osu/issues/24378.
2023-07-28 16:26:03 +09:00
Dean Herbert
57e51f4d5b
Merge pull request #24357 from peppy/tournament-fix-null-population
Fix startup tournament population not recovering from null beatmaps
2023-07-28 14:31:48 +09:00
Dao Heng Liu
c7717da232 make SetupScreen scrollable 2023-07-28 14:18:48 +09:00
Bartłomiej Dach
780b8f0ec8
Merge branch 'master' into tournament-fix-null-population 2023-07-27 22:36:11 +02:00
Bartłomiej Dach
b7ddb5c946
Remove fallbacks to empty APIBeatmap on population failure
Was causing there to be two kinds of missing `TournamentBeatmap`s: one
with missing `Beatmap == null`, and one with `Beatmap == new
APIBeatmap()`. In particular, they would appear differently in UI
(either as "unknown - unknown", or the intensely enigmatic " - ").
2023-07-27 22:33:00 +02:00
Bartłomiej Dach
3c923b9e81
Fix even more missed nullability-related inspections 2023-07-27 22:10:41 +02:00
Dean Herbert
1e9b927b50 Fix some missed null checks 2023-07-27 17:41:27 +09:00
Dean Herbert
fa4992f05a Apply NRT and avoid throws from null RoundBeatmap.Beatmaps 2023-07-26 17:49:07 +09:00
Bartłomiej Dach
72db0c17ca
Merge branch 'master' into fix-scheduler-screen-selection-alignment 2023-07-25 18:44:44 +02:00
Bartłomiej Dach
43876ba2b0
Privatise currentMatchSelectionBox
Because nobody else should need to do anything as cursed as what
`ScheduleScreen` was doing (which is 95% of the reason why the selection
box even broke there).
2023-07-25 18:41:54 +02:00
Dean Herbert
0130c356ed Cache IDialogOverlay in a simpler way 2023-07-25 18:33:41 +09:00
Dean Herbert
2c5a329b04 Merge branch 'master' into tourney-dangerous-action-confirm 2023-07-25 18:27:58 +09:00
Dean Herbert
7d5305c5e8
Merge branch 'master' into tourney-fix-screen-auto-switch 2023-07-25 17:18:43 +09:00
Dean Herbert
c84381d802 Separate out each type of scheduled operation and refactor tidy-up code 2023-07-25 17:18:13 +09:00