1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 14:17:27 +08:00
Commit Graph

180 Commits

Author SHA1 Message Date
kj415j45
5fc1397564 Apply suggestion from code review
Co-authored-by: frenzibyte <frenzibyte@gmail.com>
2021-07-19 19:27:33 +08:00
kj415j45
3b48975f1e Add localisation for RankingOverlayHeader 2021-07-18 02:44:46 +08:00
kj415j45
224c37bdc3 Add localisation for RankingOverlay 2021-07-18 02:24:39 +08:00
Dean Herbert
e42609f092
Merge pull request #8038 from thewildtree/adjust-rankings-overlay
Adjust rankings overlay elements to better match osu-web
2021-07-07 20:24:11 +09:00
PercyDan54
e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
Dean Herbert
d119d9a0db Merge branch 'master' into adjust-rankings-overlay 2021-07-05 11:59:26 +09:00
Dean Herbert
54982dcdd7 Refactor LoadingLayer to avoid applying effects to external drawables
In theory this seemed like a good idea (and an optimisation in some
cases, due to lower fill rate), but in practice this leads to weird edge
cases.

This aims to do away with the operations on external drawables by
applying a dim to the area behind the `LoadingLayer` when required.
I went over each usage and ensured they look as good or better than
previously.

The specific bad usage here was the restoration of the colour on dispose
(if the `LoadingLayer` was disposed in a still-visible state).

I'm aware that the `BeatmapListingOverlay` will now dim completely during
load. I think this is fine for the time being.
2021-01-05 17:31:45 +09:00
Joehu
b4b9c71f00 Make all toolbar tooltips lowercase 2020-09-06 10:13:06 -07:00
Dean Herbert
dbf44fbaf2 Update names and icons to match new designs 2020-09-03 16:34:58 +09:00
Dean Herbert
dceae21bbf Centralise fetching of overlay component titles and textures 2020-09-03 16:34:58 +09:00
Andrei Zavatski
0a71194ea6 Fix SpotlightSelector is a VisibilityContainer without a reason 2020-07-21 22:46:08 +03:00
Andrei Zavatski
0043bd74ba Rework SpotlightSelector header layout 2020-07-15 08:27:46 +03:00
Andrei Zavatski
3d9e174ae8 Make sort changes affect request result 2020-07-14 18:09:09 +03:00
Andrei Zavatski
c2c80d2a98 Refactor SpotlightSelector layout 2020-07-14 17:34:01 +03:00
Andrei Zavatski
6eec2f9429 Implement RankingsSortTabControl component 2020-07-13 01:22:05 +03:00
Dean Herbert
ed9663985b Rename panels 2020-04-21 20:55:33 +09:00
Dean Herbert
9b9b710ded Move and rename remaining direct classes 2020-04-21 16:41:07 +09:00
TheWildTree
a5781d7fc5 Replace ScreenTitle with OverlayTitle and update titles to match new design 2020-03-24 22:08:20 +01:00
TheWildTree
db55b98ed3 Move grade column spacing logic to UserBasedTable 2020-03-15 22:03:54 +01:00
TheWildTree
f1e54d2745 Apply suggestions 2020-03-15 18:32:12 +01:00
TheWildTree
280a009784 Fix header colours being flipped 2020-03-15 18:31:44 +01:00
TheWildTree
1c69e4eb5b Update SpotlightSelector design 2020-03-15 18:26:33 +01:00
TheWildTree
df328dd981 Revert margin changes 2020-03-05 23:17:36 +01:00
TheWildTree
56f76580fd Use Y-axis autosizing in SpotlightsDropdownHeader 2020-03-04 18:22:56 +01:00
TheWildTree
06642dc7ff Improve HeaderText highlight and spacing logic 2020-03-04 18:20:55 +01:00
TheWildTree
276a90fb84 Use public property instead of ctor parameter 2020-03-04 18:19:28 +01:00
TheWildTree
e09fbcb05f Only add link if the country name isn't null 2020-03-04 17:47:48 +01:00
TheWildTree
520bbcf2e4 Use correct x-axis margins 2020-02-29 15:19:36 +01:00
TheWildTree
0760ccf024 Adjust CountryFilter spacing to match web 2020-02-29 15:14:25 +01:00
TheWildTree
6d09f1eea4 Hook up SpotlightsDropdownHeader 2020-02-28 13:18:40 +01:00
TheWildTree
92da7132cd Fix code quality issues 2020-02-27 23:51:21 +01:00
TheWildTree
b65f5031a2 Adjust spacing in SpotlightSelector 2020-02-27 23:51:21 +01:00
TheWildTree
1d6746102f Adjust user links 2020-02-27 23:51:21 +01:00
TheWildTree
9e4a6a9cf3 Add spacing between RankingsTable rows to match osu-web 2020-02-27 23:51:21 +01:00
TheWildTree
f03ada65dd Adjust grade columns spacing 2020-02-27 23:51:21 +01:00
TheWildTree
82cbd35e30 Make CountryName use LinkFlowContainer for consistency 2020-02-27 23:51:21 +01:00
TheWildTree
62e676feb5 Restyle SpotlightsDropdown to match osu-web 2020-02-27 23:51:21 +01:00
Dan Balasescu
d6b6edce02
Merge branch 'master' into centralise-loading-animations 2020-02-21 19:48:50 +09:00
Dean Herbert
556131cd5f Merge branch 'master' into ingame-rankings 2020-02-21 18:51:54 +09:00
Dean Herbert
623b78d675 Combine all loading animation implementations 2020-02-21 15:32:46 +09:00
Andrei Zavatski
7b0c3281c2 Make country names clickable 2020-02-19 16:49:39 +03:00
Andrei Zavatski
5d813bf421 Merge remote-tracking branch 'refs/remotes/ppy/master' into ingame-rankings 2020-02-19 16:23:18 +03:00
Andrei Zavatski
e9003346d4 Add missing blank line 2020-02-18 21:28:38 +03:00
Andrei Zavatski
5347119a85 Various RankingsOverlay fixes 2020-02-18 21:26:25 +03:00
Dan Balasescu
9e816e3479
Merge branch 'master' into italic-rankings-stuff 2020-02-18 16:05:18 +09:00
Andrei Zavatski
c78534d14e Fix possible error in SpotlightsLayout 2020-02-17 10:07:32 +03:00
Andrei Zavatski
f64eabc38b Make countries name non-italic 2020-02-14 20:49:37 +03:00
Andrei Zavatski
c68c347503 Remove unwanted property interpolation 2020-02-14 00:40:52 +03:00
Andrei Zavatski
ab84f4085a Fix possible error on SpotlightsLayout disposal 2020-02-13 23:20:45 +03:00
Andrei Zavatski
791bf6bc01 Make username text italic 2020-02-13 19:03:07 +03:00
Andrei Zavatski
e67e4f708e Adjust country name design 2020-02-13 19:01:26 +03:00
Andrei Zavatski
11c59a141f Add background to rankings header 2020-02-13 14:12:10 +03:00
Andrei Zavatski
0b6558dc40 Add SpotlightsLayout to RankingsOverlay 2020-02-11 02:35:23 +03:00
Andrei Zavatski
b04a4b5c8a Implement SpotlightsLayout 2020-02-11 01:44:56 +03:00
Andrei Zavatski
24e8a2bd69 Make SpotlightSelector.ShowInfo use the full rankings response 2020-02-05 22:59:01 +03:00
Andrei Zavatski
6708e271ac Adjust SpotlightSelector animations 2020-02-05 13:01:50 +03:00
Andrei Zavatski
cb30f463fb Update spotlight info based on selected one 2020-02-05 12:48:29 +03:00
Andrei Zavatski
a3fd952f74 Use new SpotlightSelector in RankingsHeader 2020-02-05 11:21:23 +03:00
Andrei Zavatski
a9cfade2f4 Adjust null handling 2020-02-04 21:02:10 +03:00
Andrei Zavatski
f889f2435b Add test step to TestSceneRankingsTable 2020-02-04 16:20:15 +03:00
Andrei Zavatski
524a8ba6c6 Merge remote-tracking branch 'refs/remotes/ppy/master' into rankings-overlay-update 2020-02-04 11:19:13 +03:00
recapitalverb
42060139f8
Merge branch 'master' into display-accuracy 2020-02-04 12:51:48 +07:00
Andrei Zavatski
824ee8a888 Recolour rankings tables 2020-02-03 21:22:37 +03:00
Andrei Zavatski
2a802307e7 Delete unused components 2020-02-03 20:59:08 +03:00
Andrei Zavatski
dc1d0d0f32 Add spotlights selector to new header 2020-02-03 20:47:41 +03:00
Andrei Zavatski
588a77484b Add ContryFilter to new header 2020-02-03 20:32:20 +03:00
Andrei Zavatski
b284170437 Basic implementation of new RankingsOverlayHeader 2020-02-03 20:20:35 +03:00
Andrei Zavatski
12574111e5 Use ColourProvider colours 2020-02-03 19:44:10 +03:00
Andrei Zavatski
e531570352 Merge remote-tracking branch 'refs/remotes/ppy/master' into spotlights_api 2020-02-03 19:34:35 +03:00
recapitalverb
4dfdd98e8b Use UserStatistics.DisplayAccuracy everywhere 2020-02-03 22:12:34 +07:00
smoogipoo
1367c18d3f General refactorings 2020-01-14 15:07:25 +09:00
smoogipoo
d6bd0b7106 Container -> CompositeDrawable 2020-01-14 14:43:57 +09:00
smoogipoo
33993837b7 Remove participant count (not returned by API) 2020-01-14 14:41:38 +09:00
smoogipoo
05702af905 Remove map count (not returned by API) 2020-01-14 14:37:24 +09:00
smoogipoo
7349c023d1 Cleanup spotlight selection 2020-01-14 14:01:51 +09:00
Andrei Zavatski
90e4def4bd Remove online stuff out of the selector 2020-01-14 07:07:21 +03:00
Andrei Zavatski
9260ea9195 Apply suggestions 2020-01-10 20:46:35 +03:00
Andrei Zavatski
2e627f4b7c Implement InfoColumn component 2020-01-10 17:30:51 +03:00
Andrei Zavatski
474d7e92d9 Fix incorrect dropdown menu height 2020-01-10 16:41:17 +03:00
Andrei Zavatski
d48b161662 Implement basic SpotlightSelector component 2020-01-10 16:33:00 +03:00
Andrei Zavatski
0d9fb065da Move CountryPill to it's own class 2020-01-09 00:27:22 +03:00
Andrei Zavatski
6cb763a019 Improve animations 2020-01-09 00:06:28 +03:00
Andrei Zavatski
1dbae21f98 Fix crashing test 2020-01-08 19:40:28 +03:00
Andrei Zavatski
1428952377 Implement CountryFilter component for RankingsOverlay 2020-01-08 18:59:13 +03:00
Dean Herbert
5f9b9631ef Move scope/country restrictions into RankingsOverlay 2019-12-05 14:07:39 +09:00
Dean Herbert
e678fe7a77 Move potentially expensive load to BDL 2019-11-29 15:35:33 +09:00
Andrei Zavatski
83e3ad9e69 Make Rankings a ctor variable 2019-11-28 20:09:05 +03:00
Dean Herbert
aa9776d51a seal and compact rows 2019-11-28 19:07:43 +09:00
Andrei Zavatski
8077c86d13 CI fixes 2019-11-27 23:58:31 +03:00
Andrei Zavatski
800bda7e81 Refactor tables to avoid code duplication 2019-11-27 23:35:02 +03:00
Andrei Zavatski
c546df8a80 Refactor API logic 2019-11-27 21:56:22 +03:00
Andrei Zavatski
2135a7fd7b Don't use repetitive headers in each class 2019-11-27 21:46:41 +03:00
Andrei Zavatski
4cf5968026 Simplify place calculation 2019-11-27 21:39:38 +03:00
Andrei Zavatski
14c471fe5d Move Rankings property below ctor 2019-11-27 21:37:34 +03:00
Andrei Zavatski
bb3152ac8b Use string.empty for empty headers 2019-11-27 21:35:03 +03:00
Dean Herbert
e1302d84dd Use string.Empty 2019-11-28 00:26:10 +09:00
Dean Herbert
4221a0126c
Merge branch 'master' into rankings-tables 2019-11-27 23:26:54 +09:00
Dean Herbert
45514ff660 Apply fixes 2019-11-25 11:30:55 +09:00
Andrei Zavatski
423e26a4d1 Fix header text could be sticked together 2019-11-06 13:07:25 +03:00
Andrei Zavatski
48385dbdfe Layout adjustments 2019-11-03 14:31:23 +03:00