635 Commits

• Fix incorrect circle piece hitbox

  Hitboxes of circle pieces in osu! have regressed with commit 8592335.
  The reason for the regression was that hit detection was moved from
  DrawableHitCircle itself to a newly-introduced private HitArea class
  (now named HitReceptor).
  
  As HitArea inherited from Drawable, it would return IsHovered == true
  over its entire bounding box. This meant that the hit area could wrongly
  pick up actions that are not within circle radius and make them into
  hits.
  
  To resolve, make HitReceptor a CompositeDrawable and set its corner
  radius to match the circle piece. This fixes the invalid hitbox, as
  IsHovered takes radius into account.

  Bartłomiej Dach · 2020-03-06 21:21:20 +01:00
  77fd748035
• Use stacked positions
  smoogipoo · 2020-03-04 09:46:53 +09:00
  5e218697c5
• Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements

  Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  Dan Balasescu · 2020-02-25 20:38:29 +09:00
  ff063b229b
• Fix incorrect LifetimeStart and add todo regarding Expire usage
  Dean Herbert · 2020-02-24 12:24:15 +09:00
  e6cfafffe9
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Make FollowPointRenderer a LifetimeManagementContainer
  Dean Herbert · 2020-02-23 04:37:04 +09:00
  090d9d9350
• Give FollowPointConnections a valid lifetime
  Dean Herbert · 2020-02-23 04:36:50 +09:00
  cb9a7ee0bb
• Add fill to default skin slider ball when tracking
  Dean Herbert · 2020-02-21 17:38:23 +09:00
  00b4fc1e1f
• Update with framework-side bindable list changes
  smoogipoo · 2020-02-17 15:06:14 +09:00
  958c891d15
• Make sMake spinner's EndTime correct on construction
  Dean Herbert · 2020-02-07 19:08:37 +09:00
  6297606baa
• Throw NotSupportedException instead
  Dean Herbert · 2020-02-06 13:16:32 +09:00
  daf5fa9da4
• Make EndTime and RepeatCount settable
  Dean Herbert · 2020-02-05 17:52:51 +09:00
  cd6902a312
• Make slider tracking match what is on screen
  Dean Herbert · 2020-02-03 11:55:14 +09:00
  84fcf45aae
• Merge branch 'master' into fix-follow-circle
  Dean Herbert · 2020-02-03 09:58:12 +09:00
  cf4788d7ef
• Make variables private
  TheWildTree · 2020-02-02 14:34:06 +01:00
  35032e2ddd
• Remove unnecessary parameter
  TheWildTree · 2020-02-02 14:33:48 +01:00
  f7abfdb40e
• Rename drawable
  TheWildTree · 2020-02-02 11:24:28 +01:00
  e2589b2dcb
• Use Bindable{Float,Double}s everywhere

  To avoid further floating-point comparison bugs, remove all usages of
  Bindable<{float,double}>, replacing them with their
  Bindable<Float,Double> counterparts.

  Bartłomiej Dach · 2020-02-01 22:50:29 +01:00
  434c0d92e4
• Match osu-stable behaviour and size
  TheWildTree · 2020-02-01 16:55:30 +01:00
  9f4261111b
• Apply OnRelease method signature refactorings
  smoogipoo · 2020-01-22 13:22:34 +09:00
  7b2f58eb30
• Cleanup
  smoogipoo · 2020-01-14 18:14:31 +09:00
  92daf9b8f1
• Remove limiting clause
  Dean Herbert · 2020-01-14 01:48:20 +09:00
  fe09e34f1b
• Remove weird time clause
  Dean Herbert · 2020-01-14 01:47:44 +09:00
  ab4f31639d
• Remove default value
  Dean Herbert · 2020-01-14 01:45:32 +09:00
  210d06b75e
• Use Child, not InternalChild
  Dean Herbert · 2020-01-14 01:45:10 +09:00
  c5085aea24
• Make reverse arrow animate faster via divisor specification

  Adds MinimumBeatLength to BeatSyncedContainer to make sure things don't get out of hand.

  Dean Herbert · 2020-01-14 01:39:45 +09:00
  619fe29871
• Merge remote-tracking branch 'upstream/master' into reverse-arrows
  Sebastian Krajewski · 2020-01-13 14:15:37 +01:00
  45cf65a28a
• Remove excess namespace specification
  Dean Herbert · 2020-01-10 01:13:42 +08:00
  87645f6a41
• Merge branch 'master' into Remove_osuTK.MathHelper
  Dean Herbert · 2020-01-10 00:28:46 +08:00
  3be2fc27f3
• Update MathUtils namespace usages
  smoogipoo · 2020-01-09 13:43:44 +09:00
  91735ff367
• Use tuple deconstruction to swap values
  Berkan Diler · 2020-01-08 20:46:17 +01:00
  ed2bf5154d
• Remove remaining usage of osuTK.MathHelper
  Berkan Diler · 2020-01-08 20:21:13 +01:00
  34d8740ec4
• Remove settings related to reverse arrow
  Sebastian Krajewski · 2020-01-07 04:55:05 +01:00
  21468eb070
• Fix repeat point pulsing when it is in fade out state
  Sebastian Krajewski · 2020-01-04 13:12:37 +01:00
  3194658998
• Add slider reverse arrow pulse settings
  Sebastian Krajewski · 2020-01-04 13:01:42 +01:00
  46271ccbc8
• Change reverse arrow pulse easing to OutQuad
  Sebastian Krajewski · 2020-01-04 10:35:10 +01:00
  fc0b622a69
• Add pulse to slider reverse arrows
  Sebastian Krajewski · 2020-01-04 08:21:48 +01:00
  9da7eec0d9
• Fix SPM calculation logic not handling paused clocks (#7253)

  Fix SPM calculation logic not handling paused clocks
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dean Herbert · 2019-12-18 16:30:18 +09:00
  f150d22eaf
• Implement legacy slider border shadow
  smoogipoo · 2019-12-18 13:37:37 +09:00
  1fe0e45a9c
• Make SpmCounter public
  Salman Ahmed · 2019-12-18 03:04:37 +03:00
  cbfbbf9999
• Early-return on potential division by zero in SPM calculation
  Salman Ahmed · 2019-12-18 03:03:12 +03:00
  7e58b4a948
• Prevent test scene failures through casting softly
  smoogipoo · 2019-12-17 21:26:23 +09:00
  35276c3739
• Fix various display issues by abstracting further
  smoogipoo · 2019-12-17 19:29:27 +09:00
  7c2884700e
• Add legacy slider body support
  smoogipoo · 2019-12-17 18:16:25 +09:00
  9caed9e98a
• Add abstract implementation of slider path
  smoogipoo · 2019-12-17 17:54:05 +09:00
  1e798a8dbe
• Don't reuse the same control point references
  smoogipoo · 2019-12-16 15:27:54 +09:00
  a554ca728b
• Remove automatic slider path offsetting
  smoogipoo · 2019-12-09 17:54:22 +09:00
  883d5bc11d
• Refactor hitobjects to remove default control point
  smoogipoo · 2019-12-09 17:48:27 +09:00
  fa1468325e
• Remove unused usings
  smoogipoo · 2019-12-09 13:19:21 +09:00
  4905709ea4
• Fix nested hitobjects not updating
  smoogipoo · 2019-12-06 20:53:40 +09:00
  b9d12e5fe4