72986 Commits

This Branch

This Branch

All Branches

• Fix song select test scenes not given a width when running tests individually
  Salman Alshamrani · 2025-04-30 16:10:41 +09:00
  d491b6872e
• Merge pull request #32896 from bdach/more-hit-window-testing

  Add more test cases covering correct legacy replay playback with respect to hitwindow treatment with mods active

  Dean Herbert · 2025-04-26 06:22:29 +09:00
  d26c94cfac
• Merge pull request #32938 from bdach/ruleset-skin-combo-testing

  Add test scene coverage of HUD layouts on various ruleset/skin combinations

  Dean Herbert · 2025-04-26 05:48:26 +09:00
  4d3631cf96
• Adjust variables for legibility

  I found the previous way things were written a bit awkward. Easier to
  just enforce non-null here.

  Dean Herbert · 2025-04-26 05:18:24 +09:00
  0301463810
• Fix TriangleSkin not always returning a container for GlobalSkinnableContainerLookup

  We have other safeties which mean that this is not an issue during
  gameplay, but in the new `TestSceneHUDOverlayRulesetLayouts` it became
  apparent that allowing this to fallback (via `null` return) could lead
  to weirdness.

  Dean Herbert · 2025-04-26 05:14:36 +09:00
  54e0e1420f
• Fix filename not matching test scene
  Dean Herbert · 2025-04-26 04:51:03 +09:00
  0287ca285c
• Merge pull request #32946 from bdach/new-combo-collapsed
  Dean Herbert · 2025-04-25 17:40:08 +09:00
  3cbdf2b890
• Merge pull request #32845 from nekodex/bss-audio-feedback

  Add audio feedback to the BSS process

  Dean Herbert · 2025-04-25 17:25:12 +09:00
  85a5033454
• Remove unnecessary try-finally usage
  Dean Herbert · 2025-04-25 17:22:25 +09:00
  c6a11a56a3
• Update resources
  Dean Herbert · 2025-04-25 16:35:34 +09:00
  40f6283fb5
• Add test mode which allow more realistic testing of samples
  Dean Herbert · 2025-04-25 16:25:27 +09:00
  032459ea4e
• Attempt to improve appearance of new combo toggle / combo colour control when contracted

  Follow-up to
  https://discord.com/channels/188630481301012481/188630652340404224/1364909125812617258.
  
  Not sure if better, but an attempt was made?

  Bartłomiej Dach · 2025-04-25 08:52:59 +02:00
  bc03a2a930
• Merge pull request #32941 from peppy/user-cover-delayed-load-failure
  Bartłomiej Dach · 2025-04-24 15:23:13 +02:00
  8023bbd5e7
• Merge pull request #32674 from smoogipoo/freestyle-mods

  Allow mods/freemods in combination with freestyle

  Bartłomiej Dach · 2025-04-24 14:51:04 +02:00
  d8a69e462c
• Fix user covers not loading if one corner is off-screen
  Dean Herbert · 2025-04-24 21:40:20 +09:00
  4bf5e9a4dd
• Update 404ing cover image URLs
  Dean Herbert · 2025-04-24 21:27:30 +09:00
  c149a6efd6
• Rework logic to use a looping sample for progress instead
  Jamie Taylor · 2025-04-24 20:38:15 +09:00
  9c56ee3e19
• Remove (currently) unused resolved dependency
  Bartłomiej Dach · 2025-04-24 13:23:00 +02:00
  9818f859cb
• Add test scene coverage of HUD layouts on various ruleset/skin combinations

  As time goes on, default skin layouts are getting more and more
  complicated because of per-ruleset overrides. This was already sort of
  apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
  it worse, so before I do, this is a test scene that is supposed to make
  it easier to check all possible combinations at a glance.

  Bartłomiej Dach · 2025-04-24 12:50:34 +02:00
  33f45b0a6d
• Merge pull request #32937 from bdach/ternary-selection-fixes

  Fix multiple issues with editor ternary toggle state management

  Dean Herbert · 2025-04-24 19:23:00 +09:00
  a0044116f3
• Merge pull request #32936 from bdach/fix-present-score-dying

  Fix presenting score potentially dying due to deleted beatmap

  Dean Herbert · 2025-04-24 19:17:43 +09:00
  fbb7460322
• Fix deselecting single item from a multiple selection not updating ternary states correctly

  I'm not sure why this condition was written this obtusely, but
  importantly it was also wrong. It fires when the selection contains
  multiple items and only some are removed from it, like when
  ctrl-click-unselecting an item from a multiple selection.

  Bartłomiej Dach · 2025-04-24 09:25:36 +02:00
  5a3ff11710
• Reset sample ternary states on deselection

  Closes https://github.com/ppy/osu/issues/32928.
  
  Appears to match stable:
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4137-L4143
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L1615-L1618
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4323

  Bartłomiej Dach · 2025-04-24 09:25:27 +02:00
  5c04f427a5
• Fix code quality
  Bartłomiej Dach · 2025-04-24 08:54:10 +02:00
  72dd3513fc
• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Merge pull request #32922 from peppy/fix-tablet-adjust-precision

  Fix tablet settings adjusting with too much precision

  Dean Herbert · 2025-04-24 15:23:56 +09:00
  4a95973b6e
• Change samples to be declared nullable
  Jamie Taylor · 2025-04-24 11:31:02 +09:00
  15a4ffe344
• Move playback logic to Update()
  Jamie Taylor · 2025-04-24 10:48:32 +09:00
  f6f098a0dc
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Merge pull request #32915 from peppy/carousel-update-handling

  Add basic support for beatmap updates in `BeatmapCarousel`

  Bartłomiej Dach · 2025-04-23 13:10:25 +02:00
  7cf8207e6e
• Merge pull request #32924 from smoogipoo/fix-mp-results-background

  Show true beatmap background when viewing historical multiplayer results

  Bartłomiej Dach · 2025-04-23 12:42:00 +02:00
  212e7a1170
• Fix beatmap wedge test failures

  Started failing after 5ad28a792b, I'm
  guessing.

  Bartłomiej Dach · 2025-04-23 12:20:17 +02:00
  618ab4fec6
• Move implementation to base class
  Dan Balasescu · 2025-04-23 18:27:59 +09:00
  655861752d
• Merge pull request #32909 from bdach/fix-daily-challenge-marker

  Fix daily challenge marker text spacing

  Dean Herbert · 2025-04-23 18:24:56 +09:00
  0adda23988
• Ensure online ID has a valid online value before preferring it
  Dean Herbert · 2025-04-23 18:21:17 +09:00
  1488a49dae
• Fix stack overflow due to bindable equality
  Dan Balasescu · 2025-04-23 18:17:27 +09:00
  e36c6db008
• Remove online ID equality TODO and add explanation as to why it's not required
  Dean Herbert · 2025-04-23 18:13:13 +09:00
  73773aa69a
• Maintain selection using OnlineID as a priority
  Dean Herbert · 2025-04-23 18:01:49 +09:00
  414150e9e0
• Merge pull request #32842 from frenzibyte/song-select-v2-wedges-title

  Add song select beatmap title wedge

  Dean Herbert · 2025-04-23 17:39:03 +09:00
  ddb4c0e24f
• Merge pull request #32843 from frenzibyte/song-select-v2-wedges-metadata

  Add song select beatmap metadata wedge

  Dean Herbert · 2025-04-23 17:36:12 +09:00
  f945298bde
• Fix "mapped by" line showing stupid display when switching to default beatmap
  Dean Herbert · 2025-04-23 17:34:59 +09:00
  5ad28a792b
• Simplify and fix naming of statistic class
  Dean Herbert · 2025-04-23 17:32:18 +09:00
  4290f2d4fd
• Fix animations and alignment of tiny statistics
  Dean Herbert · 2025-04-23 17:20:52 +09:00
  9372ba02d1
• Remove silly bindable flow that only exists for testing purposes
  Dean Herbert · 2025-04-23 17:08:48 +09:00
  c11220df9b
• Improve star rating colour animations to match
  Dean Herbert · 2025-04-23 17:04:53 +09:00
  f6d7e29396
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Merge pull request #32923 from smoogipoo/keep-settings-on-room-update

  Keep multiplayer settings open during room updates

  Bartłomiej Dach · 2025-04-23 09:47:56 +02:00
  059f6ef35c
• Show true beatmap background when viewing historical multiplayer results
  Dan Balasescu · 2025-04-23 16:28:44 +09:00
  65cf1a4b7c
• Merge pull request #32913 from peppy/leaderboard-fetch-refactor

  Remove `LeaderboardManager` return value and simplify flow further

  Bartłomiej Dach · 2025-04-23 09:27:12 +02:00
  7636573e21
• Adjust tests and transitions
  Dean Herbert · 2025-04-23 16:23:37 +09:00
  883df07ff6