Dean Herbert
401bf1c928
Remove unnecessary checks on NotNull attributes
2020-02-23 14:30:08 +09:00
Dean Herbert
0e29d3c4a2
Correctly expire bar lines in osu!taiko and osu!mania
2020-02-23 13:50:05 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Andrei Zavatski
74c7e29108
Apply suggestions
2020-02-23 01:22:37 +03:00
Andrei Zavatski
db7f29cc0e
Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-retouch
2020-02-23 00:54:54 +03:00
Dean Herbert
0c3286fa5e
Merge branch 'judgement-line-performance' into follow-point-performance
2020-02-23 05:36:22 +09:00
Dean Herbert
560cf21b12
Add lenience to comparison
...
Noticed that they could still stack up on maps with hitcircles at the same point in time (centipede).
2020-02-23 05:29:17 +09:00
Dean Herbert
4949977d7e
Merge branch 'judgement-line-performance' into follow-point-performance
2020-02-23 05:14:21 +09:00
Dean Herbert
187770ee7d
Merge branch 'fix-loading-animation' into follow-point-performance
2020-02-23 05:14:18 +09:00
Dean Herbert
aaa888a7c1
Adjust spin duration to make rotation more variable
2020-02-23 05:00:38 +09:00
Dean Herbert
8dbcdebd28
Use LoadingLayer at player loading screen
2020-02-23 05:00:08 +09:00
Dean Herbert
090d9d9350
Make FollowPointRenderer a LifetimeManagementContainer
2020-02-23 04:37:04 +09:00
Dean Herbert
cb9a7ee0bb
Give FollowPointConnections a valid lifetime
2020-02-23 04:36:50 +09:00
Dean Herbert
e8ebb31517
Expire old judgement lines if too many exist
2020-02-23 03:53:51 +09:00
Dean Herbert
3daa49f1bd
Clean up old judgement lines if too many are already present
2020-02-23 03:39:12 +09:00
Dean Herbert
5aa5a1bbdd
Reduce transform time of judgement lines (visually looks almost the same)
2020-02-23 03:36:15 +09:00
Dean Herbert
66317f9fcd
Merge pull request #7961 from bdach/log-location-in-issue-template
...
Rework issue templates
2020-02-23 01:13:45 +09:00
Bartłomiej Dach
b8aef4ad4b
Remove mobile issue template
2020-02-22 16:50:56 +01:00
Bartłomiej Dach
f696724c1d
Mention issue templates in README
2020-02-22 16:26:10 +01:00
Bartłomiej Dach
ab3cc9ada4
Add log file location to issue templates
2020-02-22 16:25:00 +01:00
Dean Herbert
17d4757c3b
Merge pull request #7950 from bdach/fix-direct-panel-scene
...
Fix regressed direct panel test scene
2020-02-22 22:22:32 +09:00
Bartłomiej Dach
a512226036
Use attribute instead of CreateChildDependencies
2020-02-22 13:47:42 +01:00
Lucas A
c9d600b69c
Show RankingsOverlay when clicking on charts button
2020-02-22 11:55:34 +01:00
Andrei Zavatski
63006e8672
Refactor to avoid visual inconsistency for beatmaps with no leaderboard
2020-02-22 03:40:59 +03:00
Andrei Zavatski
894b50f955
Basic implementation of BeatmapSetCommentsContainer
2020-02-22 03:24:50 +03:00
Bartłomiej Dach
f248c0a98e
Fix regressed direct panel test scene
...
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.
Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.
As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
Andrei Zavatski
44ddc585da
Remove unused usings
2020-02-21 18:40:42 +03:00
Andrei Zavatski
8593642a04
Adjust StreamBadgeArea
2020-02-21 18:12:23 +03:00
Andrei Zavatski
71623067e3
Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-retouch
2020-02-21 18:12:10 +03:00
Dean Herbert
e21db7dbbe
Remove linux self-compile recommendation
2020-02-22 00:09:55 +09:00
Dean Herbert
3296265066
Add linux download link to readme
2020-02-22 00:07:20 +09:00
Andrei Zavatski
c49074dde3
Adjust comments placement
2020-02-21 17:29:51 +03:00
Andrei Zavatski
48a9b465ef
Adjust icons colour
2020-02-21 17:22:46 +03:00
Andrei Zavatski
491906d534
Adjust ChangelogListing appearance
2020-02-21 17:19:49 +03:00
Andrei Zavatski
70eb2ed09e
Adjust ChangelogBuild appearance
2020-02-21 17:11:29 +03:00
Andrei Zavatski
e9f69d2c23
Adjust date for ChangelogSingleBuild
2020-02-21 16:55:12 +03:00
Andrei Zavatski
3fdf8dc386
Recolour main background
2020-02-21 16:41:52 +03:00
Dean Herbert
66bd888227
Merge pull request #7930 from EVAST9919/changelog-comments
...
Add CommentsContainer to ChangelogOverlay
2020-02-21 21:20:35 +09:00
Dean Herbert
db1e5abad7
Merge pull request #7786 from EVAST9919/subcomments-alter-new
...
Add ability to load long comment trees in CommentsContainer
2020-02-21 21:18:33 +09:00
Dean Herbert
8baf6a5380
Merge pull request #7933 from peppy/slider-ball-effect
...
Add fill to default skin slider ball when tracking
2020-02-21 21:15:47 +09:00
Dean Herbert
fea45623cf
Merge pull request #7934 from peppy/catch-explode-effect
...
Add explosion effect when catching fruit
2020-02-21 21:10:53 +09:00
Dean Herbert
33812d6b53
Merge pull request #7932 from peppy/use-loading-inbeatmap-listing
...
Use new loading layer in beatmap listing overlay
2020-02-21 20:37:48 +09:00
Dan Balasescu
110f7e896e
Merge branch 'master' into catch-explode-effect
2020-02-21 20:07:00 +09:00
Dan Balasescu
de2cf4d2a8
Merge branch 'master' into slider-ball-effect
2020-02-21 20:05:56 +09:00
Dean Herbert
a97355b02d
Merge pull request #7936 from peppy/add-linux-basic-update-support
...
Add simple updater support for linux AppImages
2020-02-21 20:02:14 +09:00
Dean Herbert
22a28751d0
Merge branch 'master' into use-loading-inbeatmap-listing
2020-02-21 19:59:04 +09:00
Dean Herbert
efd9740251
Merge pull request #7931 from peppy/centralise-loading-animations
...
Use a single implementation for all loading animations
2020-02-21 19:58:47 +09:00
smoogipoo
7fd71d9b6c
Adjust conditional
2020-02-21 19:50:16 +09:00
Dan Balasescu
d6b6edce02
Merge branch 'master' into centralise-loading-animations
2020-02-21 19:48:50 +09:00
smoogipoo
4c083e0e7e
Add back orphaning as a fail-safe
2020-02-21 19:41:25 +09:00
