17005 Commits

• Merge pull request #33348 from bdach/song-select-v2-gap-between-beatmap-panel-and-set-panel

  SongSelectV2: Fix input gap between last beatmap panel in set and next set panel

  Dean Herbert · 2025-05-31 12:07:58 +09:00
  ccb47baa8c
• Merge pull request #33345 from bdach/song-select-v2-human-fuzzers

  SongSelectV2: Fix more crashes resulting from users deliberately trying to break things

  Dean Herbert · 2025-05-31 11:46:07 +09:00
  b569de3343
• SongSelectV2: Fix more crashes resulting from users deliberately trying to break things

  See https://github.com/ppy/osu/issues/33336#issuecomment-2922443444.
  
  Can't wait for even more human fuzzing to come later.

  Bartłomiej Dach · 2025-05-30 19:54:49 +02:00
  d2abfe4370
• Merge pull request #33321 from peppy/song-select-v2-scroll-to-selected

  SongSelectV2: Fix scroll to selected not always scrolling

  Dean Herbert · 2025-05-31 02:46:39 +09:00
  28342c51b1
• SongSelectV2: Fix input gap between last beatmap panel in set and next set panel
  Bartłomiej Dach · 2025-05-30 19:13:42 +02:00
  f462c683ee
• Merge pull request #33333 from nekodex/rank-display-sfx

  Adds SFX for rank changes to the in-game rank display

  Dean Herbert · 2025-05-31 01:21:00 +09:00
  d18efc9ab4
• Fix abhorrently incorrect bindable usage
  Dean Herbert · 2025-05-31 00:41:28 +09:00
  43b7171f5c
• Merge pull request #33338 from nekodex/songselect-v2-sfx-fixes

  SongSelectV2: Fix some missing/incorrect SFX

  Dean Herbert · 2025-05-30 22:14:26 +09:00
  b597f3eb17
• Replace assertion with hard guard

  Closes https://github.com/ppy/osu/issues/33336.
  
  I was worried that doing that was going to cause terminal breakage but
  in testing it does not appear to so I'm just going to do this and call
  it a day.

  Bartłomiej Dach · 2025-05-30 15:05:14 +02:00
  ba1148c59e
• Fix selection's carousel Y position being read too early

  `updateItemYPosition()` mutates `item.CarouselYPosition`, so storing
  that to the selections before it's updated is storing stale values.

  Bartłomiej Dach · 2025-05-30 14:49:03 +02:00
  a3db764008
• SongSelectV2: Fix some missing/incorrect SFX
  Jamie Taylor · 2025-05-30 21:31:26 +09:00
  cf6e9f8ad8
• Fix incorrect cross-thread access of beatmap list
  Dean Herbert · 2025-05-30 19:39:49 +09:00
  5cf173196e
• Merge pull request #33332 from peppy/song-select-v2-fix-double-filter

  SongSelectV2: Fix carousel filtering twice on entering song select

  Bartłomiej Dach · 2025-05-30 12:29:32 +02:00
  559ddd1ec9
• Use nullable Criteria instead of ctor flag
  Dean Herbert · 2025-05-30 18:15:27 +09:00
  5bf235f2dc
• Fix unintentional initial filter delay on entering song select
  Dean Herbert · 2025-05-30 18:08:28 +09:00
  5222c30139
• Merge branch 'master' into song-select-v2-polish-2
  Bartłomiej Dach · 2025-05-30 11:07:11 +02:00
  4915e4d266
• Add sfx to ingame rank display
  Jamie Taylor · 2025-05-30 17:52:36 +09:00
  04f1e59d0e
• Hide all unsupported grouping modes for now
  Dean Herbert · 2025-05-30 17:02:52 +09:00
  27fe9485bd
• Also hide any popovers when footer sets new buttons (ie we're moving to a new screen)
  Dean Herbert · 2025-05-30 16:49:24 +09:00
  40d801d2c1
• Adjust panel content alignment slightly
  Dean Herbert · 2025-05-30 16:48:48 +09:00
  9bf111c66a
• Inflate padding to left of difficulty icon to make more visually even
  Dean Herbert · 2025-05-30 16:33:58 +09:00
  6e1a1bb562
• Separate out expanded/selected set and difficulty panels with extra padding
  Dean Herbert · 2025-05-30 16:27:19 +09:00
  017cef4255
• Fix carousel filtering twice on entering song select
  Dean Herbert · 2025-05-30 16:03:31 +09:00
  bb938be0b6
• SongSelectV2: Add back ability to manage collections from beatmap / set panel context menus
  Dean Herbert · 2025-05-30 15:04:42 +09:00
  2bbd1ee384
• Merge pull request #33322 from bdach/song-select-v2-detail-tab-state

  SongSelectV2: Read/write last active tab in details area from/to local configuration

  Dean Herbert · 2025-05-30 14:37:54 +09:00
  efbdd3fffb
• Inflate leaderboard scores input area to avoid misclicks in gaps
  Dean Herbert · 2025-05-30 14:31:26 +09:00
  574b0eb686
• Add gradient fade when scrolling leaderboard
  Dean Herbert · 2025-05-30 14:29:49 +09:00
  6773755a5d
• Tidy up star difficulty transfer logic

  Was going to try and fix the stuttering/glitching when changing mods /
  adjusting star rating but it's for another day.
  
  This has no functional change, just code quality.

  Dean Herbert · 2025-05-30 14:29:42 +09:00
  9721b0a94c
• Update placeholder design slightly
  Dean Herbert · 2025-05-30 14:29:02 +09:00
  1402feba56
• Allow resetting search terms from placeholder
  Dean Herbert · 2025-05-30 14:29:02 +09:00
  64328ffc27
• Add gradient behind carousel to make placeholder easier to see
  Dean Herbert · 2025-05-30 14:29:01 +09:00
  d179d330bc
• Change song select v2 colour scheme to Blue
  Dean Herbert · 2025-05-30 14:29:01 +09:00
  5943bd4388
• Adjust ruleset icon sizing and padding
  Dean Herbert · 2025-05-30 14:29:01 +09:00
  53d3817e79
• Move local rank out to the left and further fine-tune metrics
  Dean Herbert · 2025-05-30 14:29:01 +09:00
  31e46ae0d9
• Fix key count potentially not updating after de-pool
  Dean Herbert · 2025-05-30 14:29:00 +09:00
  11878dde5c
• Fix back-to-front ordering of elements on PanelBeatmap
  Dean Herbert · 2025-05-30 14:29:00 +09:00
  afd0f39cc2
• Adjust filter control copy and spacing to fit text better
  Dean Herbert · 2025-05-30 02:20:57 +09:00
  b1a11061f4
• Hide options popover when mods overlay is shown
  Dean Herbert · 2025-05-30 02:20:39 +09:00
  df51bb2fa6
• Separate active standalone beatmap panels from the carousel vertically
  Dean Herbert · 2025-05-30 02:20:39 +09:00
  6fbc9e4580
• Adjust panel x offsets to match user expectations better
  Dean Herbert · 2025-05-30 02:20:39 +09:00
  02610c5afe
• Add triangles to beatmap difficulty panels and move accent layer local
  Dean Herbert · 2025-05-30 00:49:29 +09:00
  23f2c6d1fe
• Merge pull request #33283 from peppy/last-played-split-out

  Split out difficulties when sorting and grouping by "last played"

  Bartłomiej Dach · 2025-05-29 14:48:48 +02:00
  d29ecbe76e
• Merge pull request #33317 from peppy/song-select-v2-polish

  SongSelectV2: Various polish

  Bartłomiej Dach · 2025-05-29 14:30:47 +02:00
  a4545d56db
• SongSelectV2: Read/write last active tab in details area from/to local configuration
  Bartłomiej Dach · 2025-05-29 14:16:41 +02:00
  8a3d979032
• Merge pull request #33320 from bdach/song-select-v2-difficulty-display-stuff

  SongSelectV2: fix title wedge difficulty display tooltip not displaying correct changes to difficulty

  Dean Herbert · 2025-05-29 20:52:46 +09:00
  a017c8155b
• Fix oversight in date handling
  Dean Herbert · 2025-05-29 20:50:50 +09:00
  66e2c5c287
• Also apply realtime colour updates to icon
  Dean Herbert · 2025-05-29 20:43:04 +09:00
  27ce549606
• Add very slight background dim
  Dean Herbert · 2025-05-29 20:31:48 +09:00
  4f38f9f486
• Highlight beatmap set header when expanded as if it was selected
  Dean Herbert · 2025-05-29 20:20:09 +09:00
  69b047d72b
• Use realtime difficulty colouring for other relevant areas
  Dean Herbert · 2025-05-29 20:19:54 +09:00
  035541bab2