34521 Commits

Author	SHA1	Message	Date
Dean Herbert	cc8a71b65d	Re-query file existence before failing a recursive copy operation during migration	2022-08-01 17:01:19 +09:00
Dean Herbert	59210ecc9d	Revert "Fix migration failing on single file copy failure" ... This reverts commit fc8835d43a.	2022-08-01 16:57:50 +09:00
Dean Herbert	fc8835d43a	Fix migration failing on single file copy failure ... No longer throw if copying of single files fails during data migration. Aiming to fix https://github.com/ppy/osu/runs/7601653833?check_suite_focus=true, which could also affect end users. I've left a limit before an exception is still thrown, to handle cases like the user running out of disk space (where we probably *do* want to bail, so they can continue to use their still-intact original storage location). If this isn't seen as a good direction, an alternative will be to make the migration code aware of the structure of the temporary files created by `Storage` (but doesn't guarantee this will cover all cases of such temporary files – there could for isntance be metadata files created by the host operating system). Another option would be to mark those temporary files as hidden and skip any hidden files during iteration.	2022-08-01 15:02:39 +09:00
Dean Herbert	8ee4f1e60b	Merge pull request #19510 from bdach/mod-overlay/presets-persistence ... Add persistence of mod presets to realm	2022-08-01 14:43:52 +09:00
Bartłomiej Dach	85f77abee1	Fix code quality inspection about ambiguous equality	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	345f103119	Migrate mod preset column to use realm	2022-07-31 23:53:45 +02:00
notmyname	fa3b9ee32f	remove unneded guard	2022-07-31 23:42:20 +02:00
Bartłomiej Dach	cbabc4886c	Convert ModPreset to realm object	2022-07-31 22:10:15 +02:00
notmyname	57b43e0065	Stop capturing arrow keys on Playlist	2022-07-31 19:12:29 +02:00
Dean Herbert	93b783d9ea	Fix previous skins not loading due to namespace changes	2022-07-31 03:25:38 +09:00
Dean Herbert	6ad86ce5b7	Run collection import process asynchronously ... Actually required to avoid deadlocking..	2022-07-31 01:06:57 +09:00
Dean Herbert	80ffa2cf20	Move collection database rather than deleting post-migration for safety	2022-07-31 00:54:00 +09:00
Dean Herbert	8e06d55960	Fix collection migration incorrectly running asynchronously	2022-07-31 00:53:39 +09:00
Susko3	38a8b9cf0a	Add battery info for desktop platforms	2022-07-30 14:26:19 +02:00
Dean Herbert	43e612f6d4	Merge pull request #19455 from peppy/confirm-playlist-discard ... Add confirmation dialog when about to discard a playlist	2022-07-30 19:17:49 +09:00
Salman Ahmed	8ca8484f0e	Fix failing tests	2022-07-30 11:49:33 +03:00
Salman Ahmed	369ab10212	Fix exit confirmation dialog not blocking all exit cases	2022-07-30 11:00:31 +03:00
Dean Herbert	eea211eb45	Update framework	2022-07-30 02:46:39 +09:00
Salman Ahmed	2500e5c533	Merge branch 'master' into fix-summary-kiai-ranges	2022-07-29 19:38:28 +03:00
Dean Herbert	acf9ad1429	Apply nullability to EffectPointVisualisation	2022-07-29 23:26:38 +09:00
Salman Ahmed	3bc1774c87	Merge branch 'master' into pie-chart-progress	2022-07-29 16:54:59 +03:00
Salman Ahmed	905bbdc8ee	Remove caching of GameplayClockContainer in favour of GameplayClock ... Also fixes `SongProgress` being displayed in skin editor on non-gameplay screens, due to `GameplayClock` not marked as a required dependency.	2022-07-29 16:45:29 +03:00
Salman Ahmed	3f72e76348	Expose StartTime from gameplay clock	2022-07-29 16:18:05 +03:00
Dean Herbert	8f1e3b0154	Fix editor summary timeline not responding to kiai changes correctly	2022-07-29 19:31:49 +09:00
Dan Balasescu	70420e6238	Merge pull request #19440 from peppy/bypass-local-metadata-cache ... Fix beatmap updater potentially using outdated local metadata	2022-07-29 17:33:53 +09:00
Dean Herbert	9d457535c6	Add confirmation dialog when about to discard a playlist ... The confirmation will only show if items have been added to the playlist. Closes https://github.com/ppy/osu/issues/19444.	2022-07-29 17:11:37 +09:00
Dean Herbert	eb92c35335	Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering ... Move spectator begin/end playing to SubmittingPlayer	2022-07-29 16:09:50 +09:00
Dean Herbert	cb52b696ed	Merge branch 'master' into bypass-local-metadata-cache	2022-07-29 16:05:54 +09:00
Dean Herbert	2ff6ff06d3	Use tuple to better explain new bool parameter	2022-07-29 16:05:41 +09:00
Dan Balasescu	aaa6f963bd	Fix potential test failures due to Setup/SetUpSteps ordering	2022-07-29 15:27:39 +09:00
Dean Herbert	fd09155990	Revert blocking call when sending spectator frames ... There are a lot of these requests, and we don't really care about waiting on them to finish sending. This may have negatively affected send performance for users with very high latency. Reverts part of 0533249d11. Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.	2022-07-29 12:24:54 +09:00
Dean Herbert	3005ff1b9f	Merge branch 'master' into pie-chart-progress	2022-07-28 22:19:27 +09:00
Dan Balasescu	a59d7f6710	Merge branch 'master' into collections-track-beatmap-updates	2022-07-28 22:05:34 +09:00
Dan Balasescu	aa03df905f	Merge pull request #19441 from peppy/test-working-beatmap-unfuck ... Reduce calls to `LoadTrack` by implicitly running on test/dummy classes	2022-07-28 22:05:25 +09:00
Dan Balasescu	11e0022fad	Merge branch 'master' into realm-collections	2022-07-28 21:00:08 +09:00
Dan Balasescu	ce694123eb	Move spectator begin/end playing to SubmittingPlayer	2022-07-28 20:44:04 +09:00
Dean Herbert	4b140e1f5a	Adjust metrics	2022-07-28 18:50:46 +09:00
Dean Herbert	86c2b7e449	Apply nullability to DefaultSongProgress and clean up more stuff	2022-07-28 18:37:17 +09:00
Dean Herbert	ea027eda46	Move initial show to base implementation and add transition for legacy version	2022-07-28 18:29:49 +09:00
Dean Herbert	bfa026879c	Remove pointless null check	2022-07-28 18:28:03 +09:00
Dean Herbert	d5e5761892	Fix DefaultSongProgress graph not resetting if time is in intro	2022-07-28 18:25:24 +09:00
Dean Herbert	7108553883	Tidy up various things everywhere	2022-07-28 18:25:14 +09:00
Dean Herbert	a21aee4e9c	Reduce calls to LoadTrack by implicitly running on test/dummy classes	2022-07-28 18:11:40 +09:00
Dean Herbert	628a30193f	Remove incorrect TrackLoaded override from TestWorkingBeatmap	2022-07-28 17:49:17 +09:00
Dan Balasescu	1da9830145	Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store ... Remove unused `RulesetStore` from `BeatmapManager` constructor	2022-07-28 17:46:12 +09:00
Dean Herbert	8cb4fb35e0	Rename parameter to read better (and still use local cache if no online API is available)	2022-07-28 17:08:59 +09:00
Dean Herbert	c35da62224	Add flow for bypassing local cache lookups when refreshing beatmap metadata	2022-07-28 16:33:51 +09:00
Dean Herbert	17a3fd30fb	Move scheduler from OnlineLookupQueue to BeatmapUpdater	2022-07-28 16:32:22 +09:00
Nitrous	0d36907cad	apply code quality fixes	2022-07-28 15:30:45 +08:00
Nitrous	bca3994d91	set FirstHitTime and LastHitTime once	2022-07-28 15:25:12 +08:00