Dean Herbert
87570ed238
Fix incorrect slider stacking on very old beatmaps
...
Closes https://github.com/ppy/osu/issues/24185
The stable code has had a bug in this logic forever. So we'll need to
reimplement the bug.
Basically, sliders have to have `UpdateCalculations` run in order to
have a correct `Position2` and `EndTime`, but this wasn't being called
in the inner loop before use of `EndTime` at
1531237b63/osu
!/GameplayElements/HitObjectManager.cs#L1813.
To fix this, we use `StartTime` in the inner loop to reproduce the bug.
2023-07-12 17:35:03 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
alex
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
Dean Herbert
709ec1404f
Centralise End/StartTime retrieval to extension method
2019-11-25 19:09:14 +09:00
smoogipoo
bc3a340286
Fix incorrect path position being used for old stacking algorithm
2019-08-07 19:35:39 +09:00
smoogipoo
42de5934f6
Fix incorrect hitobject indices
2019-08-07 19:33:35 +09:00
Arphox
07e17518e9
Fix all "Maintainability" CodeFactor issues
2019-06-11 10:28:16 +02:00
Dean Herbert
612db31c38
Apply newline additions
2019-04-01 12:16:32 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
smoogipoo
b57c1af084
Only update stacking if there are hitobjects
2019-01-07 18:15:44 +09:00
smoogipoo
c6c22b352f
More verbose exceptions
2019-01-07 18:13:40 +09:00
smoogipoo
351ab6e9bd
Shortcut O(n^2) calculation
2019-01-07 18:01:44 +09:00
smoogipoo
1c5ab6a906
Implement stacking by index
2019-01-07 18:00:59 +09:00
smoogipoo
72c8ae8705
Port the old stacking algorithm
2018-10-12 16:47:27 +09:00
smoogipoo
d14dad64e8
Fix hitobject stacking being applied too early
2018-08-21 16:01:28 +09:00
smoogipoo
557a2ee39d
Add more comprehensive tests
2018-08-17 10:04:00 +09:00
Dean Herbert
831b11ff97
Remove unnecessary null checks
2018-07-02 14:28:56 +09:00
Dean Herbert
c04bfb96e1
Merge remote-tracking branch 'upstream/master' into UselessToucan-null_coalescing_quickfix
2018-07-02 14:26:41 +09:00
smoogipoo
756cabd5d0
Add a preprocess method to BeatmapProcessor
2018-06-29 12:45:48 +09:00
Roman Kapustin
2a72062c33
Perhaps the '??' operator works in a different way than it was expected. Its priority is lower than priority of other operators in its left part.
2018-06-26 00:53:31 +03:00
smoogipoo
03a5df84c6
Initial rework of beatmap conversion process
2018-04-19 22:04:12 +09:00
Dean Herbert
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
Dean Herbert
c38c26eacb
Move combo index processing to BeatmapProcessor
2018-03-20 15:57:43 +09:00
Dean Herbert
e43de68ad3
Move colour parsing to LegacyDecoder
2018-03-13 19:13:50 +09:00
Aergwyn
52c4d22c41
review changes
...
- use doubles instead of floats
- simplify logic
2018-01-24 09:44:50 +01:00
Dean Herbert
d0881e443b
Merge remote-tracking branch 'upstream/master' into approach-rate
2018-01-12 18:05:16 +09:00
Dan Balasescu
9c602f8770
Merge branch 'master' into drawable-fruit-improvements
2018-01-09 22:06:16 +09:00
Dean Herbert
37d393bca0
Update licence headers
2018-01-05 20:21:19 +09:00
Dean Herbert
31865b4d96
Rename conflicting variable
2018-01-03 15:12:27 +09:00
Shawdooow
1df79c2f1b
Move stackThreshold up where possible
2018-01-01 10:30:09 -05:00
Shawdooow
064758b96d
fixes
2017-12-31 11:30:58 -05:00
Shawdooow
3ba5dce052
new Approach to approach rate
2017-12-31 11:15:14 -05:00
Dean Herbert
6d3d485565
And then everything became one
2017-09-19 16:06:58 +09:00
Dean Herbert
25f2a102f4
Fix CI issue
2017-09-13 20:35:44 +09:00
Dean Herbert
fb7740a3ab
Update all dependencies in line with framework
2017-09-13 20:25:40 +09:00
Dean Herbert
fbd26a1d5e
Mode -> Ruleset.
2017-04-18 16:05:58 +09:00