Bartłomiej Dach
|
c40f887492
|
Remove unnecessary local variable
|
2021-11-06 15:20:29 +01:00 |
|
Salman Ahmed
|
51e7b9950e
|
Define local current bindable to bind value change instead
|
2021-11-05 18:07:14 +03:00 |
|
Salman Ahmed
|
f013a1e37f
|
Move CreateContent() to BDL
|
2021-11-05 10:13:42 +03:00 |
|
Salman Ahmed
|
3a3ec1436b
|
Re-enable possible null refernece exception inspections and move code
|
2021-11-05 09:14:50 +03:00 |
|
Salman Ahmed
|
b723975767
|
Replace pragma with add/remove => throw
|
2021-11-05 09:10:38 +03:00 |
|
Salman Ahmed
|
f528488aa2
|
Mark as non-null and move current bind to BDL instead
|
2021-11-05 05:42:19 +03:00 |
|
Salman Ahmed
|
2764ad90ea
|
Merge branch 'master' into fix-more-null
|
2021-11-05 05:14:22 +03:00 |
|
Salman Ahmed
|
4245af28e1
|
Disable other false-positive null inspections with comment
|
2021-11-05 04:50:58 +03:00 |
|
Dean Herbert
|
fc59e20c14
|
Merge pull request #15478 from bdach/fix-labelled-drawable-descriptions
|
2021-11-05 10:13:11 +09:00 |
|
Salman Ahmed
|
36d99a2e34
|
Move action to private named method to avoid null inspection
|
2021-11-05 03:51:08 +03:00 |
|
Salman Ahmed
|
6197ef426d
|
Disable another "code heurstically unreachable" with comment
|
2021-11-05 03:50:17 +03:00 |
|
Salman Ahmed
|
af6ae1cce5
|
Remove hacky code with explicit pragma disable
|
2021-11-05 03:49:35 +03:00 |
|
Bartłomiej Dach
|
4c8d6a77be
|
Fix labelled drawable descriptions not showing
|
2021-11-04 21:44:08 +01:00 |
|
Bartłomiej Dach
|
9246adc349
|
Add failing test coverage for labelled drawable description visible
|
2021-11-04 21:43:20 +01:00 |
|
Salman Ahmed
|
78ed77805f
|
Merge pull request #15468 from smoogipoo/upgrade-nvika
Use official nvika package again
|
2021-11-04 15:16:03 +03:00 |
|
Salman Ahmed
|
9846596c02
|
Merge branch 'master' into upgrade-nvika
|
2021-11-04 14:48:42 +03:00 |
|
Dan Balasescu
|
66509264ff
|
Merge pull request #15467 from peppy/update-framework
Update framework
|
2021-11-04 20:19:56 +09:00 |
|
Salman Ahmed
|
4b46833ee9
|
Merge branch 'master' into upgrade-nvika
|
2021-11-04 13:53:30 +03:00 |
|
Salman Ahmed
|
aa2711e6ec
|
Merge branch 'master' into update-framework
|
2021-11-04 13:51:57 +03:00 |
|
Dan Balasescu
|
f12a2c7767
|
Merge pull request #15458 from peppy/beatmap-refactor/playlist-use-api-beatmap-extended
Refactor `PlaylistItem` to allow `Beatmap` to be an interfaced type
|
2021-11-04 19:23:33 +09:00 |
|
smoogipoo
|
30635fb476
|
Use official nvika package again
|
2021-11-04 19:19:00 +09:00 |
|
Dean Herbert
|
28e9b9a25f
|
Update framework
|
2021-11-04 19:01:39 +09:00 |
|
Dan Balasescu
|
45dcf187b9
|
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended
|
2021-11-04 18:59:04 +09:00 |
|
Dean Herbert
|
df3c3a32ce
|
Fix unintentionally broken background update logic
|
2021-11-04 18:07:39 +09:00 |
|
Dan Balasescu
|
388c074c15
|
Merge pull request #15464 from peppy/fix-crash-on-gameplay
Fix crash on gameplay startup if beatmap has no background
|
2021-11-04 18:07:10 +09:00 |
|
Dean Herbert
|
b80c02b757
|
Fix crash on gameplay startup if beatmap has no background
|
2021-11-04 17:24:40 +09:00 |
|
Dean Herbert
|
5a078da4d9
|
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
|
2021-11-04 16:50:14 +09:00 |
|
Dean Herbert
|
c820d445ad
|
Merge pull request #15461 from peppy/fix-more-computationally-expensive
Fix a few more "maybe null" inspections
|
2021-11-04 16:49:38 +09:00 |
|
Dean Herbert
|
e50c961185
|
Merge pull request #15312 from jaswon/editor-context-menu-on-select
Fix editor context menu requiring two right-clicks to display
|
2021-11-04 16:49:19 +09:00 |
|
Dean Herbert
|
a9eef4199a
|
Merge pull request #15460 from smoogipoo/upgrade-nvika
Upgrade to nvika 1.0.4
|
2021-11-04 16:47:23 +09:00 |
|
Dean Herbert
|
317506d4d7
|
Fix a few more "maybe null" inspections
|
2021-11-04 16:11:23 +09:00 |
|
Dan Balasescu
|
63cfa69bd1
|
Merge branch 'master' into upgrade-nvika
|
2021-11-04 16:10:23 +09:00 |
|
smoogipoo
|
0c14d8af23
|
Upgrade to nvika 1.0.4
|
2021-11-04 16:03:59 +09:00 |
|
Dean Herbert
|
09701d0af1
|
Use explicit primitive type specification
|
2021-11-04 16:02:37 +09:00 |
|
Dean Herbert
|
0f4f1349db
|
Merge branch 'master' into editor-context-menu-on-select
|
2021-11-04 15:59:06 +09:00 |
|
Dan Balasescu
|
222c3e552b
|
Merge pull request #15456 from peppy/beatmap-refactor/beatmap-metadata-nullable-enable
Enable nullable support on `BeatmapMetadata`
|
2021-11-04 15:47:18 +09:00 |
|
Dean Herbert
|
84d36cbae7
|
Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
|
2021-11-04 15:22:33 +09:00 |
|
Dean Herbert
|
e43d91ad5d
|
Fix another case of incorrect null checking in editor verification processing
|
2021-11-04 15:18:10 +09:00 |
|
Dean Herbert
|
09f9731d74
|
Add temporary disable of failing r# inspection
|
2021-11-04 15:09:04 +09:00 |
|
Dean Herbert
|
d1e6d1cb98
|
Update some other missed incorrect null/empty usages
|
2021-11-04 14:50:43 +09:00 |
|
Dean Herbert
|
a49366ff84
|
Remove nullability from IBeatmapInfo.Metadata
|
2021-11-04 14:28:39 +09:00 |
|
Dean Herbert
|
1e73b09e57
|
Fix another couple of cases of incorrect string null/empty checking
|
2021-11-04 14:22:28 +09:00 |
|
Dean Herbert
|
41854f2e16
|
Fix incorrect check on AudioFile presence
|
2021-11-04 14:02:09 +09:00 |
|
Dean Herbert
|
67d9590a79
|
Fix new inspections
|
2021-11-04 14:02:09 +09:00 |
|
Dean Herbert
|
0df339d0b8
|
Fix incorrect invocation of download method in SoloSpectator
|
2021-11-04 13:50:04 +09:00 |
|
Dean Herbert
|
0ab50f1cc9
|
Add inline comment explaining why we are manually populating beatmap.BeatmapSet
|
2021-11-04 13:45:59 +09:00 |
|
Dean Herbert
|
9f9c960fe3
|
Revert PlaylistItem.APIBeatmap to be private
|
2021-11-04 13:36:32 +09:00 |
|
Dean Herbert
|
05f1fd4bc9
|
Remove unnecessary properties and parameters
|
2021-11-04 13:33:54 +09:00 |
|
Dean Herbert
|
3453160a8b
|
Change PlaylistItem.Beatmap to be an IBeatmapInfo
|
2021-11-04 13:16:56 +09:00 |
|
Dean Herbert
|
772b6c6dcd
|
Enable nullable support on BeatmapMetadata
|
2021-11-04 12:11:42 +09:00 |
|