73781 Commits

This Branch

This Branch

All Branches

• Merge pull request #33491 from bdach/fix-replays

  Fix replays being misrecorded if an action is pressed and released in one update frame

  Dean Herbert · 2025-06-06 16:35:55 +09:00
  c180983393
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Add failing test
  Bartłomiej Dach · 2025-06-06 09:08:26 +02:00
  f577cea715
• Merge pull request #33488 from bdach/participants-list-flags-broke

  Fix user country flags no longer showing on multiplayer participants list

  Dean Herbert · 2025-06-06 15:47:09 +09:00
  4d704d7018
• Merge pull request #33439 from bdach/mobile-does-not-exist

  Hack around hold-for-right-click mobile thing not allowing to hold to access song select v2 in main menu

  Dean Herbert · 2025-06-06 15:06:24 +09:00
  c2319f419c
• Hack around hold-for-right-click mobile thing not allowing to hold to access song select v2 in main menu

  This is terrible but I sincerely believe that anything else trying to do
  this "properly" would be as terrible if not more.
  
  - You can try to handle touch events in `MainMenu` but then you'd have
    to awkwardly still manually hand them off to mouse handlers of the
    logo / menu button in a weird way for them to do what they're supposed
    to be doing. So any fix here would likely be smeared across `OsuLogo`
    and `MainMenuButton` anyway.
  
  - The logic in
    https://github.com/ppy/osu/blob/278a372a907c22f04fe28289c305ef47d5bcef45/osu.Game/Screens/Menu/MainMenu.cs#L517-L520
    fundamentally doesn't work with raw touch events because it doesn't
    check for active touches (easy part) and because drawables do not
    become "hovered" in the input manager from being touched (hard part)
  
  I'm not willing to spend any more time on this.

  Bartłomiej Dach · 2025-06-06 07:56:22 +02:00
  3931ae3499
• Fix user country flags no longer showing on multiplayer participants list
  Bartłomiej Dach · 2025-06-06 07:42:10 +02:00
  51a758d3f6
• Merge pull request #33450 from bdach/freestyle-consistent-compatibility

  Disallow selected mods from being valid for freestyle as required mods due to them not being consistently compatible with other mods across rulesets

  Dan Balasescu · 2025-06-05 23:49:00 +09:00
  2025.605.3 f59c248595
• Merge pull request #33451 from smoogipoo/fix-extreme-leaderboard-thrashing

  Fix extreme Drawable thrashing on initial leaderboard population

  Dean Herbert · 2025-06-05 23:44:15 +09:00
  c2196ae44c
• Fix extreme Drawable thrashing on initial leaderboard population
  Dan Balasescu · 2025-06-05 23:01:31 +09:00
  218d8290cb
• Adjust test cases to pass
  Bartłomiej Dach · 2025-06-05 15:01:26 +02:00
  e3259f7a7f
• Disallow selected mods from being valid for freestyle as required mods due to them not being consistently compatible with other mods across rulesets

  Closes https://github.com/ppy/osu/issues/33444.
  
  The issue here is that for a set of required mods to make sense in the
  context of a freestyle playlist item, it must be consistently either
  valid or invalid *as a combination* across all four default rulesets,
  because freestyle also permits changing ruleset. There are two
  pertinent cases here:
  
  - Flashlight and Hidden are compatible in osu!, taiko, and catch, but
    not compatible in mania. In this case I've disallowed both mods
    because of symmetry, basically - I don't see one "better mod" to
    disallow here.
  
  - Accuracy Challenge and Easy are incompatible in osu!, catch, and mania
    (because the mod gives extra lives) there, but *compatible* in taiko,
    where it does not. In this case I've disallowed Accuracy Challenge
    only, because I find its value in being forced on a freestyle room
    to be much smaller than Easy's.
  
  In the large scale of things I don't see this being very important
  because my view is that 99% of the use case of required mods in
  freestyle is going to be changing the track speed. So I don't think
  anyone is going to care about this going away - but we can reassess if
  I'm proven wrong.

  Bartłomiej Dach · 2025-06-05 15:00:54 +02:00
  05496111d6
• Add failing test
  Bartłomiej Dach · 2025-06-05 14:41:57 +02:00
  e335704c83
• Merge pull request #33418 from minetoblend/feature/ssv2-animated-ghost

  SongSelectV2: Animate placeholder ghost

  Dean Herbert · 2025-06-05 16:12:49 +09:00
  2025.605.2 2025.605.1 278a372a90
• Merge pull request #33424 from peppy/song-select-v2-debounce-leaderboard-load

  SongSelectV2: Debounce leaderboard load operations

  Dean Herbert · 2025-06-05 16:12:24 +09:00
  d660905c17
• Adjust keyboard selection animation and opacity slightly
  Dean Herbert · 2025-06-05 16:10:21 +09:00
  b106daabde
• Add beat synced flashing to song select v2 panels
  Dean Herbert · 2025-06-05 16:03:02 +09:00
  39e050ba4b
• Enable nuget uploads and delete appveyor workflows
  Dan Balasescu · 2025-06-05 15:52:38 +09:00
  7145acc73f
• No symbols for templates package
  Dan Balasescu · 2025-06-05 15:46:05 +09:00
  4b92e338d5
• Add GHA deploy workflow
  Dan Balasescu · 2025-06-05 15:41:10 +09:00
  b6c4a713d3
• Debounce leaderboard load operations

  This avoids needless web requests / server load, but also improves the
  placeholder display. It used to update during ruleset changes three (or
  more) times since it had no debounce and was reacting to multiple
  changes. This is no longer the case.

  Dean Herbert · 2025-06-05 15:31:51 +09:00
  0c2fc5c74f
• Merge pull request #33420 from peppy/song-select-v2-hold-for-entry

  Change method of accessing song select v2 to hold

  Bartłomiej Dach · 2025-06-05 08:15:29 +02:00
  38550c25d2
• Merge pull request #33419 from peppy/song-select-v2-fix-edit-crash

  SongSelectV2: Fix crash when returning to song select from editor

  Bartłomiej Dach · 2025-06-05 08:08:04 +02:00
  0ac8759471
• Adjust background fade for placeholder to run faster
  Dean Herbert · 2025-06-05 14:55:18 +09:00
  64d9868ddf
• Update resources
  Dean Herbert · 2025-06-05 14:49:35 +09:00
  08f4e6512e
• Merge pull request #33402 from bdach/preview-point-validity

  Fix track not looping if specified preview point exceeds duration of track

  Dan Balasescu · 2025-06-05 13:59:26 +09:00
  cf297ae743
• Merge pull request #33414 from bdach/song-select-v2-fix-sheared-triangles

  SongSelectV2: Fix triangles being sheared on leaderboard panels

  Dean Herbert · 2025-06-05 13:55:51 +09:00
  16ab32b456
• Fix heights of title wedge sections to avoid weirdness when showing placeholder
  Dean Herbert · 2025-06-05 04:18:55 +09:00
  db7afd0e21
• Merge branch 'master' into feature/ssv2-animated-ghost
  maarvin · 2025-06-04 21:15:24 +02:00
  14cd6eac87
• Fix tiny stats showing when larger ones still could
  Dean Herbert · 2025-06-05 04:08:23 +09:00
  2082a31a69
• Change method of accessing song select v2 to hold
  Dean Herbert · 2025-06-05 04:00:47 +09:00
  63d52de1a7
• Fix beatmap changes handling when song select is not active
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  e35d0f8953
• Add test coverage of editor flow from song select
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  bb49bb5e23
• Add back more song select navigation tests
  Dean Herbert · 2025-06-05 03:49:00 +09:00
  118583bf21
• Fix incorrect operation order for calculating shader time uniform
  marvin · 2025-06-04 20:43:01 +02:00
  1c32b5364f
• Extract animation duration property
  marvin · 2025-06-04 20:23:54 +02:00
  24e102066b
• Merge pull request #33413 from bdach/update-framework

  Update framework

  Dean Herbert · 2025-06-05 03:15:27 +09:00
  6d5bf22a71
• Add disposal logic in ghost drawnode
  marvin · 2025-06-04 20:03:50 +02:00
  7b7e57543c
• Add xmldoc
  marvin · 2025-06-04 20:03:40 +02:00
  96db7b3af6
• Change ghost animation to up-down movement
  marvin · 2025-06-04 19:59:52 +02:00
  7f618b1dc7
• Use ghost icon in NoResultsPlaceholder
  marvin · 2025-06-04 19:58:55 +02:00
  8d1702fbac
• Add ghost drawable
  marvin · 2025-06-04 19:58:04 +02:00
  7ecf81d3a0
• Merge pull request #33416 from peppy/song-select-v2-fix-selection-change
  Bartłomiej Dach · 2025-06-04 19:48:59 +02:00
  695f925b66
• Merge pull request #33391 from smoogipoo/no-cleanup-test-trackstore

  Attempt to fix flaky tests by removing finaliser

  Bartłomiej Dach · 2025-06-04 14:29:55 +02:00
  1d1ade48d6
• SongSelectV2: Fix incorrect selection change when filtered down to one set
  Dean Herbert · 2025-06-04 21:19:51 +09:00
  f52fabbb0c
• Add failing test showing recommended selection occurring on already selected set
  Dean Herbert · 2025-06-04 21:19:51 +09:00
  7e922763c1
• Merge pull request #33390 from peppy/song-select-v2-ensure-valid-selection

  SongSelectV2: Fix being able to reach gameplay with invalid ruleset selection

  Dean Herbert · 2025-06-04 21:09:47 +09:00
  c8b7ab4f28
• Fix cursor test
  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  68795255ee
• Update framework

  Contains a native libs / BASS rollback due to
  https://github.com/ppy/osu/discussions/33260.
  
  - Reopens https://github.com/ppy/osu/issues/31702.
  - Reopens https://github.com/ppy/osu/issues/26879.

  Bartłomiej Dach · 2025-06-04 13:34:21 +02:00
  d262b6e88f
• SongSelectV2: Fix triangles being sheared on leaderboard panels
  Bartłomiej Dach · 2025-06-04 13:25:01 +02:00
  136c5c866b