57779 Commits

This Branch

This Branch

All Branches

• Fix toolbar gradient not showing when mouse is hovered over buttons
  Bartłomiej Dach · 2022-12-29 23:03:53 +01:00
  bf975eb48a
• Add failing assertion
  Bartłomiej Dach · 2022-12-29 23:03:50 +01:00
  f7febdac5e
• Merge pull request #21886 from BlauFx/add_linux_hardlink

  Add hardlink support for Linux & macOS

  Bartłomiej Dach · 2022-12-29 17:03:16 +01:00
  b4e748d97f
• Fix incorrect hard link validity check in stable import screen
  Dean Herbert · 2022-12-29 23:18:12 +08:00
  ccf713c885
• Also support hard links on macOS
  Dean Herbert · 2022-12-29 22:35:13 +08:00
  0fcf10e10a
• Merge branch 'master' into add_linux_hardlink
  Dean Herbert · 2022-12-29 21:29:57 +08:00
  f9f6918fc3
• Merge pull request #21921 from bdach/fix-toolbar-hover-through

  Fix hover propagating through toolbar buttons

  Dean Herbert · 2022-12-29 21:03:42 +08:00
  1bebfe56f2
• Fix hover propagating through toolbar buttons

  Closes #21920.
  
  Weirdly enough this was semeingly fixed once before in ancient times in
  3891f467a3, but then unfixed again in
  566e09083f. The second change is no longer
  needed since the toolbar became opaque in #9447.

  Bartłomiej Dach · 2022-12-29 13:19:14 +01:00
  c5f7da9a4e
• Add failing test coverage
  Bartłomiej Dach · 2022-12-29 13:17:39 +01:00
  cacc23204d
• Disable naming rule inspection on struct stat definition
  Bartłomiej Dach · 2022-12-28 22:38:42 +01:00
  74bc5d4666
• Fix broken spacing
  Bartłomiej Dach · 2022-12-28 22:24:21 +01:00
  10c11e974d
• Fix broken condition
  Bartłomiej Dach · 2022-12-28 22:24:18 +01:00
  49b0ec9ddb
• Implement GetFileLinkCount() for Linux
  Bartłomiej Dach · 2022-12-28 22:14:56 +01:00
  8d79fa93ac
• Change warning message about file duplication

  - It was being glued in an ugly way that would have prevented sanely
    localising it.
  
  - Even on Linux, the filesystem (whichever one the user has chosen out
    of the multitude available) still needs to support hard links for them
    to have a chance of working.

  Bartłomiej Dach · 2022-12-28 22:04:08 +01:00
  d4b3965967
• Rename and xmldoc hard link creation method
  Bartłomiej Dach · 2022-12-28 22:04:05 +01:00
  04d4b4a6ce
• Use switch statement in AttemptHardLink()
  Bartłomiej Dach · 2022-12-28 21:20:49 +01:00
  cadd487c75
• Revert inlining of hard link creation into condition

  Just feels bad. Mixing data access with actual underlying logic.

  Bartłomiej Dach · 2022-12-28 21:19:28 +01:00
  2c346eae0d
• Change name of variable
  BlauFx · 2022-12-28 15:02:44 +01:00
  d63be3ff17
• Remove unnecessary directive
  BlauFx · 2022-12-28 14:40:32 +01:00
  c6da7248ba
• Move duplicated code into its own method
  BlauFx · 2022-12-28 14:34:27 +01:00
  53bca947d1
• Mention the filesystem should be NTFS on Windows
  BlauFx · 2022-12-28 14:33:38 +01:00
  f32564652b
• Fix formatiing
  BlauFx · 2022-12-28 14:06:50 +01:00
  5c5e84f931
• Merge pull request #21871 from bdach/solo-statistics-watcher-reliability

  Improve reliability of solo statistics watcher

  Dean Herbert · 2022-12-28 21:05:38 +08:00
  2022.1228.0 ea8beffa61
• Remove blank line
  BlauFx · 2022-12-28 13:58:52 +01:00
  16165b1f67
• Merge pull request #21854 from peppy/fix-website-root

  Fix `osu.ppy.sh` links no longer opening in-game

  Bartłomiej Dach · 2022-12-28 13:43:24 +01:00
  e4c060fc3a
• Add hardlink support for Linux
  BlauFx · 2022-12-28 13:32:49 +01:00
  b2aa2e1602
• Merge pull request #21878 from bdach/android-version-spec

  Adjust Android package versioning to .NET 6

  Dean Herbert · 2022-12-28 19:39:15 +08:00
  c20c6cdebf
• Merge pull request #21879 from frenzibyte/first-object-visbility-keywords

  Add keywords to ease search of "first object visibility" setting

  Bartłomiej Dach · 2022-12-28 12:15:34 +01:00
  4b71ccf315
• Add keywords to ease search of "first object visibility" setting
  Salman Ahmed · 2022-12-28 13:23:50 +03:00
  b4c5e18da0
• Adjust Android package versioning to .NET 6

  With .NET 6, the way Xamarin package versioning works has changed.
  
  - The `ApplicationVersion` MSBuild property aims to replace
    `android:versionCode` in the manifest.
  - The `ApplicationDisplayVersion` MSBuild property aims to replace
    `android:versionName` in the manifest.
  
  More about this can be read in Xamarin docs:
  
      https://github.com/xamarin/xamarin-android/blob/ec712da8c1ce03f71578e08cafb6a767cdb90cd5/Documentation/guides/OneDotNetSingleProject.md
  
  To this end:
  
  - Manual `version{Code,Name}` specs are removed from
    `AndroidManifest.xml`, as they were preventing MSBuild properties
    from functioning properly.
  - `Version` now defaults to 0.0.0, so that local builds don't appear
    like they were deployed (see `OsuGameBase.IsDeployedBuild`).
  - `ApplicationDisplayVersion` now defaults to `Version`.
    This addresses the Android portion of #21498.
  - `ApplicationVersion` can now be specified by command line,
    but still needs to be supplied manually for version detection to
    work correctly. See `OsuGameAndroid.AssemblyVersion` for more info.
  
  Putting the pieces together, the complete publish command to deploy
  a new build should look something like so:
  
      dotnet publish -f net6.0-android \
                     -r android-arm64 \
                     -c Release \
                     -p:Version=2022.1228.0 \
                     -p:ApplicationVersion=202212280

  Bartłomiej Dach · 2022-12-28 10:36:54 +01:00
  76367444cb
• Allow unsubscribing from solo statistics updates

  This is more of a safety item. To avoid potential duplicate key in
  dictionary errors (and also avoid being slightly memory-leaky), allow
  `SoloStatisticsWatcher` consumers to dispose of the subscriptions they
  take out.

  Bartłomiej Dach · 2022-12-28 08:07:48 +01:00
  3c0b8af8f1
• Convert SoloResultsScreen to NRT
  Bartłomiej Dach · 2022-12-28 07:54:36 +01:00
  04f9a354c3
• Ignore statistics update subscriptions with invalid score ID

  If score submission fails, the score will not receive a correct online
  ID from web, but will still be passed on to the solo statistics watcher
  on the results screen. This could lead to the watcher subscribing to
  changes with score ID equal to the default of -1. If this happened more
  than once, that would cause a crash due to duplicate keys in the
  `callbacks` dictionary.
  
  Closes #21837.

  Bartłomiej Dach · 2022-12-28 07:54:01 +01:00
  a0a26b1e8c
• Fix various failures in initial statistics fetch

  - If the local user is restricted, then attempting to fetch their data
    from the `/users` endpoint would result in an empty response.
  
  - Even if the user was successfully fetched, their `RulesetsStatistics`
    may not be populated (and instead be `null`). Curiously this was not
    picked up by static analysis until the first issue was fixed.
  
  Closes #21839.

  Bartłomiej Dach · 2022-12-28 07:31:36 +01:00
  e9d32fca18
• Fix osu.ppy.sh links no longer opening in-game

  Addresses https://github.com/ppy/osu/discussions/21838.

  Dean Herbert · 2022-12-28 06:42:35 +08:00
  0d78bc2248
• Merge pull request #21819 from bdach/fix-global-ranking-accuracy-display

  Fix incorrect accuracy display on overall ranking view

  Dean Herbert · 2022-12-28 04:47:15 +08:00
  5e8ca11ded
• Fix incorrect accuracy display on overall ranking view
  Bartłomiej Dach · 2022-12-27 19:51:51 +01:00
  e90619244d
• Fix invalid data in test scene
  Bartłomiej Dach · 2022-12-27 19:49:08 +01:00
  e2703bba18
• Merge pull request #21809 from turbedi/split_trimentries

  Use StringSplitOptions.TrimEntries in string.Split() when possible

  Bartłomiej Dach · 2022-12-27 18:42:48 +01:00
  b4a3f872ee
• Merge branch 'master' into split_trimentries
  Bartłomiej Dach · 2022-12-27 18:07:36 +01:00
  ae2058b55e
• Merge pull request #21812 from frenzibyte/fix-publish

  Move system packages version pinning workaround to game project

  Dean Herbert · 2022-12-27 20:31:35 +08:00
  2022.1227.0 080790d352
• Move version pinning of system packages to osu.Game
  Salman Ahmed · 2022-12-27 14:58:18 +03:00
  1a4489edb2
• Merge pull request #21811 from peppy/add-hard-link-faq

  Add link to hard link explanation wiki page

  Dean Herbert · 2022-12-27 18:25:56 +08:00
  9be1689e04
• Add link to hard link explanation wiki page
  Dean Herbert · 2022-12-27 17:56:23 +08:00
  61029b126d
• Merge pull request #21810 from peppy/api-switch

  Use new lazer API endpoint

  Dean Herbert · 2022-12-27 17:56:20 +08:00
  42c1d410b4
• Use new lazer API endpoint

  This is a temporary change to target the new experimental/next deploy.
  The main change that should result from this is having the user profile
  show the pp^next values from the new domain.

  Dean Herbert · 2022-12-27 17:20:40 +08:00
  b3e44f20bc
• Use StringSplitOptions.TrimEntries for string.Split() when possible
  Berkan Diler · 2022-12-27 09:41:58 +01:00
  182f36c434
• Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores

  Only show global rankings on solo results screen when progressing from gameplay

  Dean Herbert · 2022-12-27 16:39:26 +08:00
  df6f2ad0a1
• Merge pull request #21807 from Joehuu/external-link-open-highlight

  Highlight "open" option on external link button context menu

  Dean Herbert · 2022-12-27 16:09:06 +08:00
  38a674cd84
• Highlight "open" option on external link button context menu
  Joseph Madamba · 2022-12-26 20:47:24 -08:00
  777ffcf805