1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-08 12:07:51 +08:00
Commit Graph

57734 Commits

Author SHA1 Message Date
Dean Herbert
e2d68f6ea9
Merge pull request #21686 from bdach/spectator-end-playing-on-completion
Call spectator `EndPlaying()` immediately after score submission
2022-12-18 13:26:47 +09:00
Bartłomiej Dach
fea0895f16
Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
Joseph Madamba
813c351607 Fix breadcrumb tab item click area not extending to background height 2022-12-16 21:44:10 -08:00
Salman Ahmed
4dbc1c3cb0 Manually use Xcode 14.1 2022-12-17 03:30:25 +03:00
Salman Ahmed
d74478ce3b Pin workflow to macOS 12 2022-12-17 03:00:59 +03:00
Salman Ahmed
64e0e6f096
Merge pull request #21667 from bdach/fix-wrong-macos-logs-path
Fix wrong paths to macOS log folder in docs
2022-12-16 19:20:51 +03:00
Salman Ahmed
00bae8fab9 Fix slight mistake in path 2022-12-16 18:44:23 +03:00
Bartłomiej Dach
190e7acd39
Fix wrong paths to macOS log folder in docs
Wrong since 2eb1c60d6e72d8b2c478cf4376470ca614ef3f88.
2022-12-16 16:37:38 +01:00
Dean Herbert
192536643c Fix some more inspections 2022-12-16 20:21:19 +09:00
Dean Herbert
dd9a418549 Fix assembly location lookups 2022-12-16 19:19:59 +09:00
Dean Herbert
de079e08dc Fix incorrect ConfigureAwait call in ImportAsUpdate 2022-12-16 18:54:56 +09:00
Dean Herbert
ba54551313 Merge branch 'master' into guard-url-protocols 2022-12-16 18:23:16 +09:00
Dean Herbert
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
Dean Herbert
965be5123d
Merge pull request #21661 from nekodex/clamp-sfx-panning
Limit SFX panning on results screen
2022-12-16 18:05:40 +09:00
Jamie Taylor
d5b2c7dfe9
Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
Dean Herbert
d6cae991da Update netstandard2.1 references to net6.0 2022-12-16 17:16:13 +09:00
Dean Herbert
e63b544167 Update framework 2022-12-16 17:02:51 +09:00
Dean Herbert
ce408eaac0 Merge branch 'net6-ios' into guard-url-protocols 2022-12-16 17:02:32 +09:00
Dan Balasescu
cbee72897a
Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
Dean Herbert
232f590ba3
Merge pull request #21628 from peppy/go-hard-file-writes
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
Dean Herbert
6b85a123a4
Merge pull request #21646 from peppy/featured-artist-default
Turn on featured artist filter by default and add disclaimer when toggling for the first time
2022-12-16 13:09:03 +09:00
Susko3
0f34d908c7 Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
Salman Ahmed
67787da4cf Suppress MT7091 2022-12-16 00:46:32 +03:00
Salman Ahmed
2c78fed5e4 Update workflows in line with framework changes 2022-12-16 00:22:11 +03:00
Salman Ahmed
d791bc56e7 Remove transitive dependencies 2022-12-16 00:22:11 +03:00
Salman Ahmed
b488421c7a Remove MtouchUseLlvm key for now
I haven't found a way to disable LLVM, and the issue may potentially be
resolved (doesn't occur for me), so we might as well just remove the key
for now.
2022-12-16 00:22:11 +03:00
Salman Ahmed
5fbd4ad3b4 Update usages of SupportsJIT in line with framework changes 2022-12-16 00:22:11 +03:00
Salman Ahmed
660cc72f2a Avoid configuring web proxies on iOS for now 2022-12-16 00:22:11 +03:00
Salman Ahmed
e85975b5f1 Work around JIT compilation error in Realm 2022-12-16 00:22:11 +03:00
Salman Ahmed
c900965a82 Replace Xamarin.Essentials with .NET MAUI Essentials 2022-12-16 00:22:11 +03:00
Salman Ahmed
467e879021 Migrate osu! iOS to .NET 6 and target iOS 13.4 2022-12-16 00:22:11 +03:00
Dean Herbert
9813bc9544 Reword disclaimer and fix translation keys 2022-12-15 22:46:31 +09:00
Dean Herbert
91adf2e80f
Apply the wala-hyphen
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2022-12-15 22:44:47 +09:00
Dean Herbert
57048f0eba Add test coverage of featured artist filter confirmation process 2022-12-15 18:42:58 +09:00
Dean Herbert
d2b98b803d Turn on featured artist filter by default and add disclaimer when toggling for the first time 2022-12-15 18:42:47 +09:00
Dean Herbert
0763b86236 Add more padding around text in dialog popups 2022-12-15 17:32:27 +09:00
Dean Herbert
78bc94d3cb Set featured artists filter to enabled by default 2022-12-15 16:57:39 +09:00
Dean Herbert
a7f3e13946 Fix MultipleSelectionFilter not correctly handling initial selection 2022-12-15 16:56:09 +09:00
Dean Herbert
6bf1477939
Fix some hard links not being created due to missing directory structure
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-15 14:17:28 +09:00
Dean Herbert
60c8ef3fe5
Merge pull request #21637 from smoogipoo/score-encoder-doc
Add description for lazer score version 30000001
2022-12-14 18:49:41 +09:00
Dan Balasescu
fb85eaee95 Add description for lazer score version 30000001 2022-12-14 18:30:33 +09:00
Dean Herbert
50dc76d579
Merge pull request #21618 from smoogipoo/multi-spec-only-local-results
Only show local results in multi-spectator results screen
2022-12-14 14:00:02 +09:00
Dean Herbert
a3c3112f89
Add SetLastError hint to CreateHardLink pinvoke method
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:34:06 +09:00
Dean Herbert
f4316a9827
Fix incorrect grammar in hard link explanation text
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:30:01 +09:00
Bartłomiej Dach
9d14292320
Merge pull request #21588 from smoogipoo/beginplaying-score-token
Add score token to `BeginPlaySession()`
2022-12-13 18:19:07 +01:00
Bartłomiej Dach
849245b90c
Merge branch 'master' into beginplaying-score-token 2022-12-13 17:15:24 +01:00
Bartłomiej Dach
9d549c3059
Merge pull request #21619 from EVAST9919/buttons-fix
Fix buttons receiving input outside the content
2022-12-13 17:15:00 +01:00
Bartłomiej Dach
dfb8f4fdd9
Merge branch 'master' into buttons-fix 2022-12-13 16:35:03 +01:00
Dean Herbert
3d65984a89 Update framework 2022-12-13 22:34:01 +09:00
Dean Herbert
bf56f5f8c0 Show error message on attempting to open a URL with an unsupported protocol 2022-12-13 22:33:56 +09:00