Bartłomiej Dach
2e63c2ce20
Fix selection box operation hotkeys not registering in change handler
...
Could lead to crashes after reversing a note cluster and playing it
back.
The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.
Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
Joehu
599c55fca5
Update total kudosu earned description text in line with web
2021-03-17 13:22:00 -07:00
Joehu
6cea74f0fa
Remove available kudosu section from user profile overlay in line with web
2021-03-17 13:21:41 -07:00
Bartłomiej Dach
21e18c9f6e
Fix test hangs in browser due to changing tracks via music controller
2021-03-17 18:46:22 +01:00
Bartłomiej Dach
3b55eeb416
Fix test failure by setting beatmap
...
Post-merge, it was failing because somewhere along the way
`EditorClockTestScene` started expecting inheritors to set the beatmap
themselves explicitly in BDL.
2021-03-17 18:39:48 +01:00
Bartłomiej Dach
f1e66cc420
Adjust test namespace
2021-03-17 18:37:11 +01:00
Bartłomiej Dach
a691291ae8
Merge branch 'master' into editor-song-end
2021-03-17 18:18:19 +01:00
Bartłomiej Dach
3bfde7341f
Revert "Remove unnecessary overrides"
...
This reverts commit f4e508b570
2021-03-17 17:14:53 +01:00
Dan Balasescu
5a7e416495
Merge pull request #12027 from peppy/new-beatmap-empty-fields
...
Don't fill beatmap metadata with template values on creating a new beatmap
2021-03-17 19:36:21 +09:00
smoogipoo
e59b8b4ce6
Fix test checking nullable string
2021-03-17 19:07:29 +09:00
smoogipoo
f7ec79c5f4
Fix incorrect generic type
2021-03-17 19:02:25 +09:00
Dean Herbert
4bf57ad860
Remove remaining reference to obsolete value
2021-03-17 18:24:24 +09:00
Dean Herbert
e0c0107461
Merge branch 'update-config-usages' into input-handler-configuration
2021-03-17 18:08:13 +09:00
Dean Herbert
fccd495f27
Remove obsoleted setting for now
2021-03-17 18:07:51 +09:00
Dean Herbert
79041c1c4b
Remove osuTK reference
2021-03-17 18:07:42 +09:00
Dean Herbert
577d40d8d1
Update framework
2021-03-17 18:05:18 +09:00
Dean Herbert
249ab8ab3d
Merge branch 'master' into input-handler-configuration
2021-03-17 18:05:14 +09:00
Dean Herbert
a1a0074c32
Revert "Local framework"
...
This reverts commit b9b095ee75
2021-03-17 18:05:11 +09:00
Dean Herbert
822d469b2c
Merge pull request #12024 from peppy/fix-editor-startup-threading-crash
2021-03-17 18:02:48 +09:00
Dean Herbert
d0e61e5b4d
Put back the label
2021-03-17 17:14:04 +09:00
Dean Herbert
3b6a1180b6
Remove non-accessed field
2021-03-17 17:02:11 +09:00
Dean Herbert
5adc675862
Focus artist textbox on entering song setup if fields are empty
2021-03-17 16:57:14 +09:00
Dean Herbert
26d6f96c4e
Fix LabelledTextBox not correctly forwarding focus to its underlying TextBox component
2021-03-17 16:56:58 +09:00
Dean Herbert
eda891223c
Start the editor with empty artist/creator/difficulty name fields
2021-03-17 16:47:12 +09:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
Dean Herbert
c7740d1181
Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
...
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.
Closes #11968 .
2021-03-17 15:52:25 +09:00
Dan Balasescu
891e7aadb6
Merge pull request #12015 from Joehuu/fix-mouse-disable-default-indicator
...
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-16 11:51:53 +09:00
smoogipoo
b495504cae
Merge branch 'master' into fix-mouse-disable-default-indicator
2021-03-16 10:58:56 +09:00
smoogipoo
da3dc61aae
Remove newline
2021-03-16 10:58:42 +09:00
Bartłomiej Dach
72c18fbdfe
Restructure explosion animation to avoid resetting transforms on free
2021-03-15 21:21:52 +01:00
Bartłomiej Dach
f4e508b570
Remove unnecessary overrides
2021-03-15 20:43:30 +01:00
Bartłomiej Dach
58220481db
Rename I{-> Animatable}HitExplosion
2021-03-15 20:39:02 +01:00
Bartłomiej Dach
712038f771
Merge pull request #12017 from Joehuu/remove-skype
...
Remove skype handle from user profile overlay
2021-03-15 19:55:37 +01:00
Joehu
393f1fbd3f
Remove skype
2021-03-15 10:07:50 -07:00
Dean Herbert
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5
2021-03-15 15:05:32 +09:00
Joehu
3dd72d6f7d
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-14 22:47:05 -07:00
Dean Herbert
712e7bc7bf
Merge pull request #12014 from peppy/fix-eap7-inspections
...
Fix a couple of new inspections introduced in Rider EAPs
2021-03-15 14:26:36 +09:00
Dean Herbert
1e519f0d31
Fix seemingly innocent logic change causing breakage in score imports
2021-03-15 14:20:59 +09:00
Dean Herbert
6d4c1ba2ae
Fix a couple of new inspections introduced in Rider EAPs
2021-03-15 13:35:08 +09:00
Dean Herbert
fce21f23d6
Add comments marking workarounds required for EFcore 5
2021-03-15 13:29:26 +09:00
Dean Herbert
2904f479c6
Share file lookup workaround in ArchiveModelManager with workaround extensions class
2021-03-15 13:26:14 +09:00
Dean Herbert
79d3379f55
Reformat application of configuration
2021-03-15 13:20:22 +09:00
Dean Herbert
1573298e68
Update remaining package references to point to efcore5
2021-03-15 13:12:10 +09:00
Dean Herbert
8a35533889
Add fall-through case to catch a potential requery for unsupported model type
2021-03-15 13:11:58 +09:00
Dean Herbert
2bdffd1004
Move skin requery logic into extension methods
2021-03-15 13:11:58 +09:00
Dean Herbert
900da7b891
Rename and refactor extenion methods to be easier to read
2021-03-15 13:11:58 +09:00
Roman Kapustin
28ef64b62a
Explicitly specify SingleQuery behavior
2021-03-14 21:43:27 +03:00
Roman Kapustin
61d5a6cc57
Simplify Microsoft.EntityFrameworkCore.Design PackageReference
2021-03-14 19:47:14 +03:00
Roman Kapustin
0a1e325fc7
Extract requerying of navigational properties from DbContext
2021-03-14 19:34:53 +03:00
Bartłomiej Dach
00306c0075
Adjust test code after explosion pooling changes
2021-03-14 16:15:33 +01:00
