3334 Commits

• Refactor ShearedButton to allow easier relative sizing (#36802)

  This commit rearranges the contents of `ShearedButtons` to be more
  independent of each other in regards to sizing. Thanks to that, the
  custom logic related to enabling autosizing is no longer necessary.
  Witdh and height are no longer set via the constructor, and can be
  freely configured using the initializer syntax.
  
  Additionally, this allows the button to use relative sizing without
  having to resort to any hackery with `Size` (this will come in handy for
  me when implementing the new footer on multiplayer screens).
  
  Given that most of the `ShearedButton`s currently in use set their width
  explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
  default previously. Instead it is set on the only two such buttons (show
  converts/selected mods on ssv2). I suppose it might be a good idea to
  have it set that by default if no `Width` is specified, as right now
  it'll just not show anything.
  
  Also I've set the margin on the text field by default in all cases
  instead of only when autosizing like how it was previously, since
  otherwise it would be a pain to set that on each button instance when
  needed. I've checked all affected components and could not find any text
  overflowing issues that this could cause.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00
  b76a7e1bb6
• Disable presenting scores in online song selects (#36826)

  RFC. Closes https://github.com/ppy/osu/issues/36815 I guess.
  
  Song select V1 completely disabled the ability to view a score outside
  of solo play in ways that are very easy to let fly under the radar:
  
  
  https://github.com/ppy/osu/blob/5fc836d1f09cebf983313c9b91a5c252890c607a/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs#L26
  https://github.com/ppy/osu/blob/46db3ad96d0e1cd6ba4176b9b474cb79a338965d/osu.Game/Screens/Select/PlaySongSelect.cs#L47-L53
  
  therefore the issue this is trying to close would never even manifest
  there.
  
  The direct cause of the issue is that the results screen is pushed to
  the relevant online screen's *substack* of screens rather than the
  game-global parent stack. That means that when the back button is
  pressed, the following logic fires:
  
  
  https://github.com/ppy/osu/blob/6fa4a7152f144ed2524f20ecf7cfd26492bbe61d/osu.Game/Screens/OnlinePlay/OnlinePlayScreen.cs#L174-L189
  
  This logic fires *on the parent screen* even though *the child screen*
  is the one the user is attempting to back out of. And none of the
  exemptions for the screen substack inside of the above method fire
  because the subscreen is not an `IOnlinePlaySubScreen` (it's
  `SoloResultsScreen` in this case).
  
  Now the direct cause here is probably fixable, although possibly not
  without some significant pulling of footer-shaped teeth. *However*, I
  kind of question as to why viewing scores should be permitted on online
  song selects in the first place - it kind of distracts from the primary
  purpose of the screens which is to *just pick a map already*.

  Bartłomiej Dach · 2026-03-06 00:19:10 +09:00
  6b10ef8709
• Merge branch 'master' into tags-broken
  Dean Herbert · 2026-03-04 19:50:33 +09:00
  459d5e8a45
• Remove outdated xmldoc
  Bartłomiej Dach · 2026-03-04 08:44:31 +01:00
  43af89f75c
• Merge branch 'master' into song-select-v1-salute
  Bartłomiej Dach · 2026-03-04 08:39:58 +01:00
  f74a21c1e1
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Add special not regarding collection dropdown
  Dean Herbert · 2026-03-03 16:45:15 +09:00
  b4f40639a1
• Remove all song select v1 files

  This contains no code changes (that would need review), only file
  deletion and extraction where required in a few odd cases.

  Dean Herbert · 2026-03-03 16:45:14 +09:00
  1a8d2855d4
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Move components only used by beatmap set overlay local to namespace
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  ce542b03db
• Fix initial solo gameplay leaderboard position and color (#36496)

  - Closes https://github.com/ppy/osu/issues/35743
  
  Matches playlists. Multiplayer seems to not have it, but I think that's
  expected (i.e. there's no past scores, so having the initial position be
  "-" and no initial green color seems right).
  
  | Before | After |
  | --- | --- |
  | ![Kapture 2026-01-27 at 15 49
  29](https://github.com/user-attachments/assets/39ad2cda-87e4-49e4-a872-4588ec07cae1)
  | ![Kapture 2026-01-27 at 15 47
  30](https://github.com/user-attachments/assets/1b8f1e42-5468-4634-8397-ba455c453761)
  |
  | ![Kapture 2026-01-27 at 15 51
  57](https://github.com/user-attachments/assets/29b0a4b9-551a-4ac0-9b83-c8eb853422ae)
  | ![Kapture 2026-01-27 at 15 52
  45](https://github.com/user-attachments/assets/7b4b4c9b-4353-4845-9be1-8467326d3f6b)
  |

  Joseph Madamba · 2026-01-30 15:45:02 +09:00
  2ab7492759
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Fix toasts showing "no key bound" for operations which can't have keys bound

  Supersedes and closes https://github.com/ppy/osu/pull/35781.
  Closes https://github.com/ppy/osu/issues/36294.

  Dean Herbert · 2026-01-15 17:52:30 +09:00
  b4ba327c1c
• Add created alias for submitted song select filter

  Symmetrical change to https://github.com/ppy/osu-web/pull/12561 (can
  probably wait until that one is reviewed to be legitimate).

  Bartłomiej Dach · 2025-11-20 11:51:28 +01:00
  094454499c
• Move realm collection writes off of update thread (#35681)

  Probably closes https://github.com/ppy/osu/issues/35650.
  
  Realm slow, episode 23894. I can't reproduce freezes as big as the video
  in the issue is showing but 'realm slow' is 99% the culprit, because
  affected user's database is not small.

  Bartłomiej Dach · 2025-11-11 20:29:39 +09:00
  cb9d9734d6
• Implement grouping by favourites

  - Closes https://github.com/ppy/osu/issues/34494.
  - Supersedes / closes https://github.com/ppy/osu/pull/34744.

  Bartłomiej Dach · 2025-10-24 08:46:34 +02:00
  14d0982b6c
• Fix solo leaderboard sometimes not showing user position while it technically could

  The "partial" leaderboard logic in `SoloGameplayLeaderboardProvider`
  always assumed the online fetch would request 50 scores, which is no
  longer the case after https://github.com/ppy/osu/pull/33100.

  Bartłomiej Dach · 2025-10-23 08:53:29 +02:00
  ca8fc81a7e
• Fix artist/title keyword filters not working properly with not-equals operator

  Closes https://github.com/ppy/osu/issues/35264.

  Bartłomiej Dach · 2025-10-13 11:39:59 +02:00
  8e01fb70c3
• Fix exclusion filters filtering out empty strings
  Bartłomiej Dach · 2025-10-13 11:39:38 +02:00
  a3f635588c
• Fix not-equals user tag filters not working

  Omission / oversight from https://github.com/ppy/osu/pull/34568.
  
  Addresses https://github.com/ppy/osu/discussions/35260.

  Bartłomiej Dach · 2025-10-10 09:56:39 +02:00
  40c447a792
• Fix song select V2 not preserving selection after an update operation

  Because the detached store exists and has a chance to actually
  semi-reliably intercept a beatmap update operation, I decided to try
  this. It still uses a bit of a heuristic in that it checks for
  transactions that delete and insert one beatmap each, but probably the
  best effort thus far?
  
  Notably old song select that was already doing the same thing locally to
  itself got a bit broken by this, but with some tweaking that *looks* to
  be more or less harmless I managed to get it unbroken. I'm not too
  concerned about old song select, mind, mostly just want to keep it
  *vaguely* working if I can help it.

  Bartłomiej Dach · 2025-10-08 14:42:26 +02:00
  30412ba3f2
• Fix hovering left area in song select not always activating reset action
  Dean Herbert · 2025-10-06 18:23:33 +09:00
  df58dc0ca2
• Adjust BPM filtering at song select to be less precise

  Closes https://github.com/ppy/osu/issues/34942.

  Dean Herbert · 2025-09-09 15:02:57 +09:00
  f94d5004ea
• Extract helper method for retrieving all user local scores
  Bartłomiej Dach · 2025-09-03 12:05:02 +02:00
  0bbad3e1cd
• Sort scores immediately for good measure
  Dean Herbert · 2025-08-26 17:51:14 +09:00
  3f179e3903
• Fix playlist leaderboard provider potentially inserting local user in wrong order

  Due to `Perform` being used from a BDL method in conjunction with
  `Success` (which is scheduled to the *update* thread), there was a
  chance that the order of execution would be not quite as intended.
  
  To rectify, let's not use `Success` and just continue with synchronous
  flow.

  Dean Herbert · 2025-08-26 17:51:02 +09:00
  196b28115e
• Merge branch 'master' into notequaloperator
  Salman Alshamrani · 2025-08-15 14:30:55 +03:00
  1741142673
• Fix incorrect parsing
  Bartłomiej Dach · 2025-08-15 11:12:10 +02:00
  5a9592a769
• Simplify multi-valued not-equal enum filter implementation (and cover with tests)
  Bartłomiej Dach · 2025-08-13 11:54:52 +02:00
  0475fe3215
• Improve xmldoc
  Bartłomiej Dach · 2025-08-13 11:50:35 +02:00
  844704212d
• Refactor string filter not-equal implementation to not make my eyes bleed
  Bartłomiej Dach · 2025-08-13 11:45:56 +02:00
  da69cdfa2a
• Reduce code duplication
  Bartłomiej Dach · 2025-08-13 11:42:26 +02:00
  b356e3bee3
• Fix date range filter being inexplicably implemented a little different than the equality filter

  Why???

  Bartłomiej Dach · 2025-08-13 11:35:38 +02:00
  7a2b032b00
• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Fix keyword filters potentially being wrongly merged together due to regex wildcard greedy matching

  Because of greedy matching, a filter of
  
      tag="style/clean"! tag="song representation/simple"!
  
  would not parse into 2 separate filters like
  
      (tag, =, "style/clean"!)
      (tag, =, "song representation/simple"!)
  
  but rather a single one like
  
      (tag, =, "style/clean"! tag="song representation/simple"!)
  
  This sort of matches what web did in
  https://github.com/ppy/osu-web/pull/12044, except web does some stuff
  with quote escaping that I'd rather not, and also the search syntax
  seems to slightly deviate because web seems to be using single quotes
  and double quotes to open the value part of the filter. I'm not sure
  what the difference is and I'd rather not go into all that right now.

  Bartłomiej Dach · 2025-08-13 10:21:10 +02:00
  08a0025e31
• Fix code quality

  Fix code quality 2
  
  code quality fix 3
  
  Fix code quality 4
  
  Add empty line

  Valerus9 · 2025-08-13 14:59:29 +09:00
  bd90ef1bf4
• Add tests coverage for filters with not equal
  Valerus9 · 2025-08-13 14:59:20 +09:00
  997b8a0bba
• Simplify logic of IsInRange()
  Valerus9 · 2025-08-13 14:59:20 +09:00
  cc970ffd80
• Rename ExludeIfInRange to InvertRange, add xmldox to InvertRange
  Valerus9 · 2025-08-13 14:59:19 +09:00
  3a78cfc627
• Implement not equal operator

  Added blank lines

  Valerus9 · 2025-08-13 14:59:19 +09:00
  3162478172
• Merge branch 'master' into rank-achieved-grouping
  Dean Herbert · 2025-08-12 14:28:20 +09:00
  e7f9f629a4
• Arrange SortMode in alphabetical order
  Denis Titovets · 2025-08-08 16:58:18 +03:00
  ea9a0b52d5
• Add "Rank Achieved" grouping mode
  Salman Alshamrani · 2025-08-07 19:16:04 +09:00
  3e9df00bdc
• Add "My Maps" grouping mode
  Salman Alshamrani · 2025-08-06 13:08:42 +03:00
  e0706dd700
• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Move "attribute adjusted" tooltips to individual attribute displays

  Pre-requisite for displaying additional information regarding the impact
  of particular attributes on various beatmap metrics.

  Bartłomiej Dach · 2025-08-01 11:05:54 +02:00
  cb73717a34
• Add support for grouping beatmaps by collections

  Takes changes in https://github.com/ppy/osu/pull/34233 and removes *all*
  of the complexity.
  
  Supersedes and closes #34233.
  
  Contains same caveat that we can only display one beatmap once in the
  carousel; this will be addressed separately.

  Dean Herbert · 2025-08-01 16:23:26 +09:00
  c3396a93a6
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Fix test
  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  1319a5499b