22 Commits

• Refactor ShearedButton to allow easier relative sizing (#36802)

  This commit rearranges the contents of `ShearedButtons` to be more
  independent of each other in regards to sizing. Thanks to that, the
  custom logic related to enabling autosizing is no longer necessary.
  Witdh and height are no longer set via the constructor, and can be
  freely configured using the initializer syntax.
  
  Additionally, this allows the button to use relative sizing without
  having to resort to any hackery with `Size` (this will come in handy for
  me when implementing the new footer on multiplayer screens).
  
  Given that most of the `ShearedButton`s currently in use set their width
  explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
  default previously. Instead it is set on the only two such buttons (show
  converts/selected mods on ssv2). I suppose it might be a good idea to
  have it set that by default if no `Width` is specified, as right now
  it'll just not show anything.
  
  Also I've set the margin on the text field by default in all cases
  instead of only when autosizing like how it was previously, since
  otherwise it would be a pain to set that on each button instance when
  needed. I've checked all affected components and could not find any text
  overflowing issues that this could cause.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00
  b76a7e1bb6
• Make ShearedButton block mouse down events

  Closes https://github.com/ppy/osu/issues/33748.
  
  I (and tests) can't find any regressions from this. One would hope we
  aren't relying on fall-through mouse down anywhere beneath buttons..

  Dean Herbert · 2025-07-01 19:30:47 +09:00
  ed189fecf4
• Fix sheared button getting cut when scaled beyond 100%

  Keep masking back in `Content`, since the scaling animation is happening
  on `Content` instead of `this`. This doesn't regress the intended
  behaviour in this PR (which is to just to make the button class itself
  sheared instead of its content).

  Salman Alshamrani · 2025-04-29 05:34:10 +03:00
  b4cf974662
• Remove padding from ShearedButton for better sheared flow alignment
  Salman Alshamrani · 2025-04-18 07:23:39 -04:00
  62b96466c4
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Remove unused using directives
  Salman Ahmed · 2024-05-16 07:47:57 +03:00
  820cfbcb00
• Move SHEAR constant to OsuGame and revert back to 0.2x (i.e. master)

  Discussed in [discord](https://discord.com/channels/188630481301012481/188630652340404224/1240490608934653984).

  Salman Ahmed · 2024-05-16 07:28:02 +03:00
  310b4d90cc
• Change shear factor everywhere to 0.15x
  Salman Ahmed · 2024-05-16 05:33:01 +03:00
  9265290acf
• Allow customising content of ShearedButtons
  Salman Ahmed · 2024-05-16 05:02:56 +03:00
  266f080362
• Allow specifying height of ShearedButtons

  Also includes a test case in `TestSceneShearedButton`s to ensure the buttons' shear factors don't change on different heights (I've encountered issues with that previously).

  Salman Ahmed · 2024-05-16 05:02:56 +03:00
  e3afd89dc8
• Extract constants properly
  Bartłomiej Dach · 2023-09-11 08:29:37 +02:00
  c1a2b86f3f
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add support for 'disabled' sample variation to HoverClickSounds
  Jamie Taylor · 2022-11-03 17:47:49 +09:00
  f1c17129eb
• Fix broken ShearedButton autosizing logic
  Bartłomiej Dach · 2022-08-01 22:04:16 +02:00
  298efa5391
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix appearance of sheared button borders after click

  The border would previously get brighter after click, but then dim
  instantly when the flash layer has fully faded out. The underlying issue
  there is https://github.com/ppy/osu-framework/issues/5191, but
  `ShearedButton` was placing the flashing layer incorrectly anyway, as
  the intent was that it should also apply to the border.

  Bartłomiej Dach · 2022-05-21 20:53:23 +02:00
  21e1576b2f
• Reduce scale effect slightly (was feeling too bouncy)
  Dean Herbert · 2022-05-02 20:32:33 +09:00
  f9a1d9df56
• Make disabled sheared buttons darker
  Dean Herbert · 2022-05-02 20:32:33 +09:00
  55949e8407
• Expose font size and add big button test
  Dean Herbert · 2022-04-26 18:14:57 +09:00
  52a8f3848d
• Reduce the hover lightening effect slightly
  Dean Herbert · 2022-04-26 18:11:03 +09:00
  cd197a9380
• Add flash effect on click
  Dean Herbert · 2022-04-26 18:03:34 +09:00
  4bc4ff179a
• Split out ShearedButton from ShearedToggleButton
  Dean Herbert · 2022-04-26 17:31:55 +09:00
  9f33e627de