53 Commits

• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Refuse to import scores specifying incompatible mods

  Supersedes https://github.com/ppy/osu/pull/32817.
  
  The messaging of the failure to the user is maybe not the cleanest, but
  I'm not sure it's worth putting time in to improve it?

  Bartłomiej Dach · 2025-04-17 10:10:07 +02:00
  485c3e8e53
• Look up users by ID if available when importing scores
  Bartłomiej Dach · 2024-05-06 13:24:34 +02:00
  abfb2c00bc
• Do not perform username lookups for scores without an online ID
  Bartłomiej Dach · 2024-05-03 13:59:36 +02:00
  afb491dff0
• Unify legacy total score / accuracy / rank recomputation flows
  Bartłomiej Dach · 2024-01-22 20:52:51 +01:00
  db4849442e
• Move maximum statistics population to LegacyScoreDecoder
  Bartłomiej Dach · 2024-01-22 20:01:24 +01:00
  aa8eee0796
• Add accuracy conversion, fix usages
  Dan Balasescu · 2023-12-21 15:09:56 +09:00
  eb072a1d24
• Expose only as one method
  Dan Balasescu · 2023-12-21 14:58:23 +09:00
  6b4b2a57fc
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Move operation to after user population
  Dean Herbert · 2023-10-30 15:46:09 +09:00
  c1c8e2968f
• Update the last played date of a beatmap when importing a replay by the local user
  Dean Herbert · 2023-10-30 15:44:16 +09:00
  96dd7b3333
• Fix score importer looking up guest user by username online
  Bartłomiej Dach · 2023-10-10 09:28:01 +02:00
  24956588e9
• Merge branch 'master' into fix-batch-import-score-missing-notifications
  Bartłomiej Dach · 2023-09-27 17:06:47 +02:00
  0769d0f49f
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b
• Adjust logging to still expose the underlying exception
  Dean Herbert · 2023-09-27 16:55:03 +09:00
  3708e79577
• Improve notification display when score import fails
  Dean Herbert · 2023-09-26 15:00:56 +09:00
  d1d82d2b49
• Pass ArchiveReader instead of Stream to simplify resolution code
  Dean Herbert · 2023-09-19 17:49:15 +09:00
  f726c38215
• Fix log output using incorrect name
  Dean Herbert · 2023-09-19 17:34:24 +09:00
  0593c76c57
• Fix grammar in comment
  Bartłomiej Dach · 2023-09-18 10:46:14 +02:00
  59b9a636d3
• check beatmap hash before try to import
  cdwcgt · 2023-09-04 17:37:31 +09:00
  f68a12003a
• post a notification instead a screen
  cdwcgt · 2023-09-04 16:17:21 +09:00
  58844092d6
• remove all memory stream dispose
  cdwcgt · 2023-08-04 20:02:22 +09:00
  09047538c7
• don't passing stream by exception
  cdwcgt · 2023-08-02 22:04:29 +09:00
  0e7e36f114
• ensure Performer not null
  cdwcgt · 2023-08-02 18:53:27 +09:00
  6637a5e7bc
• ensure dispose stream
  cdwcgt · 2023-08-02 17:58:17 +09:00
  4c43c92329
• fetch missing beatmap when import score with missing beatmap
  cdwcgt · 2023-08-02 17:58:05 +09:00
  eef63b41da
• Merge pull request #24114 from peppy/editor-save-local-score-management

  Ensure scores always have the correct linked `BeatmapInfo`

  Dean Herbert · 2023-07-07 15:40:54 +09:00
  d72765b6f8
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Merge branch 'master' into editor-save-local-score-management
  Dean Herbert · 2023-07-06 12:28:44 +09:00
  9ff6b3fcd3
• Throw if a null BeatmapInfo arrives during score import process
  Dean Herbert · 2023-07-05 16:08:06 +09:00
  5947c2b298
• Make ScoreInfo.BeatmapInfo nullable
  Dean Herbert · 2023-07-04 14:50:34 +09:00
  d74b1e148d
• Move population of LegacyTotalScore to ScoreImporter
  Dan Balasescu · 2023-06-29 17:21:24 +09:00
  6822871dab
• Refactoring
  Dan Balasescu · 2023-06-28 16:14:32 +09:00
  09bc8e45de
• Store old total score as LegacyTotalScore
  Dan Balasescu · 2023-06-27 14:59:40 +09:00
  0c5c09597c
• Initial conversion of scores
  Dan Balasescu · 2023-06-26 22:19:01 +09:00
  a9c65d200a
• Apply migration to new standardised score on normal reimport too
  Bartłomiej Dach · 2023-06-15 21:53:15 +02:00
  51b5a0863f
• Add a very simple user cache to ScoreImporter
  Dean Herbert · 2023-06-09 19:03:28 +09:00
  c5e77e13de
• Remove verbose log from notifications feed
  Salman Ahmed · 2023-01-10 13:31:29 +03:00
  c6b6d0dcfe
• Remove unused using directive
  Salman Ahmed · 2023-01-09 23:25:52 +03:00
  20ed337ea8
• Improve missing beatmap failure logging on score import
  Salman Ahmed · 2023-01-09 23:06:59 +03:00
  f216d7264b
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Convert batchImport parameter to parameters class to allow further import configuration
  Dean Herbert · 2022-12-13 19:55:18 +09:00
  cf2719d4c0
• Fix async exception by using difficulty calculator directly
  Dan Balasescu · 2022-09-09 13:57:01 +09:00
  08d0c08750
• Add MaximumStatistics upgrade for databased scores
  Dan Balasescu · 2022-09-09 09:56:08 +09:00
  731d3f3b63
• Actually save maximum statistics
  Dan Balasescu · 2022-08-24 17:28:41 +09:00
  cc648a90bc
• Add flow for bypassing local cache lookups when refreshing beatmap metadata
  Dean Herbert · 2022-07-28 16:33:51 +09:00
  c35da62224
• Fix user population logic not including country
  Salman Ahmed · 2022-07-16 06:39:05 +03:00
  d0fe4fe15a
• Simplify population logic and match code style
  Salman Ahmed · 2022-07-11 21:51:09 +03:00
  4f009419b8
• Assign missing UserID to RealmUser
  Andrew Hong · 2022-07-11 02:36:51 -04:00
  10d6027c89