1583 Commits

• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Merge pull request #25480 from peppy/2fa

  Add two factor authentication flow

  Dean Herbert · 2024-01-29 19:14:55 +09:00
  cbbe2f9dc0
• Fix more nullable inspections
  Bartłomiej Dach · 2024-01-29 08:44:27 +01:00
  a41ba7c381
• Mark ResultsScreen.Score as nullable

  Is nullable in playlist results at very least.

  Dean Herbert · 2024-01-29 16:43:26 +09:00
  fb24c66342
• Ensure all remaining test usages of IAPIAccess.Login() also authenticate with second factor
  Bartłomiej Dach · 2024-01-23 18:04:41 +01:00
  0d7834af5f
• Merge pull request #26669 from bdach/fix-score-submission-test-failures-again-aaaaaaaaAAAAAA

  Fix score submission test failures due to checking audio playback validity (again)

  Dean Herbert · 2024-01-22 20:07:51 +09:00
  2ab0be7606
• Fix score submission test failures due to checking audio playback validity (again)

  As seen in https://github.com/ppy/osu/actions/runs/7607899979/job/20716013982?pr=26662#step:5:75
  
  In https://github.com/ppy/osu/pull/26484, I went "well if I'm moving the
  enabling of validation of playback rate to `SubmittingPlayer` context,
  then surely I can remove the local override in the test scene, right?"
  
  Reader: Apparently I did not notice that `FakeImportingPlayer :
  TestPlayer : SoloPlayer : SubmittingPlayer`. So no, I could not remove
  the local override in the test scene.
  
  You could probably attempt to conjure up some excuse about deep
  inheritance hierarchies here but nah. Really just a failure to read
  on my behalf as usual.

  Bartłomiej Dach · 2024-01-22 11:15:42 +01:00
  9b2740f8a4
• Merge branch 'master' into frame-stable-catchup-zoom
  Bartłomiej Dach · 2024-01-22 10:37:06 +01:00
  77ef12ebb0
• Remove test guarantee of audio time not advancing
  Dean Herbert · 2024-01-18 20:06:53 +09:00
  c4e9bcd140
• Simplify gameplay pause sequence
  Dean Herbert · 2024-01-18 14:17:19 +09:00
  799c74cfe5
• Add a fake load to visual test to restore previous testing behaviour
  Dean Herbert · 2024-01-18 14:01:37 +09:00
  fb4efd992d
• Change frame stable catch-up method to allow for much faster sync
  Dean Herbert · 2024-01-18 14:01:37 +09:00
  c362a93a36
• Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods

  Add guard against submitting score with invalid mod instances

  Bartłomiej Dach · 2024-01-17 11:39:32 +01:00
  5cb17bcacf
• Fix submission test not asserting properly
  Salman Ahmed · 2024-01-16 14:27:40 +03:00
  485195d4c2
• Fix TestModReinstantiation failing due to custom mod being used
  Salman Ahmed · 2024-01-15 15:01:13 +03:00
  d346dd0650
• De-dupe displayed hits in judgement counter
  Dean Herbert · 2024-01-15 16:02:59 +09:00
  e6453853c2
• Add failing test coverage of duplicates in judgement counter display
  Dean Herbert · 2024-01-15 16:02:58 +09:00
  2d5a39b234
• Add failing test case
  Salman Ahmed · 2024-01-13 16:24:49 +03:00
  b1fae2bc6a
• Only validate playback rate when in submission context

  Temporary workaround for https://github.com/ppy/osu/issues/26404.
  
  It appears that some audio files do not behave well with BASS, leading
  BASS to report a contradictory state of affairs (i.e. a track that is
  in playing state but also not progressing). This appears to be related
  to seeking specifically, therefore only enable the validation of
  playback rate in the most sensitive contexts, namely when any sort of
  score submission is involved.

  Bartłomiej Dach · 2024-01-12 14:59:15 +01:00
  6572fa4378
• Adjust skinnable health display test scene for usability
  Bartłomiej Dach · 2024-01-11 10:17:32 +01:00
  600e4b6ef3
• Move simulated drain to separate test case

  Having it on at all times was causing other tests to fail.

  Bartłomiej Dach · 2024-01-11 10:04:37 +01:00
  861080d3ae
• Also show drain on argon health display test
  Dean Herbert · 2024-01-11 00:31:31 +09:00
  c2706ca91b
• Fix failing test by setting health on source of truth
  Dean Herbert · 2024-01-10 23:09:43 +09:00
  49d13cda6b
• Change skinnable health test scene to drain
  Dean Herbert · 2024-01-09 17:09:19 +09:00
  f1b4c305b0
• Fix player submission test intermittent failures due to audio playback discrepancy logic kicking in

  See https://github.com/ppy/osu/actions/runs/7384457927/job/20087439457#step:5:133.

  Bartłomiej Dach · 2024-01-03 09:17:01 +01:00
  e686a6a1dd
• Migrate BeatmapOffsetControl to use session static directly
  Bartłomiej Dach · 2023-12-27 19:19:27 +01:00
  1b7af989ec
• Rename ScoreInfo.{ -> Client}Version
  Bartłomiej Dach · 2023-12-21 12:56:43 +01:00
  81bbdccee7
• Add versioning of local scores

  For any potential future usage

  Dean Herbert · 2023-12-21 18:37:15 +09:00
  a4baa0a716
• Fix test value getting clobbered due to stupid stuff

  Don't even ask. Just smile and nod.

  Dean Herbert · 2023-12-06 15:59:29 +09:00
  43dc908257
• Fix tests which were relying on SliderMultiplier==1
  Dean Herbert · 2023-12-06 13:50:10 +09:00
  79826dee58
• Move private method
  Salman Ahmed · 2023-12-05 22:06:53 +03:00
  c55bfc03ee
• Perserve miss animation when followed by a hit at same frame
  Salman Ahmed · 2023-12-05 21:59:28 +03:00
  20fd458fac
• Add test scenarios for same-frame judgements
  Salman Ahmed · 2023-12-05 21:59:28 +03:00
  986f4fa407
• Add visual test case for late miss in argon health display
  Salman Ahmed · 2023-12-04 23:01:11 +03:00
  17577a6606
• Add extra test coverage and handle case where still at loading screen
  Dean Herbert · 2023-11-24 15:05:39 +09:00
  7ceb49fbc0
• Update failing test coverage and fix onFail being called too often
  Dean Herbert · 2023-11-24 14:44:57 +09:00
  ef5dd24589
• Add test coverage of remote user failing immediately failing locally
  Dean Herbert · 2023-11-24 14:38:02 +09:00
  51e2ce500d
• Add test coverage of remote player quitting immediately quitting locally
  Dean Herbert · 2023-11-24 14:26:09 +09:00
  73ad92189b
• Update tests to work with nested screen
  Dean Herbert · 2023-11-24 14:26:09 +09:00
  e06d79281d
• Rename SoloSpectator to SoloSpectatorScreen
  Dean Herbert · 2023-11-24 14:26:08 +09:00
  dabbdf674b
• Merge pull request #25547 from bdach/skin-editor-paste-catching-fire

  Fix skin editor crashing when pasting with nothing in clipboard

  Dean Herbert · 2023-11-23 16:15:11 +09:00
  5d367c247c
• Add test coverage of skin editor copy-paste
  Bartłomiej Dach · 2023-11-23 09:55:16 +09:00
  4edaaa3083
• Merge pull request #25415 from Poyo-SSB-forks/unify-ur

  Change unstable rate calculation to account for rate-change mods

  Dan Balasescu · 2023-11-23 09:53:28 +09:00
  30309cdf11
• Merge branch 'master' into bspline-sliders
  Bartłomiej Dach · 2023-11-20 12:03:29 +09:00
  b6e3e42445
• Add back test step for testing out argon health bar width
  Bartłomiej Dach · 2023-11-15 13:33:14 +09:00
  71714f8f6e
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• Add rate-change UR tests
  Poyo · 2023-11-12 11:16:06 -08:00
  8c36604e58
• Fix broken tests
  Poyo · 2023-11-12 11:13:38 -08:00
  d123ba5bce
• Fix one more reference to removed setting
  Bartłomiej Dach · 2023-11-12 07:42:41 +09:00
  3e8c89e282
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18