76838 Commits

This Branch

This Branch

All Branches

• Bump SharpCompress
  Dean Herbert · 2026-05-11 12:36:37 +09:00
  a701edf6a1
• Ensure samples definitely stop playing when exiting queue screen

  See https://github.com/ppy/osu/issues/37379.

  Dean Herbert · 2026-05-11 03:27:40 +09:00
  9e6b0148a0
• Remove unused variable
  Dean Herbert · 2026-05-09 00:34:45 +09:00
  2026.509.0-tachyon 458a27c99a
• Fix missing uncommitted change
  Dean Herbert · 2026-05-09 00:26:25 +09:00
  397b2201d0
• Update framework
  Dean Herbert · 2026-05-08 22:50:40 +09:00
  6f46be12db
• Enable stateful reconnects (#35658)

  RFC
  
  - Requires https://github.com/ppy/osu-server-spectator/pull/366 to
  actually function.
  
  Resolves https://github.com/ppy/osu/issues/35580
  Resolves https://github.com/ppy/osu-server-spectator/issues/193
  Resolves https://github.com/ppy/osu/issues/35586
  Resolves https://github.com/ppy/osu-server-spectator/issues/362
  Resolves https://github.com/ppy/osu/issues/37353
  
  ## Outline
  
  This enables stateful reconnect for spectator-server endpoints, allowing
  ConnectionIds to be preserved for a short period and messages to be
  replayed on reconnect.
  
  In practice, this means short disconnects (<30s) should no longer:
  - Drop replays
  - Kick you out of multiplayer rooms
  - Trigger "user has come online" re-alerts.
  
  The following video demonstrates two of the above:
  
  
  https://github.com/user-attachments/assets/b9781f31-a8a1-410e-b0ac-65d3374a33d6
  
  Stateful reconnect appears to kick in as long as the socket doesn't get
  disconnected, _not_ on subsequent re-connections. We have the timeout
  period set to SignalR's default of 30sec.
  
  I've been using the following to simulate a total link loss:
  
  ```sh
  #!/bin/bash
  
  DELAY=${1:-1}
  
  echo "Conditioning for $DELAY seconds..."
  
  sudo ip link set lo down
  sudo ss -K dst 127.0.0.2 > /dev/null
  sleep $DELAY
  sudo ip link set lo up
  ```

  Dan Balasescu · 2026-05-08 22:03:56 +09:00
  aace7f9523
• Fix song select scrolling performance when user has many beatmaps loaded (#37666)

  Also fixes wrong rank showing briefly in some scenarios.
  
  ---
  
  I'm quite confused why the overhead is in the post-async-filter
  collection access, but it is. It occurs when using `MaxBy` (realm
  snapshot creation), but also when calling `.Count` on the collection, or
  even just accessing `sender[0]`. I tried everything, and ended up
  settling on simplifying the realm part enough that we can do
  post-filtering without much sweat or mess.
  
  Before:
  
  
  https://github.com/user-attachments/assets/59aed895-03ed-4923-9515-9a5426156f7e
  
  After:
  
  
  https://github.com/user-attachments/assets/9a37f34a-c955-45bf-877f-89f248d8ea72
  
  Tested using [this realm](https://screvillshot.s-ul.eu/YJUJ4SR1).
  
  - Closes https://github.com/ppy/osu/issues/37574.
  - Closes https://github.com/ppy/osu/issues/37661.

  Dean Herbert · 2026-05-08 13:25:55 +02:00
  08c02e29b9
• Don't consider user toggles for beatmap skin/samples when in editor (#37662)

  As far as I can tell this matches stable expectations. As with most
  things editor, it doesn't make sense to skin a beatmap and then want to
  edit the beatmap without that skin applied, ever.
  
  ---
  
  As mentioned in https://github.com/ppy/osu/discussions/37607.
  
  Could probably be implemented in five different ways, this is just the
  simplest that came to me. Well aware this is adding even more faff on
  top of the config/disable/toggles for this stuff, but feels required for
  editor sanity.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-05-08 12:21:43 +02:00
  0457cb924a
• Fix sentry logger init failing for edge cases (#37673)

  Closes https://github.com/ppy/osu/issues/37650.

  Dean Herbert · 2026-05-08 18:06:23 +09:00
  c74c54d770
• Replace hit objects when placing at same time in editor (#37485)

  Matches stable and significantly improves UX when mapping. In addition,
  current behavior makes it too easy to place stacked objects which is
  something we should not encourage.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Hivie · 2026-05-08 18:04:59 +09:00
  4d88c143f9
• Added "LN Ratio" display in Mania in the place of useless "key count" (#37581)

  The "Key Count" metric in mania is very useless since you are already
  expected to play maps with a specific Key Count when you are queueing.
  This PR inserts the proportion of LNs (Long Notes) in the place of that
  metric since it is one of the ways players can gudge their skillsets
  (This idea comes from reddit)
  Also improved the test suite for other skillsets by making the
  architecture more minor ruleset friendly
  
  Addresses https://github.com/ppy/osu/discussions/37568.
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Kao Li Chin (Gao Li Jin) · 2026-05-08 18:04:29 +09:00
  53f945b7ac
• Restore editor mode when changing difficulty (#37671)

  When editing metadata, it's annoying that the editor returns to compose
  mode when switching between difficulties. This fixes that fallacy.
  
  Supersedes and closes https://github.com/ppy/osu/pull/36724.

  Dean Herbert · 2026-05-08 10:25:22 +02:00
  e6fdd37e76
• Add judgement counter mode to show misses only (#37664)

  Not sure if valuable. Came from
  https://github.com/ppy/osu/discussions/37261 but that wants slider ends
  as well, which is like, weird.
  
  🤷

  Dean Herbert · 2026-05-08 10:19:40 +02:00
  7d93c242b7
• Attempt to fix flaky mania key count change test

  Can reproduce the failure via something like
  
  diff --git a/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs b/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs
  index fe5c437e40..92c58a7bde 100644
  --- a/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs
  +++ b/osu.Game.Rulesets.Mania/Edit/Setup/ManiaDifficultySection.cs
  @@ -187,13 +187,13 @@ private void updateKeyCount(ValueChangedEvent<int> keyCount)
               {
                   if (!t.GetResultSafely())
                   {
  -                    Schedule(() =>
  +                    Scheduler.AddDelayed(() =>
                       {
                           changeHandler!.RestoreState(-1);
                           Beatmap.Difficulty.CircleSize = keyCount.OldValue;
                           setStateFromActualKeyCount(keyCount.OldValue);
                           updatingKeyCount = false;
  -                    });
  +                    }, 1000);
                   }
                   else
                   {
  
  so I'm banking on this being just a case of CI fuzzing the test by being
  slow.
  
  If the test fails again on this same assert after this change there are
  bigger problems at hand. But given the lack of local reproduction I'd
  rather start with this than spend an hour staring at it.

  Bartłomiej Dach · 2026-05-08 09:38:56 +02:00
  b578d34da4
• Add ability to sync metadata across difficulties in editor setup (#37465)

  https://github.com/user-attachments/assets/e8f67f68-1f36-45ef-a50b-3284a8350ffd
  
  This has been a pain point in both lazer and stable, and people usually
  use external tools for this kind of stuff for stable.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Hivie · 2026-05-08 16:35:20 +09:00
  26266321dd
• Show chat during ranked play intro screen (#37657)

  Maybe code-wise it looks a little bit hacky, but it works?

  Dan Balasescu · 2026-05-08 15:47:36 +09:00
  4ffc08157c
• Fix some numeric settings not working correct in some languages when attempting to set negative value (#37667)

  Closes https://github.com/ppy/osu/issues/37553.
  
  You can probably tell by the title that this is going to be a good one.
  
  As previously mentioned in https://github.com/ppy/osu/pull/35395,
  framework-side `TextBox` uses a bunch of `NumberFormat` properties from
  `CurrentCulture` to contextually allow decimal points or minus signs in
  a textbox.
  
  In some languages, namely (of the ones we support): Finnish, Croatian,
  Lithuanian, Norsk, Slovenian, and Swedish, `NumberFormat.NegativeSign`
  is not `U+002D HYPHEN MINUS`, but instead `U+2212 MINUS SIGN`.
  Therefore, in `FormSliderBar`, when `ToStandardFormattedString()` is
  attempted to be used to set the textbox value, the hardcoded `U+002D
  HYPHEN MINUS` is rejected on cultures that expect `U+2212 MINUS SIGN`,
  and thus due to a feedback loop, all negative values are no longer
  settable.
  
  This applies the obvious fix of applying `NumberFormat.NegativeSign`.

  Bartłomiej Dach · 2026-05-08 15:45:57 +09:00
  7f5f368dea
• Ensure users cannot lose data when editing beatmaps above 10K (#37668)

  Intends to close https://github.com/ppy/osu/issues/37395.
  
  In the past there have been many discussions about this dual stages
  wart. Whether it will continue to be "dual stages", or just a single
  stage with 12/14/16/18K, whether all of the skinning weirdness related
  to it (https://github.com/ppy/osu/issues/23620) will be supported, etc.
  
  This isn't that, I don't want to get into that, and I'm not promising
  anything. All I want to make sure here is that users cannot get their
  data lost by editing an existing >10K beatmap, and be understandably
  upset about it.
  
  To that end this mostly apes how stable does things.

  Bartłomiej Dach · 2026-05-08 15:45:06 +09:00
  9d31332457
• Show user rank on list panels (#37659)

  Addresses https://github.com/ppy/osu/discussions/37616 partly.
  
  <img width="828" height="826" alt="osu! 2026-05-07 at 06 59 23"
  src="https://github.com/user-attachments/assets/15343112-dc07-4501-b291-b53db870be5a"
  />

  Dean Herbert · 2026-05-08 15:34:59 +09:00
  9e20929ad3
• Don't search for users when no search query is provided (#37660)

  Doesn't make much sense and looks to be stressing the server a bit
  (results take some time to return). Just a quick fix.

  Dean Herbert · 2026-05-08 08:20:06 +02:00
  21c892fa7d
• Fix pause ambience loop not playing at fail screen (#37663)

  Matches stable.
  
  ---
  
  Addresses https://github.com/ppy/osu/discussions/37580.

  Dean Herbert · 2026-05-07 10:51:19 +02:00
  1818c1b1e6
• Add better support for handling disconnection at the ranked play queue screen (#37658)

  Until now the queue screen basically did nothing to let the user knowing
  they were disconnected from the server. Now the various components will
  correctly clear state and show a roughly competent "i'm trying to
  reconnect" state.
  
  
  
  https://github.com/user-attachments/assets/bff1b241-a6a2-445a-9ffa-b5682f2a3656
  
  
  
  
  ---
  
  Can be tested using the following patch (hit `F7` to reconnect, with a 5
  second delay to show the disconnected state too):
  
  ```diff
  diff --git a/osu.Game/Online/PersistentEndpointClientConnector.cs b/osu.Game/Online/PersistentEndpointClientConnector.cs
  index 7064906be4..ae539aba8d 100644
  --- a/osu.Game/Online/PersistentEndpointClientConnector.cs
  +++ b/osu.Game/Online/PersistentEndpointClientConnector.cs
  @@ -99,6 +99,8 @@ private async Task connect()
                       // this will also create a new cancellation token source.
                       await disconnect(false).ConfigureAwait(false);
   
  +                    await Task.Delay(5000).ConfigureAwait(false);
  +
                       // this token will be valid for the scope of this connection.
                       // if cancelled, we can be sure that a disconnect or reconnect is handled elsewhere.
                       var cancellationToken = connectCancelSource.Token;
  diff --git a/osu.Game/OsuGameBase.cs b/osu.Game/OsuGameBase.cs
  index 703444a92f..fb467472d3 100644
  --- a/osu.Game/OsuGameBase.cs
  +++ b/osu.Game/OsuGameBase.cs
  @@ -22,6 +22,7 @@
   using osu.Framework.Graphics.Containers;
   using osu.Framework.Graphics.Textures;
   using osu.Framework.Input;
  +using osu.Framework.Input.Events;
   using osu.Framework.Input.Handlers;
   using osu.Framework.Input.Handlers.Joystick;
   using osu.Framework.Input.Handlers.Midi;
  @@ -65,6 +66,7 @@
   using osu.Game.Scoring;
   using osu.Game.Skinning;
   using osu.Game.Utils;
  +using osuTK.Input;
   using RuntimeInfo = osu.Framework.RuntimeInfo;
   
   namespace osu.Game
  @@ -104,7 +106,7 @@ public partial class OsuGameBase : Framework.Game, ICanAcceptFiles, IBeatSyncPro
           /// </summary>
           private const double global_track_volume_adjust = 0.8;
   
  -        public virtual bool UseDevelopmentServer => DebugUtils.IsDebugBuild;
  +        public virtual bool UseDevelopmentServer => false;
   
           public virtual EndpointConfiguration CreateEndpoints() =>
               UseDevelopmentServer ? new DevelopmentEndpointConfiguration() : new ProductionEndpointConfiguration();
  @@ -466,6 +468,20 @@ private void addFilesWarning()
               }
           }
   
  +        protected override bool OnKeyDown(KeyDownEvent e)
  +        {
  +            if (e.Key == Key.F7)
  +            {
  +                Logger.Log("Forcing reconnect!", level: LogLevel.Important);
  +
  +                ((IStatefulUserHubClient)MultiplayerClient).ServerShuttingDown();
  +                ((IStatefulUserHubClient)SpectatorClient).ServerShuttingDown();
  +                ((IStatefulUserHubClient)metadataClient).ServerShuttingDown();
  +            }
  +
  +            return base.OnKeyDown(e);
  +        }
  +
           private void onTrackChanged(WorkingBeatmap beatmap, TrackChangeDirection direction) => beatmapClock.ChangeSource(beatmap.Track);
   
           protected virtual void InitialiseFonts()
  
  ```

  Dean Herbert · 2026-05-07 16:55:15 +09:00
  7f385c7873
• Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

  Fixes a bug that allowed for selecting the same mod twice in multiplayer
  if the playlist entry has non-default settings for a required mod.
  This happens due to a strict equality mod check in the mod set
  compatibility check function, which only considers mods duplicates if
  their settings are exactly the same. Replacing with a more lenient
  `Type` check fixes this.
  
  Adds a regression test for this behavior
  
  Fixes https://github.com/ppy/osu/issues/37625.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  triacontakai · 2026-05-07 08:59:54 +02:00
  3f5c113394
• Add already existing localisation support from CommonStrings (#37401)

  decided to do this mostly because of the non-localised `BackButton` that
  was bothering my eyes
  
  changes can be reviewed commit by commit

  Denis Titovets · 2026-05-07 00:07:28 +09:00
  b8729cb7fd
• Fix opening changelog overlay from settings in development (#37602)

  Just a small fix for crash that occures when clicking `local debug` in
  settings footer.

  Mathew Tkachuk · 2026-05-06 01:39:32 +09:00
  27f6e94bf0
• Allow reporting users from their profile page (#36335)

  This PR refactors the report popover to have an optional confirmation
  message after completing the request. This was initially meant for
  #32584, but then I realized I can first test it out on the user
  profiles, so I've implemented it here as well. Can be reviewed commit by
  commit.
  
  
  
  https://github.com/user-attachments/assets/cd59c560-c824-4a5e-bab6-5ecbf5125af1
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-05-05 19:49:24 +09:00
  2006485d60
• Add localisation support to DailyChallenge (#37248)
  Denis Titovets · 2026-05-05 17:25:09 +09:00
  a72f4495cd
• Synchronise ranked play text box with gameplay text box (#37630)

  I am not sure if it was intentionally not included, but with quick play
  the unsent text input would be transferred to the gameplay state. This
  video shows how it currently acts:
  
  
  https://github.com/user-attachments/assets/03bc42cd-65fc-403a-a9f6-1739ba38855a
  
  But I have used some of the logic in the `channelChanged` function from
  `StandAloneChatDisplay`, and managed to get the text boxes to
  synchronise in the gameplay state.
  
  
  https://github.com/user-attachments/assets/f70745ad-9ce2-44a4-a50d-7b28d63414b7
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Anthony Berg · 2026-05-05 17:02:57 +09:00
  5fb87da37b
• Eagerly connect to latest server instance for best online experience (#37506)

  Client side requirements for making the client connect as soon as
  possible, based on how the client is being used. This is especially
  important with the introduction of ranked play: previously the worst
  case scenario would be that you couldn't join a multiplayer room (or
  spectate a user) and this was [automatically
  handled](https://github.com/ppy/osu/blob/f66e2c432fdb08db46477c4fa08ca74e551d037f/osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs#L115-L121)
  mostly*, but now, if you leave the game open for a while, you can
  potentially be stuck queueing in ranked play with no users remaining on
  your server.
  
  Some samples of how this looks follow. Do note that the client is
  showing "Server is shutting down" errors. This is only going to happen
  in local debug environments – In production, when you reconnect to the
  endpoint you will always get a non-shutting-down instance.
  
  Idle scenario:
  
  
  https://github.com/user-attachments/assets/dd47fdf6-8d49-48e3-a19f-b196a581070b
  
  Non-idle scenario:
  
  
  https://github.com/user-attachments/assets/dfc8a41a-83fb-4b08-94b4-9595faf88294
  
  * Spectator isn't handled properly, as one example.

  Dean Herbert · 2026-05-05 16:06:00 +09:00
  2026.505.0 51b4e89773
• Fix discord multiplayer invites (#37598)

  Downgrade the `DiscordRichPresence` package until
  https://github.com/Lachee/discord-rpc-csharp/issues/286 is resolved.
  
  Also reported on
  [discord](https://discord.com/channels/188630481301012481/1097318920991559880/1497244317801119866)
  before.
  
  I don't know if it's reproducible for everyone, but at least for me it
  is on both Windows and Linux, and also for everyone I asked to try
  inviting.
  
  Closes #37626
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Zihad · 2026-05-05 00:26:47 +09:00
  80a29eb6a2
• Fix duel crash due to failing lookups (#37606)
  Dan Balasescu · 2026-05-02 15:55:33 +09:00
  3924fc7d86
• Implement duels for ranked play (#37556)

  I've seen this suggested quite a bit and is a pretty easy implementation
  all things considered.
  
  For now, while on the queue screen, you can open up the dashboard
  overlay and select another player to duel. This will bring you into an
  unranked lobby.
  
  
  https://github.com/user-attachments/assets/712897a9-9350-4741-899d-59662c722e43

  Dan Balasescu · 2026-04-29 16:12:27 +09:00
  2026.429.0 2026.429.0-lazer a3b8b9aee9
• Stop song preview when entering spectator (#37564)

  Song preview keeps playing when clicking "Start Watching" on
  `SoloSpectatorScreen`. Making `SoloSpectatorScreen` suspends the screen
  rather than exiting it, so neither `clearDisplay()` nor `OnExiting()`
  fire.
  
  Closes: https://github.com/ppy/osu/issues/36987

  Piotrr0 · 2026-04-29 14:41:33 +09:00
  3b84429e86
• Fix beatmap panels now showing "downloaded" green strip (#37566)

  Regressed in https://github.com/ppy/osu/pull/37558, my bad.

  Dean Herbert · 2026-04-29 11:27:28 +09:00
  bc1c3d09e0
• Add beatmap panel to the ranked play results screen (#37558)

  Different take to / supersedes / closes
  https://github.com/ppy/osu/pull/37550
  
  Just going for minimal lines of code compared to the PR above, by
  reusing the quick play panel which is in a pretty good state.
  
  <img width="1298" height="864" alt="image"
  src="https://github.com/user-attachments/assets/409e163d-d7ea-4c07-874f-aaca7e145221"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-28 22:08:23 +09:00
  2026.428.0-tachyon 71f841d8ae
• Add pen input settings (#37500)

  - depends on https://github.com/ppy/osu-framework/pull/6737
  
  Adds simple input settings section for pens that allows disabling the
  handler and adjusting sensitivity. The section appears in-between Tablet
  and Touch, and only on SDL3 (desktop and mobile). The pen sensitivity is
  completely independent from mouse sensitivity.
  
  <img width="537" height="149" alt="image"
  src="https://github.com/user-attachments/assets/448eebba-84ea-4daf-8428-3bd07739bd6f"
  />
  
  <br>
  
  Keep in mind that the "Confine mouse cursor to window" mouse setting
  also affects pens, feel free to suggest UX improvements. Also, toggling
  "High precision mouse" might affect pens on certain configurations.
  
  Edit: added image with updated header. Previously, it was "Device: Pen".
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Susko3 · 2026-04-28 20:18:30 +09:00
  9b3dba939e
• Implement animation for RankedPlayBottomOrnament (#37504)

  Based off of https://github.com/ppy/osu/pull/37478 with some
  improvements such as:
  * Simpler `progress` handling (single adjustable value instead of 2)
  * 2 less drawable paths (replaced with circlular containers)
  * Reworked remaining paths to have as little texture sizes as possible
  
  ---------
  
  Co-authored-by: Krzysztof Gutkowski <krzysio.gutkowski@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Andrei Zavatski · 2026-04-27 18:40:20 +09:00
  662c85d4c2
• Enhance ranked play stage countdown timer SFX (#37524)

  - adjust the warning stopwatch sample to start from when the timer shows
  10.xxx s instead of 9.xxx s
  - add an additional 'time almost up' sample that layers on top for the
  last 3s
  - re-add the 'time ran out' audio cue, with an updated sample
  
  in context, with bgm:
  
  
  https://github.com/user-attachments/assets/11f105e9-2baa-4d23-bdbc-ac7d16e3d7d8
  
  without bgm:
  
  
  https://github.com/user-attachments/assets/006d6b5a-398c-4e4b-a74e-10889ac6b922
  
  I'm not 100% on the 'time ran out' sample, but at least it sounds
  deliberate now, unlike the previous buzzer which could have been
  mistaken for an audio glitch.
  
  ---
  - [x] depends on ppy/osu-resources#420
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Jamie Taylor · 2026-04-27 18:40:03 +09:00
  428af047f9
• Remove points statistic from MatchmakingStatsTooltip (#37495)

  matches web
  
  | master | `osu-web` | PR |
  |-|-|-|
  | <img width="335" height="81" alt="image"
  src="https://github.com/user-attachments/assets/942fc6c0-488b-49b8-97d4-d2d81eeeed92"
  /> | <img width="307" height="83" alt="image"
  src="https://github.com/user-attachments/assets/3ade843e-c735-4697-bf89-622de2d23d9c"
  /> | <img width="338" height="135" alt="image"
  src="https://github.com/user-attachments/assets/5867023b-145d-4836-ba95-9e2bdd9e1bbc"
  /> |

  Denis Titovets · 2026-04-27 13:58:37 +09:00
  34deaad718
• Minor design improvements to the extended result screen (#37144)

  I am aware of the possibly-one-day-definitely-upcoming redesign, but
  while it's not yet ready I've made a couple of small design improvements
  to the current result screen.
  
  This includes: 
  - Slightly tighter and more consistent paddings
  - StatisticPanel's header being consistent with other similar panels
  (it's using subsection design right now which probably made sense back
  when it was all one panel)
  - More compact PerformanceBreakdown section
  - Slightly less background blur and slightly more transparent statistics
  panels
  
  Before:
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/89b564fd-0205-40bd-a7d5-9e0484fbe5dd"
  />
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/6d58f538-7a78-4de2-9316-7d070dabaf2c"
  />
  
  
  After: 
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/fa242349-27a1-4391-90fa-4d53be718fd4"
  />
  <img width="1922" height="1112" alt="image"
  src="https://github.com/user-attachments/assets/9a755e6f-d6fe-4df2-880c-1f6195bd2a69"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  StanR · 2026-04-25 00:42:47 +09:00
  2026.425.0-lazer 4b9335ca59
• Improve visual appearance and animation of ranked play match history (#37501)

  master:
  
  
  https://github.com/user-attachments/assets/d96c7cf1-4f80-46f8-8c72-427aaf7f965d
  
  This PR:
  
  
  https://github.com/user-attachments/assets/d8c3467e-810d-4473-9078-0e858782cfa5
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-24 23:36:14 +09:00
  c35782ce9c
• Hide red failing layer in ranked play (#37503)

  In ranked play, scores are always counted regardless of whether they are
  a fail or a pass. Beyond that, there's also no concept of revival in
  multiplayer right now, so players are just stuck at 0 HP with a red
  overlay.
  
  Not doing what `ModNoFail` does, which is to hide the healthbar
  altogether, because some user skins use the healthbar to skin a gameplay
  border.

  Dan Balasescu · 2026-04-24 21:56:26 +09:00
  1b86ff11e5
• Persist last queued pool in ranked play screen (#37490)

  Closes #37443
  
  Previously it would select the first pool that matches the user's
  current ruleset.
  
  At first I tried passing the `MatchmakingPool` object to the
  notification and have it passed back to the screen, but with that method
  only clicking the notification would show the correct pool, if you enter
  ranked play normally then it would show the "default" pool instead.
  This method needed fewer changes too.

  Zihad · 2026-04-24 16:55:40 +09:00
  ea87510139
• Add localisation support for some more notifications (#37237)

  - part of https://github.com/ppy/osu/pull/36994
  
  changes can be reviewed commit by commit

  Denis Titovets · 2026-04-24 12:39:55 +09:00
  0fa7824a23
• Update resources
  Dean Herbert · 2026-04-24 11:11:57 +09:00
  88f0be8b22
• Adjust score submission error handling slightly (#37474)

  Based on internal feedback.
  
  I was going to apply other changes (like always posting to sentry) but
  don't want to go too far down a rabbit hole, so just fixed messaging a
  bit.

  Dean Herbert · 2026-04-23 08:41:25 +02:00
  c9ad0e497f
• Add empty hand check to moveCardFocus (#37489)

  Resolves #37486
  
  Original error log:
  ```
  2026-04-22 21:47:58 [error]: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
  2026-04-22 21:47:58 [error]: at System.Collections.Generic.List`1.get_Item(Int32 index)
  2026-04-22 21:47:58 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand.PlayerHandOfCards.moveCardFocus(Int32 direction)
  2026-04-22 21:47:58 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand.PlayerHandOfCards.OnKeyDown(KeyDownEvent e)
  ```
  
  Currently,
  ```osu.Game\Screens\OnlinePlay\Matchmaking\RankedPlay\Hand\PlayerHandOfCards.cs::moveCardFocus```
  does not account for the hand being empty (cards.Count ==0 ), and will
  attempt to move the card focus in the given direction regardless, which
  causes the above index out of range error.
  
  Added empty hand check to moveCardFocus, and a matching test case to
  TestScenePlayerCardHand.cs
  
  New test case before changes, recreating the error:
  <img width="986" height="232" alt="image"
  src="https://github.com/user-attachments/assets/daa62081-c776-44bd-b0d2-382b2dac7938"
  />
  
  After:
  <img width="638" height="223" alt="image"
  src="https://github.com/user-attachments/assets/d6dcd8b8-8caf-42e3-9999-93dfe3fb6452"
  />

  Austin Moore · 2026-04-23 12:23:17 +09:00
  f1ea3b354c
• Add web localisation support to MatchmakingStatsDisplay (#37246)

  <img width="399" height="174" alt="image"
  src="https://github.com/user-attachments/assets/9a9af6e1-1ea4-4010-8a46-edfbb71185e8"
  />

  Denis Titovets · 2026-04-23 10:31:26 +09:00
  70093c90fb
• Apply different workaround to fix ranked play single thread audio issues (#37477)

  Thing to make release happen.
  
  Reverts #37453
  Reverts #37463
  Alternative to #37473
  
  Not that I disagree with any of these but I'm just looking to return to
  what works so we can do a release because we're on a clock here for
  other reasons.
  
  Test which should work but doesn't, so I'm not adding:
  
  ```diff
  diff --git a/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs b/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  index f747004bbd..eb8e360d1e 100644
  --- a/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  +++ b/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  @@ -1,12 +1,17 @@
   // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
   // See the LICENCE file in the repository root for full licence text.
   
  +using System.Linq;
  +using NUnit.Framework;
   using osu.Framework.Extensions;
  +using osu.Framework.Testing;
   using osu.Game.Online.API;
   using osu.Game.Online.Multiplayer;
   using osu.Game.Online.Multiplayer.MatchTypes.RankedPlay;
   using osu.Game.Online.Rooms;
   using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay;
  +using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Card;
  +using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand;
   
   namespace osu.Game.Tests.Visual.RankedPlay
   {
  @@ -14,6 +19,8 @@ public partial class TestSceneOpponentPickScreen : RankedPlayTestScene
       {
           private RankedPlayScreen screen = null!;
   
  +        private readonly BeatmapRequestHandler requestHandler = new BeatmapRequestHandler();
  +
           public override void SetUpSteps()
           {
               base.SetUpSteps();
  @@ -26,8 +33,6 @@ public override void SetUpSteps()
               AddStep("load screen", () => LoadScreen(screen = new RankedPlayScreen(MultiplayerClient.ClientRoom!)));
               AddUntilStep("screen loaded", () => screen.IsLoaded);
   
  -            var requestHandler = new BeatmapRequestHandler();
  -
               AddStep("setup request handler", () => ((DummyAPIAccess)API).HandleRequest = requestHandler.HandleRequest);
   
               AddStep("set pick state", () => MultiplayerClient.RankedPlayChangeStage(RankedPlayStage.CardPlay, state => state.ActiveUserId = 2).WaitSafely());
  @@ -44,7 +49,11 @@ public override void SetUpSteps()
                       }).WaitSafely();
                   }
               });
  +        }
   
  +        [Test]
  +        public void TestBasic()
  +        {
               AddWaitStep("wait", 15);
   
               AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
  @@ -54,5 +63,29 @@ public override void SetUpSteps()
                   BeatmapID = requestHandler.Beatmaps[0].OnlineID
               }).WaitSafely());
           }
  +
  +        [Test]
  +        public void TestPickPreviewPlayedOnOpponentPick()
  +        {
  +            RankedPlayCard.SongPreviewContainer? originalPreview = null;
  +
  +            AddStep("hover first card",
  +                () => InputManager.MoveMouseTo(this.ChildrenOfType<PlayerHandOfCards>().Single().Cards
  +                                                   .First(c => c.Item.PlaylistItem.Value != null && c.Item.PlaylistItem.Value.BeatmapID != requestHandler.Beatmaps[0].OnlineID)));
  +            AddUntilStep("preview playing", () => originalPreview = this.ChildrenOfType<RankedPlayCard.SongPreviewContainer>().FirstOrDefault(p => p.IsRunning), () => Is.Not.Null);
  +
  +            AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
  +            AddStep("reveal card", () => MultiplayerClient.RankedPlayRevealUserCard(2, hand => hand[0], new MultiplayerPlaylistItem
  +            {
  +                ID = 0,
  +                BeatmapID = requestHandler.Beatmaps[0].OnlineID
  +            }).WaitSafely());
  +
  +            AddUntilStep("wait for original preview stopped", () => originalPreview?.IsRunning, () => Is.False);
  +
  +            AddUntilStep("preview playing is opponent's pick",
  +                () => ((RankedPlayCard)this.ChildrenOfType<RankedPlayCard.SongPreviewContainer>().SingleOrDefault(p => p.IsRunning)?.Parent!).Item.PlaylistItem.Value?.BeatmapID,
  +                () => Is.EqualTo(requestHandler.Beatmaps[0].OnlineID));
  +        }
       }
   }
  
  ```
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-23 02:05:52 +09:00
  2026.423.0-lazer a4f79f7c99
• Refactor audio preview logic in ranked play cards to match expectations while hopefully not looking buggy anymore (#37463)

  RFC.
  
  See https://github.com/ppy/osu/pull/37453#issuecomment-4289403735 for
  why.
  
  Of note:
  
  - To facilitate mutual exclusivity of playback `PlayerHandOfCards`
  maintains a bindable pointing at the currently playing song preview.
  - Because of how card drawables are passed between multiple parenting
  drawables, some of which are and some of which are not
  `PlayerHandOfCards` instances, DI fails horribly at working with this
  bindable unless it is manually managed. See relevant overrides in
  `PlayerHandOfCards`.
  - I renamed one of the overloads of `HandOfCards.RemoveCard()` to
  `DetachCard()` because I found the fact that there are two overloads of
  one method that do WILDLY DIFFERENT THINGS utterly *asinine*. (One
  overload scrapes the `RankedPlayCard` out for you to plop elsewhere. One
  *drops it on the floor entirely*.)
  
  This took way too long to write.

  Bartłomiej Dach · 2026-04-22 12:48:45 +09:00
  2026.422.0-lazer f1a9be4a19