Dean Herbert
cf9c8120c5
Fix potential race condition in song bar beatmap lookup flow
...
Cancelling a web request may not necessarily cancel the callbacks.
This might help with https://github.com/ppy/osu/issues/24598 .
2023-08-31 19:04:10 +09:00
cdwcgt
5ad80879b7
let MatchIPCInfo .Beatmap be nullable
2023-08-09 19:13:49 +09:00
cdwcgt
5898a9986b
Revert "use no null when true"
...
This reverts commit 6ad8339c66
2023-08-09 19:11:36 +09:00
cdwcgt
6ad8339c66
use no null when true
2023-07-30 02:41:25 +09:00
cdwcgt
8a06914438
remove #nullable disable in tournament
2023-07-29 22:25:06 +09:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Dean Herbert
27c497145f
Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
2022-12-16 18:16:26 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Salman Ahmed
9f97d1a7db
Replace tournament beatmap storage type with lightweight model
2022-06-18 01:34:09 +03:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
e75e209053
Cache and consume IRulesetStore where feasible
2021-12-03 18:16:01 +09:00
Dean Herbert
f1499641f3
Rename all usages of APIBeatmap to beatmap in tournament namespace
2021-10-27 18:42:48 +09:00
Dean Herbert
3130616300
Update tournament components to use APIBeatmap directly
2021-10-27 18:26:44 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
ec61c3c5ee
Rename all remaining cases
2021-10-03 00:55:29 +09:00
Bartłomiej Dach
ae71389ebe
Ignore possible nulls from stream reader in IPC
...
Any failures will be caught. They're not logged, but they also weren't
before. Error handling can be improved at a future date, this series of
changes is primarily intending to unblock a new inspection.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
c9429632f4
Resolve new NRE inspections
2020-12-01 22:39:10 +01:00
Dean Herbert
fc31d49629
try-catch registry lookup to avoid crashes on non-windows platforms
2020-06-22 16:34:04 +09:00
Dean Herbert
2d121b4e3d
Simplify lookup fallback code
2020-06-22 16:32:27 +09:00
Bartłomiej Dach
eb92c3390d
Check for nulls when looking for ipc.txt
2020-06-13 17:17:58 +02:00
Bartłomiej Dach
2cadab8d29
Add xmldoc
2020-06-13 16:20:59 +02:00
Bartłomiej Dach
5dd47bf393
Remove unnecessary members
2020-06-13 16:03:34 +02:00
Bartłomiej Dach
34cd9f7a69
Streamline autodetect & manual set path
2020-06-13 15:32:30 +02:00
Bartłomiej Dach
992aa0041e
Allow auto-detect to work after choosing manually
2020-06-13 15:27:46 +02:00
Bartłomiej Dach
1cd96b8002
Rework StableInfo into a DI'd data structure
2020-06-13 15:06:07 +02:00
Bartłomiej Dach
5f79feaa8b
Merge branch 'master' into custom-ipc-location
2020-06-13 13:41:59 +02:00
Dean Herbert
9920911390
Fix tournament displayed beatmap potentially being out of order on quick changes
2020-06-04 17:20:08 +09:00
Shivam
7e5db5e933
Apply review suggestions
2020-06-03 23:49:06 +02:00
Shivam
fea5c8460a
Fixed path is empty exception
...
Also converted method to property get, private set
2020-06-01 22:50:24 +02:00
Shivam
0027f44bd0
Moved stableInfo read to FileBasedIPC
...
DI is also not needed anymore to access StableInfo, this goes through FileBasedIPC.
Note: directory selector now always navigates to the osu! lazer base path.
2020-05-31 16:27:05 +02:00
Shivam
3731e76b10
Move stable_config declaration, rename testscene
2020-05-28 15:28:27 +02:00
Shivam
7ae2383288
move stable config declaration and initial reading
2020-05-28 15:03:49 +02:00
Shivam
585100207c
make CheckExists static public and removed unnecessary code
2020-05-20 22:30:31 +02:00
Shivam
d2416ce30d
removed redundant code and use existing checkExists
2020-05-20 22:16:37 +02:00
Shivam
b1c957c5e1
invert if-statement and early return + reuse of checkExists
2020-05-20 17:25:53 +02:00
Shivam
15ebe38303
Return null if path is not found, for clarity
2020-05-20 17:13:35 +02:00
Shivam
e018d07441
Use one constant for STABLE_CONFIG location string
2020-05-20 16:30:38 +02:00
Shivam
9bfdfbea43
Move stablestorage check to path selection screen
...
Also forced stablepath to be empty during auto detection so it checks other sources to load ipc from
2020-05-18 00:47:31 +02:00
Shivam
59b006f9ac
Make IPC error dialog reusable
...
and inspectcode fixes
2020-05-17 22:46:43 +02:00
Shivam
4bc858a215
Force a read of the location file during detection
2020-05-17 22:27:44 +02:00
Shivam
c40b3b9053
Refactored stable path finding and added json config detection.
...
This also migrates the values found in the other methods to the configuration file.
2020-05-16 02:59:48 +02:00
Dean Herbert
d6840d880a
Update StableStorage implementation in line with framework changes
2020-05-08 10:40:04 +09:00
Olle Kelderman
2866d62653
Use environment variable for initializing osuInstallPath
2020-03-11 16:26:53 +01:00
Huo Yaoyuan
144812669d
Use static local functions.
2019-11-12 19:56:54 +08:00
Huo Yaoyuan
64fc5007fc
Use language primitive types.
2019-11-12 19:56:45 +08:00
Huo Yaoyuan
ccc8aa6fa4
Apply brace style.
2019-11-11 20:13:13 +08:00
Dean Herbert
47a89231ad
Read from (and allow reloading) IPC source
2019-09-23 03:17:14 +09:00
smoogipoo
ee30612a76
Add registry-based stable storage fallback
2019-06-21 15:07:12 +09:00
Dean Herbert
96e24ebd20
General namespace tidy-up
2019-06-18 14:51:48 +09:00
Dean Herbert
4f5abeb79f
Grouping -> Round
2019-06-18 14:44:15 +09:00
