Dean Herbert
a439209535
Add BannedSymbols rules for SubscribeForNotifications variants we use
2021-12-01 15:23:28 +09:00
Dean Herbert
4306420922
Add extension methods to add extra safety to realm subscriptions
...
Also adjusts the naming and documentation to make it (hopefully) easier
to understand what this method/process implies.
2021-12-01 15:09:53 +09:00
Dan Balasescu
7d0135063e
Merge pull request #15875 from peppy/fix-match-type-propagation
...
Fix match type not being propagated correctly to other users' settings
2021-12-01 11:23:28 +09:00
Dean Herbert
65054986ba
Merge pull request #15881 from peppy/fix-toast-mutation
2021-12-01 08:48:31 +09:00
Bartłomiej Dach
de034b4d9c
Fix test failures due to wrong asserts & uninitialised playlist
...
* The "create room" button was disabled headless due to not specifying
the imported beatmap. In visual tests it seems to work due to
selecting from the local database randomly.
* The test asserts are brought in line with expectations.
2021-11-30 20:57:08 +01:00
Bartłomiej Dach
b74b09eb3a
Add extra until step to make cause of potential failures more obvious
2021-11-30 20:56:11 +01:00
Bartłomiej Dach
faba2aa916
Merge branch 'master' into fix-toast-mutation
2021-11-30 19:32:17 +01:00
Bartłomiej Dach
c2afd7bbdc
Merge pull request #15882 from peppy/fix-invalid-screen-exist-multiplayer-test
...
Fix double screen exit in multiplayer song select tests potentially causing failure
2021-11-30 19:24:44 +01:00
Dean Herbert
dda7142f48
Fix double screen exit in multiplayer song select tests potentially causing failure
2021-12-01 02:06:40 +09:00
Dean Herbert
03e1305b3f
Fix toast display potentially causing a child mutation before load complete
2021-12-01 01:55:17 +09:00
Dean Herbert
6507acab01
Merge pull request #15880 from frenzibyte/ios-ci
2021-12-01 01:45:45 +09:00
Salman Ahmed
d18417aa27
Enable build-only iOS CI
2021-11-30 18:41:04 +03:00
Dan Balasescu
857e559f87
Merge pull request #15877 from peppy/log-response-sizes
...
Log output API request response sizes
2021-11-30 19:58:29 +09:00
Dan Balasescu
a944dd247c
Merge pull request #15851 from peppy/realm-integration/live-queryable-fix
...
Apply fixes to `RealmLive<T>` to more correctly support querying data within `PerformRead`
2021-11-30 19:49:18 +09:00
Dean Herbert
23e297d414
Log output response sizes
...
Visibility is the first step towards action. Or something.
2021-11-30 19:09:13 +09:00
Dan Balasescu
8fdb9ab4e5
Merge branch 'master' into realm-integration/live-queryable-fix
2021-11-30 18:54:14 +09:00
Dan Balasescu
f849ff67d5
Merge pull request #15853 from peppy/realm-nested-context-creation-deadlock-fix
...
Fix potential deadlock on nested context creation requests
2021-11-30 18:53:57 +09:00
Dan Balasescu
daa7135381
Merge branch 'master' into realm-nested-context-creation-deadlock-fix
2021-11-30 18:01:00 +09:00
Dean Herbert
8de06803a8
Fix incorrect test step text
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-11-30 17:16:30 +09:00
Dean Herbert
25b9575de0
Fix missing transfer of match type to settings
2021-11-30 17:09:40 +09:00
Dean Herbert
049d9ce5ef
Add test coverage of match type propagating to other users' settings
2021-11-30 17:09:32 +09:00
Dan Balasescu
5d5f958e44
Merge pull request #15873 from peppy/realm-refresh
...
Fix main thread realm not being refreshed
2021-11-30 15:08:32 +09:00
Dean Herbert
0feec09966
Refactor beatmap importer tests to ensure realm is refreshed when waiting on state
2021-11-30 14:12:49 +09:00
Dean Herbert
6e4cd91b7b
Fix update thread realm context never being Refresh()ed
2021-11-30 14:12:36 +09:00
Dean Herbert
384a0664c2
Remove unused migration method
2021-11-30 14:05:44 +09:00
Dan Balasescu
ffd26e83b1
Merge pull request #15872 from peppy/fix-chat-dropdown
...
Fix chat tab dropdown not being reachable at default sizing
2021-11-30 13:47:31 +09:00
Dan Balasescu
f7b0d567bb
Merge pull request #15871 from peppy/fix-wedge-test-intermittent-failure
...
Fix intermittent test failures in `TestSceneBeatmapInfoWedge` due to async load
2021-11-30 13:47:17 +09:00
Dean Herbert
f921acc681
Fix chat tab dropdown not being reachable at default sizing
...
Would have liked to fix this in a more local way, but the structure of
the dropdowns is just a pain in the ass to work with, so this will do
for now.
2021-11-30 13:01:46 +09:00
Dean Herbert
a73919917c
Fix intermittent test failures in TestScenBeatmapInfoWedge due to async load
...
https://github.com/ppy/osu/runs/4358685294?check_suite_focus=true
Occurs due to the wedge content also reloading on ruleset change, which
wasn't being accounted for. In a fail case, the content would change
during the "select beatmap" step's async load wait, causing incorrect
results.
51a353e12d/osu.Game/Screens/Select/BeatmapInfoWedge.cs (L70)
2021-11-30 12:32:09 +09:00
Dean Herbert
eb596bed9e
Merge pull request #15864 from bdach/beatmap-card/difficulty-list
...
Implement beatmap card difficulty list
2021-11-30 12:11:14 +09:00
Dean Herbert
6b0999052f
Merge branch 'master' into realm-integration/live-queryable-fix
2021-11-30 12:02:37 +09:00
Dean Herbert
f3f77fa053
Update missed xmldoc/comments
2021-11-30 11:56:53 +09:00
Dean Herbert
2e31f5a338
Update tests to match new behaviour
2021-11-30 11:55:13 +09:00
Dean Herbert
35d68d6ab0
Remove all optimisations from RealmLive
2021-11-30 11:47:29 +09:00
Bartłomiej Dach
45656c3599
Fix difficulty spectrum display not ordering ruleset groups by ID
2021-11-29 22:06:11 +01:00
Bartłomiej Dach
0fc4d6dc2a
Implement beatmap card difficulty list
2021-11-29 22:04:09 +01:00
Bartłomiej Dach
431ac1d97b
Remove unused using directive
2021-11-29 20:57:55 +01:00
Dan Balasescu
823552a5e8
Merge pull request #15856 from peppy/simplify-replace-file
...
Remove the ability to specify a filename in `ReplaceFile`
2021-11-29 20:49:38 +09:00
Dan Balasescu
0ee524a72f
Merge pull request #15857 from peppy/realm-importer-remove-pointless-fast-hash
...
Remove `computeHashFast` usage in `RealmArchiveModelImporter.ComputeHash`
2021-11-29 18:58:40 +09:00
Dan Balasescu
8a188b74b1
Merge pull request #15850 from peppy/realm-integration/misc-qol
...
Apply a couple of realm related documentation/interface changes
2021-11-29 18:58:15 +09:00
Dean Herbert
566e10f8cc
Refactor test to be easier to follow
2021-11-29 18:55:23 +09:00
Dean Herbert
0bcfb8e199
Fix regression in implementation of fix
2021-11-29 18:52:29 +09:00
Dean Herbert
23fded4a3a
Fix potential oversight in semaphore release logic
2021-11-29 18:26:37 +09:00
Dean Herbert
94b10492be
Update legacy SkinManager to match new interface
2021-11-29 18:20:07 +09:00
Dean Herbert
bac7966337
Update RealmLiveTests to use interface type
2021-11-29 18:17:30 +09:00
Dan Balasescu
e2cb420c06
Merge pull request #15855 from peppy/live-post-construction-attach
...
Fix `RealmLive` not working if data is attached to realm post-`ToLive` call
2021-11-29 18:14:08 +09:00
Dean Herbert
6aad90674e
Remove computeHashFast usage in RealmArchiveModelImporter.ComputeHash
2021-11-29 18:13:27 +09:00
Dean Herbert
a7e4e7be3a
Remove the ability to specify a filename in ReplaceFile
2021-11-29 18:11:51 +09:00
Dean Herbert
f19cfcc82e
Make readonly
2021-11-29 17:38:54 +09:00
Dean Herbert
673481ebc5
Use ThreadLocal to avoid potential threading issues
2021-11-29 17:38:42 +09:00
