1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 18:12:59 +08:00
Commit Graph

7263 Commits

Author SHA1 Message Date
Dean Herbert
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dean Herbert
8399261c77 Add failing test showing hold for menu not working when HUD is hidden 2022-10-30 21:38:31 +09:00
Dean Herbert
f5e11343c2 Apply nullability to HUD test scene 2022-10-30 21:25:31 +09:00
Dean Herbert
f9d2c30c3e Add user toggle for application of safe areas 2022-10-28 14:05:45 +09:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts 2022-10-26 21:30:24 +02:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts 2022-10-25 22:17:08 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone 2022-10-25 21:33:52 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey 2022-10-25 20:32:32 +02:00
Dean Herbert
2b850694fa Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts 2022-10-25 14:10:45 +09:00
Dean Herbert
8e4f5381e3 Add top level test coverage of editor shortcuts 2022-10-25 12:03:46 +09:00
Dean Herbert
1b42f5ec6e Add test coverage of BeatDivisorControl key bindings 2022-10-25 11:51:31 +09:00
Dean Herbert
4d4f6e25ba Rename to "clone" instead of "duplicate" 2022-10-25 11:43:23 +09:00
Dean Herbert
da74690ec9 Add test coverage of clone operations 2022-10-25 11:38:58 +09:00
Dan Balasescu
f6f30eec0b
Merge pull request #20810 from peppy/scoring-test-scene
Add test scene as environment to test changes to score algorithms
2022-10-25 11:19:00 +09:00
Endrik Tombak
b95091fbb0 Move test to improve diff readability 2022-10-24 22:55:09 +03:00
Endrik Tombak
9def12c60b Write new tests 2022-10-24 22:50:56 +03:00
Dean Herbert
f08270f6b0 Fix incorrect maxBaseScore accounting due to silly oversight 2022-10-24 15:54:09 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle 2022-10-24 15:33:10 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard
Improve automatic cursor hiding logic and limit to gameplay screen
2022-10-20 11:44:20 +09:00
Salman Ahmed
212f15e2d2 Update existing test cases 2022-10-20 04:06:33 +03:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item 2022-10-20 10:02:09 +09:00
Dean Herbert
bea136ce50 Adjust test assert ordering to read better 2022-10-19 23:59:40 +09:00
Dean Herbert
f23bc484dc Use better method of positioning mouse over visual settings area 2022-10-18 19:15:11 +09:00
Dean Herbert
d5666ca717 Add tooltip display of current values 2022-10-18 19:04:02 +09:00
Dean Herbert
d92aca7c22 Fix scoreV2 being higher than intended 2022-10-18 18:30:18 +09:00
Dean Herbert
74e1b5794b Add ability to add "OK" or 100s via right click 2022-10-18 18:27:05 +09:00
Dean Herbert
a7b3aa62fb Move lines to background to better visualise graphs at points of change 2022-10-18 18:13:13 +09:00
Dean Herbert
74986e0c8c Show final scores and change colouring again 2022-10-18 18:07:42 +09:00
Dean Herbert
4b2fe72a90 Add stable v2 algorithm 2022-10-18 18:02:42 +09:00
Dean Herbert
743ae10df5 Improve colouring 2022-10-18 17:50:59 +09:00
Dean Herbert
7360cca047 Add stable v1 algorithm 2022-10-18 17:50:58 +09:00
Dean Herbert
d694c8b771 Move test scene more correctly into visual folder 2022-10-18 17:10:53 +09:00
Dean Herbert
ec3761ced9 Standardise control point search logic in OverlappingScrollAlgorithm
Was using a very local algorithm which I cannot guarantee is correct.
I'd rather it just use the one used everywhere else.
2022-10-18 16:01:05 +09:00
Dan Balasescu
28277dd880 Fix tests 2022-10-17 19:34:05 +09:00
Salman Ahmed
421b81b6ca Fix broken test case 2022-10-15 00:41:14 +03:00
Salman Ahmed
45f590ca43 Add test case for hiding cursor on idle 2022-10-15 00:20:22 +03:00
Salman Ahmed
97c4282e55 Add test cases for hiding cursor on keyboard input 2022-10-15 00:20:22 +03:00
Salman Ahmed
ba72f13f54 Merge branch 'master' into hide-mouse-on-keyboard-input 2022-10-14 22:26:30 +03:00
Dan Balasescu
10aabfc650
Merge pull request #20739 from peppy/settings-toolbox
Adjust visuals of settings toolboxes (gameplay loading screen and editor)
2022-10-14 20:31:05 +09:00
Bartłomiej Dach
df66a0c2e9
Fix flaky update beatmap set test
It is generally not possible to click a button that's not yet there,
and it turns out that when the test in question is ran headless, it may
not necessarily be there immediately.
2022-10-13 21:03:52 +02:00
Dean Herbert
6608ada925 Fix test failures due to missing colour provider dependency 2022-10-13 17:05:11 +09:00
Dean Herbert
0f4a2a6059 Improve feel of settings toolbox group 2022-10-13 16:36:19 +09:00
Dean Herbert
ebc1088457
Merge pull request #20729 from frenzibyte/update-local-confirmation-dialog
Request user confirmation on updating locally-modified beatmaps
2022-10-13 12:36:37 +09:00
Salman Ahmed
7db7bcc283 Add test coverage 2022-10-13 02:40:20 +03:00
Feodor0090
565de23222
Fix CQ (non-readonly field) 2022-10-12 21:26:33 +03:00
Dean Herbert
00d8398056 Update test scene to allow seeing loading spinner 2022-10-12 15:48:42 +09:00
Dean Herbert
47fe4eb0bd Merge branch 'master' into comment-deletion 2022-10-12 15:48:26 +09:00
Salman Ahmed
9b45a9cf76 Rename various cursor symbols
- `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
 - `MenuCursor` -> `MenuCursorContainer
2022-10-11 16:21:01 +03:00