72014 Commits

This Branch

This Branch

All Branches

• Merge pull request #32135 from zihadmahiuddin/fix/settings-show-at-visibility

  Fix settings control not visible because of previous search

  Bartłomiej Dach · 2025-03-03 13:29:26 +01:00
  a33e76717c
• Merge pull request #32162 from nekodex/kiai-sfx

  Add SFX for kiai/star fountain activation

  Dean Herbert · 2025-03-03 19:05:05 +09:00
  6aaec144c8
• Update resources
  Dean Herbert · 2025-03-03 18:54:46 +09:00
  f32a8e8741
• Merge pull request #32152 from peppy/song-select-v2-test

  Make `TestSceneSongSelect` work with local database

  Dan Balasescu · 2025-03-03 16:21:11 +09:00
  9c28ac4a72
• Merge pull request #32153 from peppy/carousel-design-fixes

  Apply first wave blanket fixes to new beatmap carousel design

  Bartłomiej Dach · 2025-03-03 08:13:43 +01:00
  8539745667
• Merge pull request #32192 from smoogipoo/more-beatmap-load-cancellations

  Cancel beatmap load in more loops

  Dean Herbert · 2025-03-03 16:10:06 +09:00
  8b04b75d27
• Cancel ApplyDefaults() when requested

  Also didn't notice a particular case here, but if all code passes up
  until we get to the `foreach (var h in nestedHitObjects)` below, then we
  could end up stuck here for quite a while.

  Dan Balasescu · 2025-03-03 14:46:13 +09:00
  033952029e
• Cancel slider generation when requested

  Didn't notice a particular case with this one, just came up as I was
  looking through code.

  Dan Balasescu · 2025-03-03 14:19:43 +09:00
  52dad09b20
• Exit loop when cancellation requested

  The following manages to create all hitobjects but proceeds to get stuck
  in this method:
  
  `dotnet run -- difficulty 1607040 -r:2`

  Dan Balasescu · 2025-03-03 14:19:19 +09:00
  ad9a963bd0
• Add SFX for kiai/star fountain activation
  Jamie Taylor · 2025-03-01 01:51:37 +09:00
  881534eb7f
• Adjust set panel display and animations slightly
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  38de3566b1
• Remove unused container level
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  4beac64bdb
• Fix activation flash being applied twice (and adjust duration)
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  29c35529d2
• Stop using padding for panel x offsets
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  8032b68932
• use Bindable.SetDefault for clearing search text
  Zihad · 2025-02-28 19:04:47 +06:00
  0d7c00ae09
• make SettingsPanel.SearchTextBox's setter private
  Zihad · 2025-02-28 19:03:39 +06:00
  88089fb014
• Merge pull request #32109 from smoogipoo/results-beatmap-lookup

  Fix multiplayer results screen displaying same beatmap for all users

  Bartłomiej Dach · 2025-02-28 12:36:28 +01:00
  c4e37a1566
• Pass through artist/title in beatmap transform
  Dan Balasescu · 2025-02-28 18:40:54 +09:00
  993473c081
• Make TestSceneSongSelect work with local database

  It was pointless before.

  Dean Herbert · 2025-02-28 17:55:21 +09:00
  8fc744e9dc
• Fix status pills displaying wrong
  Dean Herbert · 2025-02-28 16:47:57 +09:00
  0e257038e8
• Fix carousel taking up too much space on new song select implementation
  Dean Herbert · 2025-02-28 16:45:49 +09:00
  51cb0bea1c
• Adjust animation duration to roughly match scroll operations

  Previous value felt wrong when using keyboard selection for iteration.

  Dean Herbert · 2025-02-28 16:27:42 +09:00
  1e46dc6b0a
• Add better selection visibility via another tint layer
  Dean Herbert · 2025-02-28 16:27:18 +09:00
  a8fbac0f0d
• Merge pull request #32149 from peppy/preview-time-display

  Adjust preview time display to not conflict with bookmarks

  Dan Balasescu · 2025-02-28 16:14:44 +09:00
  89b6d7caee
• Adjust x offsets to work again for keyboard selection
  Dean Herbert · 2025-02-28 16:08:11 +09:00
  02b950223c
• Merge pull request #32151 from peppy/mania-barline

  Add support for legacy osu!mania barline height and colour spec

  Dan Balasescu · 2025-02-28 16:05:47 +09:00
  f9c73e6501
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Adjust preview time display to not conflict with bookmarks
  Dean Herbert · 2025-02-28 14:05:49 +09:00
  e1723ec1bb
• Fix settings control not visible because of previous search

  This also makes `SettingsPanel`'s `SearchTextBox` protected from private so that `SettingsOverlay` can access it.

  Zihad · 2025-02-28 00:24:12 +06:00
  0913174099
• Merge pull request #32130 from bdach/fix-sliders-visible-but-not-selectable-harder
  Dean Herbert · 2025-02-28 00:38:03 +09:00
  7f99e60cfd
• Fix sliders not being selectable if the body is hidden but the head is still visible

  Closes https://github.com/ppy/osu/issues/31998.
  
  Previously: https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02,
  https://github.com/ppy/osu/pull/31923.
  
  Oh input handling, how I love ya.

  Bartłomiej Dach · 2025-02-27 15:00:29 +01:00
  5b318edbfb
• Merge pull request #32110 from bdach/combo-colour-count-limit

  Limit number of allowed beatmap combo colours to 8

  Bartłomiej Dach · 2025-02-27 12:13:06 +01:00
  79b737bc27
• Disable button instead of hiding (and add tooltip)
  Dean Herbert · 2025-02-27 15:15:58 +09:00
  0b453772da
• Fix typo
  Dan Balasescu · 2025-02-27 13:16:51 +09:00
  d3c4afe65d
• Merge pull request #32111 from bdach/prevent-closing-team-channels-harder

  Prevent closing team chat channels via Ctrl-W

  Dean Herbert · 2025-02-27 12:55:54 +09:00
  2025.227.0 66b8b527e3
• Merge pull request #31595 from ppy/pp-dev

  January 2025 Diffcalc/PP release

  Dean Herbert · 2025-02-27 01:17:42 +09:00
  003adadbf3
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-27 00:08:43 +09:00
  87b6dddd11
• Prevent closing team chat channels via Ctrl-W

  As pointed out in
  https://github.com/ppy/osu/pull/32079#issuecomment-2680297760.
  
  The comment suggested putting that logic in `ChannelManager` but
  honestly I kinda don't see it working out. It'd probably be multiple
  boolean arguments for `leaveChannel()` (because `sendLeaveRequest` or
  whatever already exists), and then there's this one usage in tournament
  client:
  
  	https://github.com/ppy/osu/blob/31aded69714cf205c215893368d1f148c9a73319/osu.Game.Tournament/Components/TournamentMatchChatDisplay.cs#L57-L58
  
  I'm not sure how that would interact with this particular change, but I
  think there is a nonzero possibility that it would interact badly. So in
  general I kinda just prefer steering clear of all that and adding a
  local one-liner.

  Bartłomiej Dach · 2025-02-26 12:06:50 +01:00
  f3632a466f
• Merge pull request #32108 from peppy/adjust-leaderboard-design-slightly

  Adjust leaderboard score design slightly

  Bartłomiej Dach · 2025-02-26 11:28:39 +01:00
  31aded6971
• Do not allow adding more than 8 combo colours in editor
  Bartłomiej Dach · 2025-02-26 11:24:06 +01:00
  6b76b8ccdd
• Limit beatmap encoder & decoder to at most 8 combo colours
  Bartłomiej Dach · 2025-02-26 11:13:57 +01:00
  2167c7b8d5
• Add failing encoder test case for too many combo colours
  Bartłomiej Dach · 2025-02-26 11:10:33 +01:00
  e48d36ad1e
• Cleanup score fetching a bit
  Dan Balasescu · 2025-02-26 18:58:29 +09:00
  c2875423ee
• Add failing decoder test case for too many combo colours
  Bartłomiej Dach · 2025-02-26 10:56:28 +01:00
  76bf03b05d
• Merge pull request #32107 from peppy/fix-player-team-flag-replay

  Fix `PlayerTeamFlag` skinnable component not showing team details during replay

  Bartłomiej Dach · 2025-02-26 10:36:49 +01:00
  38d807e846
• Add support to tests

  Somewhat informal because it isn't super easy to handle.

  Dan Balasescu · 2025-02-26 18:31:06 +09:00
  c280c8fa1c
• Replace error handling with logs

  - Handling all errors matches master a little bit better. Logging
  exceptions in any case.
  - Not throwing when beatmaps are missing simplifies tests.

  Dan Balasescu · 2025-02-26 18:02:13 +09:00
  3dde024650
• Mostly revert sizes
  Dean Herbert · 2025-02-26 18:00:18 +09:00
  c45a403fe2
• Add missing ConfigureAwait
  Dan Balasescu · 2025-02-26 17:39:56 +09:00
  c7fd7cf9cd