1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 05:57:52 +08:00
Commit Graph

208 Commits

Author SHA1 Message Date
Andrei Zavatski
26afe0f31e Add ability to load long comment trees in CommentsContainer 2020-02-10 15:43:11 +03:00
Andrei Zavatski
5946ad7d80 Fix possible memory leak and better user change test support 2020-02-06 16:54:02 +03:00
Andrei Zavatski
a84068448a refetch comments on user change 2020-02-04 19:19:49 +03:00
Andrei Zavatski
5e369534b6 Allow guests to view comments 2020-02-04 19:15:23 +03:00
Andrei Zavatski
3b5b799d60 Adjust height of ShowMore button 2020-01-31 09:51:56 +03:00
Andrei Zavatski
4a444face1 Change ShowMoreButton hide logic 2020-01-31 09:46:35 +03:00
Andrei Zavatski
a8578c1526 Merge master with conflicts resolved 2020-01-30 10:08:02 +03:00
Dean Herbert
ebdb425c50 Rename and tidy up DeletedCommentsCounter 2020-01-30 11:17:26 +09:00
Andrei Zavatski
5fcda01346 Cleanup pass 2020-01-29 06:58:53 +03:00
Andrei Zavatski
dc10e58b4f Add tests for CommentsPage 2020-01-29 06:44:39 +03:00
Andrei Zavatski
e7964023ae Implement CommentsPage class 2020-01-29 06:22:08 +03:00
Andrei Zavatski
c5e0c77bca Refactor NoCommentsPlaceholder 2020-01-29 06:08:11 +03:00
Andrei Zavatski
b947e89a6b Add placeholder for no comments case in CommentsContainer 2020-01-28 16:53:22 +03:00
Andrei Zavatski
5a2fd18bdd Allow better async support for CommentsContainer 2020-01-28 10:21:27 +03:00
Andrei Zavatski
ce95b4a106 TotalCommentsCounter improvements 2020-01-28 05:57:45 +03:00
Andrei Zavatski
100532845b Recolour CommentsContainer 2020-01-27 15:07:24 +03:00
Andrei Zavatski
68503bf771 Recolour CommentsShowMoreButton 2020-01-27 15:00:56 +03:00
Andrei Zavatski
12ca28ea6d Recolour CommentsHeader 2020-01-27 14:58:27 +03:00
Andrei Zavatski
ed2737e027 Recolour TotalCommentCounter 2020-01-27 14:47:47 +03:00
Dean Herbert
5863576ce4 Add comment as to why counter is zeroes only in Show method 2020-01-24 11:42:33 +09:00
Andrei Zavatski
6493f24547 Add TotalCommentsCounter to CommentsContainer 2020-01-23 15:56:01 +03:00
Andrei Zavatski
0c3120d965 Fix possible crash due to not loaded api 2020-01-23 12:59:53 +03:00
Andrei Zavatski
667fdb907c Call the method directly rather that trigger a bindable 2020-01-23 12:21:16 +03:00
Andrei Zavatski
7dc03a1335 resetComments -> refetchComments 2020-01-07 12:30:06 +03:00
Andrei Zavatski
6adf5ba381 Use nullable long type for id value 2020-01-07 12:29:21 +03:00
Andrei Zavatski
e0f66928e6 Allow CommentsContainer refetch comments using a method 2020-01-07 01:07:50 +03:00
Andrei Zavatski
031bed15da Fix comments async loading wasn't really async 2020-01-06 20:56:32 +03:00
Dean Herbert
b85189f855 Merge remote-tracking branch 'upstream/master' into fix-spritetext-usage 2019-11-25 11:31:12 +09:00
Dean Herbert
45514ff660 Apply fixes 2019-11-25 11:30:55 +09:00
Dean Herbert
c2e85a2057 Apply CornerExponent fixes 2019-11-22 19:49:20 +09:00
Andrei Zavatski
509440ea14 TotalCommentsCounter implementation 2019-11-16 18:02:34 +03:00
Huo Yaoyuan
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
Dean Herbert
5c47641608
Reorder conditional 2019-11-09 16:23:22 +09:00
Andrei Zavatski
4330507da8 Use api.IsLoggedIn 2019-11-06 12:46:25 +03:00
Andrei Zavatski
4730453083 Apply suggestions 2019-10-31 02:10:00 +03:00
Andrei Zavatski
8ad5ccda68 Test steps rearrangement and condition fix 2019-10-30 04:16:14 +03:00
Andrei Zavatski
2c31492bbe Fix comment can be voted if user is null 2019-10-30 03:27:06 +03:00
Andrei Zavatski
1502a6c631 Cleanups 2019-10-30 03:09:14 +03:00
Andrei Zavatski
092d16bb64 Dont use binding to set disabled value 2019-10-29 23:43:16 +03:00
Andrei Zavatski
30d9b21b86 Condition simplification 2019-10-29 21:57:20 +03:00
Andrei Zavatski
e287dae64b Fix VotePill can be activated by the comment sender 2019-10-29 21:25:48 +03:00
Andrei Zavatski
85769982a0 Refactor LoadingButton 2019-10-24 17:49:34 +03:00
Andrei Zavatski
b310fd9d44 Adjust naming inside the LoadingButton 2019-10-23 13:39:42 +03:00
Andrei Zavatski
9daafb4636 Simplify hover/unhover logic 2019-10-18 03:06:01 +03:00
Andrei Zavatski
22511e41e2 Use received data to set isVoted bindable 2019-10-17 23:20:01 +03:00
Andrei Zavatski
9ee63a8c1a Apply suggested changes 2019-10-17 16:28:32 +03:00
Andrei Zavatski
a858e713f8 Fix multiple spaces 2019-10-17 15:40:09 +03:00
Andrei Zavatski
6b196a6ce7 CI fixes 2019-10-17 15:24:51 +03:00
Andrei Zavatski
42cd4107a0 Implement CommentVoteRequest and adjust UI 2019-10-17 15:04:30 +03:00
Andrei Zavatski
a437ff74cc Move VotePill to it's own file 2019-10-17 14:18:31 +03:00
Andrei Zavatski
1f28c00594 UI implementation 2019-10-17 13:10:28 +03:00
Andrei Zavatski
38dcd42d08 Parse voted comments 2019-10-17 12:35:12 +03:00
Andrei Zavatski
2543de22bd Simplify DeletedChildrenPlaceholder behavior 2019-10-15 12:47:35 +03:00
Andrei Zavatski
7ba15df0c0 Convert to method group 2019-10-15 12:27:32 +03:00
Andrei Zavatski
d321794ef5 Make loadedTopLevelComments a local filed 2019-10-15 12:26:16 +03:00
Andrei Zavatski
96e31b9cca Add support for deleted comments with message 2019-10-15 12:07:01 +03:00
Andrei Zavatski
213f00556d Remove onShowDeletedChanged function 2019-10-15 11:30:50 +03:00
Andrei Zavatski
b2885e7b13 Move load() under the ctor 2019-10-15 11:26:58 +03:00
Andrei Zavatski
eb5dad08aa Remove initial filed 2019-10-15 11:25:58 +03:00
Andrei Zavatski
3c714dc013 APICommentsController -> CommentBundle 2019-10-15 11:20:06 +03:00
Andrei Zavatski
ad32d66365 CI fix 2019-10-15 01:10:23 +03:00
Andrei Zavatski
0fd6b0c852 Use linq expression to count deleted comments 2019-10-15 00:55:33 +03:00
Andrei Zavatski
b84c9dfd84 Use Humanizer.ToQuantity instead of manual parsing 2019-10-15 00:35:44 +03:00
Andrei Zavatski
09621f066e Childs -> Children 2019-10-15 00:32:21 +03:00
Andrei Zavatski
d4843285db CI fixes 2019-10-14 17:33:14 +03:00
Andrei Zavatski
139170cdc8 Fix incorrect padding for nested comments 2019-10-14 17:26:12 +03:00
Andrei Zavatski
b53fb0d228 Remove empty line 2019-10-14 17:07:50 +03:00
Andrei Zavatski
a81d5cd819 Handle links in message 2019-10-14 16:56:07 +03:00
Andrei Zavatski
7cd3f5656d Cleanups 2019-10-14 16:43:43 +03:00
Andrei Zavatski
7ac87494e0 Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api 2019-10-14 16:21:34 +03:00
Dean Herbert
f0e9700349 Inline delegate event 2019-10-14 21:49:02 +09:00
Dean Herbert
b7ddf160b4 OnClick should actually handle the event 2019-10-14 21:48:12 +09:00
Dean Herbert
4e6ab1dad3 Tidy up state management via bindable usage 2019-10-14 21:42:07 +09:00
Dean Herbert
7794457550 Remove more constants 2019-10-14 21:36:10 +09:00
Dean Herbert
4822496c13 Fix more naming 2019-10-14 21:34:16 +09:00
Dean Herbert
89f270a19a SortSelector -> SortTabControl 2019-10-14 21:32:41 +09:00
Dean Herbert
e191c2c50e Tidy up constants and method naming 2019-10-14 21:32:16 +09:00
Andrei Zavatski
328b4d6863 Cancel request on dispose 2019-10-13 16:22:10 +03:00
Andrei Zavatski
a44cc2e70b Implement CommentsShowMoreButton 2019-10-13 14:43:30 +03:00
Andrei Zavatski
60954f969d DeletedChildsPlaceholder refactor 2019-10-13 12:38:50 +03:00
Andrei Zavatski
795ce81468 Use async loading for comment pages 2019-10-13 12:10:01 +03:00
Andrei Zavatski
4d971e49ff Colours update 2019-10-13 11:50:27 +03:00
Andrei Zavatski
27e3ffd293 Update dependencies 2019-10-13 11:23:49 +03:00
Andrei Zavatski
b45e7246b8 Rename SortCommentsBy to CommentsSortCriteria 2019-10-10 15:56:08 +03:00
Andrei Zavatski
fe7b4037f7 CI fix 2019-10-10 13:24:22 +03:00
Andrei Zavatski
64f62bd2bf Implement CommentsHeader component 2019-10-10 12:06:25 +03:00
Andrei Zavatski
f6b78ad661 Overall cleanups 2019-10-10 11:43:45 +03:00
Andrei Zavatski
107d39c3e9 Add DeletedChildsPlaceholder to the bottom of the comments container 2019-10-09 14:10:05 +03:00
Andrei Zavatski
c9d5bea0f1 Remove animations 2019-10-09 13:45:14 +03:00
Andrei Zavatski
7e3c97f496 Implement DeletedChildsPlaceholder component 2019-10-09 13:37:07 +03:00
Andrei Zavatski
b2bd78308d Handle deleted comments 2019-10-09 12:18:49 +03:00
Andrei Zavatski
ad99a3236f Handle edited comments 2019-10-09 11:32:17 +03:00
Andrei Zavatski
a0dfbfe148 Handle parent usernames for legacy comments 2019-10-09 11:18:26 +03:00
Andrei Zavatski
0a56b041fd Implement ShowChildsButton 2019-10-09 11:07:56 +03:00
Andrei Zavatski
4462d454e8 Message padding improvements 2019-10-09 10:34:17 +03:00
Andrei Zavatski
29b0eacc82 Implement SortSelector component 2019-10-08 22:46:42 +03:00
Andrei Zavatski
574170124c Implement HeaderButton component 2019-10-08 21:38:19 +03:00
Andrei Zavatski
b9ad079bf8 Move CommentsHeader to it's own file 2019-10-08 20:57:55 +03:00
Andrei Zavatski
9ab309fc0e Use bold font for replies button 2019-10-08 20:44:01 +03:00
Andrei Zavatski
35cfb16c8d Implement VotePill component 2019-10-08 19:56:43 +03:00
Andrei Zavatski
4230b00110 Rename APIComments to APICommentsController 2019-10-08 19:22:23 +03:00
Andrei Zavatski
341702b91d Use Bindable for expansion logic 2019-10-08 19:18:46 +03:00
Andrei Zavatski
000e4a563c Parse parent comments 2019-10-08 19:09:02 +03:00
Andrei Zavatski
3f8fecbc50 Adjust spacing 2019-10-08 16:04:52 +03:00
Andrei Zavatski
9c7e403cf8 Implement replies button 2019-10-08 16:00:34 +03:00
Andrei Zavatski
451a7342ce Parse child comments 2019-10-08 15:39:03 +03:00
Andrei Zavatski
2564214a72 Fix some padding issues with the big comments 2019-10-08 15:01:18 +03:00
Andrei Zavatski
1c89841949 Move all the logic to it's own namespace 2019-10-08 14:51:12 +03:00