51230 Commits

This Branch

This Branch

All Branches

• Remove schedule in panel load

  It was causing selection/deselection of all mods to work improperly if a
  select/deselect all operation was requested before the panel was
  scrolled into view.
  
  In general the schedule was an over-optimisation - the game-global set
  of available mods shouldn't be changing so often as to warrant such an
  aggressive debounce.

  Bartłomiej Dach · 2022-05-07 09:50:09 +02:00
  9f96dd47d1
• Add test coverage for selecting/deselecting all mods on free mod select
  Bartłomiej Dach · 2022-05-07 09:50:08 +02:00
  e1953c484c
• Add test coverage for deselecting all mods on user mod select
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  35c106efaa
• Add select/deselect all buttons to free mod select screen
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  852e4a9766
• Add some more padding between footer and column scroll
  Bartłomiej Dach · 2022-05-07 09:29:33 +02:00
  0b95594f60
• Move footer button padding to a higher level
  Bartłomiej Dach · 2022-05-07 09:29:32 +02:00
  0c6de331f3
• Merge pull request #18065 from huoyaoyuan/code-style

  Enforce code style analysis shipped with .NET SDK

  Dean Herbert · 2022-05-07 14:58:19 +09:00
  dd63657dfb
• Merge pull request #18126 from bdach/mod-overlay/fix-broken-mod-reference-logic

  Fix several issues with new mod select reference replacement logic

  Dean Herbert · 2022-05-07 14:36:05 +09:00
  2dd9899cd7
• Merge pull request #18125 from frenzibyte/fix-overlay-horizontal-offset-overlays

  Fix side overlay offset not affecting fullscreen overlays

  Dean Herbert · 2022-05-07 14:02:22 +09:00
  34237fd05e
• Use above-1 offset instead for more correct feeling parallax
  Dean Herbert · 2022-05-07 14:02:07 +09:00
  ce14fddcb2
• Fix sequence equality check not using reference comparison
  Bartłomiej Dach · 2022-05-06 21:47:04 +02:00
  8c73ed7207
• Do not modify selected mods through panel state change during external update
  Bartłomiej Dach · 2022-05-06 21:47:04 +02:00
  621f746789
• Simplify state management in ModColumn

  Bad sign when you can't follow your own code.
  
  All of the various state changing methods were flattened into one
  because it was too hard to follow what was calling what and why.

  Bartłomiej Dach · 2022-05-06 21:46:16 +02:00
  c199b8fcb6
• Add test coverage for lack of customisation on free mod select
  Bartłomiej Dach · 2022-05-06 21:35:22 +02:00
  380cd1e036
• Apply offset by a factor of 0.8x from screen offset
  Salman Ahmed · 2022-05-06 22:20:09 +03:00
  8080f784fd
• Fix side overlay offsetting not affecting fullscreen overlays
  Salman Ahmed · 2022-05-06 21:42:20 +03:00
  049fed42e2
• Merge pull request #18120 from peppy/fix-toolbox-expansion

  Fix user-contracted toolbox groups in editor incorrectly expanding on hover

  Salman Ahmed · 2022-05-06 18:44:09 +03:00
  404798395c
• Merge branch 'master' into fix-toolbox-expansion
  Salman Ahmed · 2022-05-06 18:00:01 +03:00
  1409f8ca96
• Merge pull request #18122 from bdach/mod-overlay/leftover-mod-area-border

  Remove leftover border thickness spec in mod settings area

  Dean Herbert · 2022-05-06 23:58:35 +09:00
  bda57dd970
• Merge branch 'master' into fix-toolbox-expansion
  Salman Ahmed · 2022-05-06 17:54:14 +03:00
  f222affe88
• Merge pull request #18103 from peppy/distance-snapping-test

  Fix distance snapping grid providing incorrect time values for non-1.0x spacing

  Salman Ahmed · 2022-05-06 17:53:44 +03:00
  a7c7fc745b
• Merge branch 'master' into distance-snapping-test
  Salman Ahmed · 2022-05-06 17:29:27 +03:00
  144d33f0d2
• Merge pull request #18121 from peppy/editor-drag-box

  Fix editor drag box visuals

  Bartłomiej Dach · 2022-05-06 15:52:26 +02:00
  9961545147
• Remove leftover border thickness spec in mod settings area

  Was never supposed to be there, it was a vestige of a previous design
  iteration that went by unnoticed.

  Bartłomiej Dach · 2022-05-06 15:34:49 +02:00
  c533c93ffd
• Merge branch 'master' into editor-drag-box
  Bartłomiej Dach · 2022-05-06 15:22:39 +02:00
  56fa5c9db1
• Halve drag box padding

  Allows the drag box borders to collapse in on themselves to a single
  line if the drag selection has zero width or height.

  Bartłomiej Dach · 2022-05-06 15:21:35 +02:00
  29a3ab7e7a
• Reword test step
  Salman Ahmed · 2022-05-06 15:38:38 +03:00
  b119726b28
• Merge branch 'master' into fix-toolbox-expansion
  Bartłomiej Dach · 2022-05-06 13:47:36 +02:00
  e527574ede
• Update tests to reflect new expected behaviour
  Bartłomiej Dach · 2022-05-06 13:47:13 +02:00
  19297375e2
• Merge pull request #18119 from bdach/mod-overlay/broken-hover

  Fix mod panels not hovering correctly after closing customisation area via mouse on new mod select

  Dean Herbert · 2022-05-06 20:42:33 +09:00
  98eab9668d
• Fix editor drag box visuals
  Dean Herbert · 2022-05-06 20:34:44 +09:00
  fad1f727bb
• Remove not-accessed field
  Bartłomiej Dach · 2022-05-06 13:09:37 +02:00
  e9d52aa954
• Remove unused using directive
  Bartłomiej Dach · 2022-05-06 13:08:54 +02:00
  a915b7333c
• Merge pull request #18069 from peppy/exit-multiplayer-is-dangerous

  Make exiting multiplayer a dangerous operation, requiring hold

  Dean Herbert · 2022-05-06 20:00:41 +09:00
  cfcd64873c
• Merge branch 'master' into exit-multiplayer-is-dangerous
  Bartłomiej Dach · 2022-05-06 12:57:13 +02:00
  839f9373b2
• Merge pull request #18118 from peppy/fix-toolbox-expand-coi

  Fix toolbox expand being interrupted by gaps between groups

  Bartłomiej Dach · 2022-05-06 12:47:02 +02:00
  3e75e7184a
• Change colour denoting expanded state to be gray rather than yellow

  I always found the yellow colour very non-descript in this case. Gray
  seems to work better?

  Dean Herbert · 2022-05-06 19:45:17 +09:00
  88c190f3e3
• Tidy up ordering of SettingsToolboxGroup
  Dean Herbert · 2022-05-06 19:39:09 +09:00
  b432885e5f
• Remove unnecessary autosize workaround (was fixed long ago)
  Dean Herbert · 2022-05-06 19:39:00 +09:00
  59add66632
• Remove auto-expansion of individual toolbox groups when parent expanding container expands
  Dean Herbert · 2022-05-06 19:36:41 +09:00
  949e30c4b4
• Fix click-to-return container still handling hover when inactive
  Bartłomiej Dach · 2022-05-06 12:28:53 +02:00
  08fd0ea086
• Fix toolbox expand being interrupted by gaps between groups
  Dean Herbert · 2022-05-06 19:06:40 +09:00
  c6bc6be128
• Fix outdated test asserts
  Dean Herbert · 2022-05-06 18:44:25 +09:00
  daed42513e
• Add failing test case for broken hover behaviour
  Bartłomiej Dach · 2022-05-06 11:37:50 +02:00
  8f217d1e97
• Merge pull request #18116 from peppy/guest-is-system-user

  Mark `GuestUser` as system user via `Id` for now

  Dan Balasescu · 2022-05-06 18:13:03 +09:00
  09139ef9f4
• Rename incorrectly named variable (radius is not diameter)
  Dean Herbert · 2022-05-06 17:51:51 +09:00
  118e58888b
• Mark GuestUser as system user via Id for now

  Should resolve https://github.com/ppy/osu/issues/18105.
  
  Checking through usages, it doesn't immediately look like this will
  regress any other scenarios.

  Dean Herbert · 2022-05-06 17:37:46 +09:00
  319867f73c
• Fix clamping logic to always clamp to the last displayed tick
  Dean Herbert · 2022-05-06 17:09:38 +09:00
  37cbc79283
• Fix MaxIntervals incorrectly factoring distance spacing multipiler into snap calculation
  Dean Herbert · 2022-05-06 17:09:02 +09:00
  684fef7f8c
• Don't draw distance snap grid on the start time of the next object
  Dean Herbert · 2022-05-06 17:05:52 +09:00
  c7e7aa5962