52986 Commits

This Branch

This Branch

All Branches

• Update SFX for mod overlay show/hide
  Jamie Taylor · 2022-07-01 20:43:12 +09:00
  9d28d5f8ee
• Merge pull request #18835 from peppy/beatmap-update-flow

  Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow

  Dan Balasescu · 2022-07-01 20:28:04 +09:00
  3b1842a2c2
• Merge pull request #18803 from Joehuu/fix-overlay-header-tab-item-localisable-string

  Fix profile header tab items not localising

  Dean Herbert · 2022-07-01 19:37:57 +09:00
  0cf58646f4
• Merge pull request #18821 from ggliv/locked-room-filter

  Add room access type filter to multiplayer lounge screen

  Dean Herbert · 2022-07-01 19:37:43 +09:00
  6baccad058
• Merge pull request #18963 from peppy/more-placeholder-suggestions

  Add difficulty filter reset to song select "no results" suggestions

  Dean Herbert · 2022-07-01 17:55:23 +09:00
  b829884861
• Merge pull request #18966 from smoogipoo/fix-flaky-multiplayer-test

  Fix test sometimes referencing old ModSelect object

  Dean Herbert · 2022-07-01 17:55:06 +09:00
  b460a52faf
• Merge pull request #18945 from goodtrailer/separate-ball-followcircle

  Separate slider ball and followcircle skinnables into default/legacy classes

  Dean Herbert · 2022-07-01 17:54:29 +09:00
  cdc4caa8c4
• Simplify description logic for overlay tab items
  Salman Ahmed · 2022-07-01 11:30:51 +03:00
  5880b824d0
• Rename enum to explicitly mention it is a filter
  Dean Herbert · 2022-07-01 17:27:03 +09:00
  e213c1a4ef
• Merge branch 'master' into fix-overlay-header-tab-item-localisable-string
  Salman Ahmed · 2022-07-01 11:27:00 +03:00
  7f9ef6c23f
• Merge branch 'master' into locked-room-filter
  Dean Herbert · 2022-07-01 17:17:01 +09:00
  9911c6cbf0
• Fix regressing BeatmapRecommendations tests due to diffcalc running at
  Dean Herbert · 2022-07-01 17:10:15 +09:00
  0e1f08eff8
• Merge pull request #18964 from peppy/fix-beatmap-leaderboard-null

  Fix potential crash in `BeatmapLeaderboard` during rapid refresh operations

  Dan Balasescu · 2022-07-01 17:01:57 +09:00
  ee963f8aa7
• Merge branch 'master' into more-placeholder-suggestions
  Salman Ahmed · 2022-07-01 10:52:32 +03:00
  3bca439c4f
• Apply PR reviews/fixes
  Dan Balasescu · 2022-07-01 16:51:15 +09:00
  58c9bb031f
• Fix test sometimes referencing old ModSelect object
  Dan Balasescu · 2022-07-01 16:46:27 +09:00
  c22e77e481
• Fix potential crash in BeatmapLeaderboard during rapid refresh operations
  Dean Herbert · 2022-07-01 15:42:35 +09:00
  58e25a3a01
• Merge pull request #18874 from peppy/realm-fix-async-write-after-disposal

  Ensure all async writes are completed before realm is disposed

  Dan Balasescu · 2022-07-01 15:29:01 +09:00
  409224560f
• Add test coverage of difficulty filter reset
  Dean Herbert · 2022-07-01 15:28:55 +09:00
  3e0f4e7609
• Suggest removing difficulty filter if no matches found at song select
  Dean Herbert · 2022-07-01 15:18:04 +09:00
  f3af612133
• Merge pull request #18958 from andy840119/remove-nullable-disable-in-the-extension

  Remove nullable disable annotation in the extension namespace.

  Dan Balasescu · 2022-07-01 13:52:12 +09:00
  42d56aa640
• Merge pull request #18957 from andy840119/remove-nullable-disable-in-the-utils

  Remove nullable disable annotation in the utils namespace.

  Dan Balasescu · 2022-07-01 13:50:46 +09:00
  e9e1537d8a
• Move the null check in the outside.

  AddCursor() should not accept the null value.

  andy840119 · 2022-06-30 23:29:49 +08:00
  48047f2e58
• mark the string as nullable.
  andy840119 · 2022-06-30 23:23:14 +08:00
  a5b1f1a688
• Remove the nullable disable annotation.
  andy840119 · 2022-06-30 23:20:40 +08:00
  26de34da84
• Remove the nullable disable annotate in the test project.
  andy840119 · 2022-06-30 23:06:49 +08:00
  d94f700ab1
• Remove the nullable disable annotate.
  andy840119 · 2022-06-30 23:05:09 +08:00
  e50e0f7339
• Merge pull request #18955 from peppy/fix-multiplayer-finalise-selection-fails

  Fix various multiplayer test failures due to not waiting for ongoing operation

  Dan Balasescu · 2022-06-30 21:06:57 +09:00
  205de4f234
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-30 19:07:15 +09:00
  447b496eff
• Move wait steps upwards
  Dean Herbert · 2022-06-30 17:58:43 +09:00
  84ecd524c8
• Fix various multiplayer test failures due to not waiting for ongoing operation

  As seen at
  https://teamcity.ppy.sh/buildConfiguration/Osu_Build/1138?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true.

  Dean Herbert · 2022-06-30 17:42:45 +09:00
  7ab8335935
• Merge pull request #18951 from peppy/fix-realm-missing-transaction-rollback

  Fix `PerformWrite` not rolling back transaction on exception

  Dan Balasescu · 2022-06-30 17:17:56 +09:00
  5a346edc63
• Add xmldoc and update parameter naming for MemoryCachingComponent.Invalidate flow
  Dean Herbert · 2022-06-30 17:17:06 +09:00
  2a73210865
• Remove unnecessary invalidation handling flow
  Dean Herbert · 2022-06-30 17:13:26 +09:00
  aab4dcefbd
• Move BeatmapOnlineLookupQueue to inside BeatmapUpdater
  Dean Herbert · 2022-06-30 17:03:19 +09:00
  0698471627
• Merge pull request #18953 from peppy/fix-realm-test-cleanup-too-early

  Fix directory cleanup occurring too early during realm tests

  Dan Balasescu · 2022-06-30 16:58:22 +09:00
  b0dc9f7c2d
• Add missing xmldoc
  Dean Herbert · 2022-06-30 16:51:31 +09:00
  ef42c6ecdf
• Remove unnecessary nullable-enable
  Dean Herbert · 2022-06-30 16:47:26 +09:00
  e34c2f0aca
• Allow null parameter to GetWorkingBeatmap for now
  Dean Herbert · 2022-06-30 16:46:28 +09:00
  82134ad1a6
• Merge branch 'master' into beatmap-update-flow
  Dean Herbert · 2022-06-30 16:44:17 +09:00
  98938821e5
• Fix directory cleanup occurring too early during realm tests
  Dean Herbert · 2022-06-30 16:02:46 +09:00
  10934450cc
• Guard again potential nulls in RealmNamedFileUsage

  Hopefully help in figuring out https://sentry.ppy.sh/organizations/ppy/issues/3679/?project=2&query=user%3A%22id%3A10078484%22

  Dean Herbert · 2022-06-30 15:40:57 +09:00
  356c0501ec
• Fix PerformWrite not rolling back transaction on exception
  Dean Herbert · 2022-06-30 15:15:09 +09:00
  78d86fd3ff
• Add reproduction of transaction not being exited correctly
  Dean Herbert · 2022-06-30 15:15:09 +09:00
  0abb400f64
• Merge pull request #18949 from smoogipoo/fix-flaky-star-display-test

  Ensure PlaylistItem's beatmap is not null

  Dean Herbert · 2022-06-30 15:15:06 +09:00
  e89f220e9a
• Merge pull request #18948 from smoogipoo/legacy-mod-combined-mod-conversion

  Fix converting "inherited" mods to legacy mods

  Dean Herbert · 2022-06-30 14:33:37 +09:00
  398bf13076
• Ensure PlaylistItem beatmap is not null
  Dan Balasescu · 2022-06-30 14:24:49 +09:00
  c6520de749
• Merge pull request #18947 from smoogipoo/fix-flaky-autoplay-test

  Attempt to fix flaky TestSceneAutoplay test

  Dean Herbert · 2022-06-30 12:50:19 +09:00
  bca38cc6c8
• Fix tests
  Dan Balasescu · 2022-06-30 12:37:03 +09:00
  6c2d02fefd
• Attach DT with NC, SD with PF, and Cinema with Autoplay
  Dan Balasescu · 2022-06-30 11:52:30 +09:00
  edc4ace17e