osu-lazer

Make Hidden and Freeze Frame mods incompatible (#36515 )

Effectively closing https://github.com/ppy/osu/issues/21471 as a
wontfix.

The issue is demonstrated by the following test case:

<details>
<summary>patch</summary>

```diff
diff --git a/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs b/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs
index 31498295da..36b4fe5122 100644
--- a/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs
+++ b/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs
@@ -55,5 +55,49 @@ public void TestSkipToFirstSpinnerNotSuppressed()
                 PassCondition = () => Player.GameplayClockContainer.GameplayStartTime > 0
             });
         }
+
+        [Test]
+        public void TestFreezeFrameAppliedBeforeHidden()
+        {
+            CreateModTest(new ModTestData
+            {
+                Mods =
+                [
+                    new OsuModFreezeFrame(),
+                    new OsuModHidden(),
+                ],
+                CreateBeatmap = () => new OsuBeatmap
+                {
+                    HitObjects =
+                    {
+                        new HitCircle { StartTime = 3000, Position = OsuPlayfield.BASE_SIZE / 2, NewCombo = true },
+                        new HitCircle { StartTime = 5000, Position = OsuPlayfield.BASE_SIZE / 2 },
+                    }
+                },
+                PassCondition = () => ((HitCircle)Player.GameplayState.Beatmap.HitObjects[1]).TimeFadeIn == 480
+            });
+        }
+
+        [Test]
+        public void TestFreezeFrameAppliedAfterHidden()
+        {
+            CreateModTest(new ModTestData
+            {
+                Mods =
+                [
+                    new OsuModHidden(),
+                    new OsuModFreezeFrame(),
+                ],
+                CreateBeatmap = () => new OsuBeatmap
+                {
+                    HitObjects =
+                    {
+                        new HitCircle { StartTime = 3000, Position = OsuPlayfield.BASE_SIZE / 2, NewCombo = true },
+                        new HitCircle { StartTime = 5000, Position = OsuPlayfield.BASE_SIZE / 2 },
+                    }
+                },
+                PassCondition = () => ((HitCircle)Player.GameplayState.Beatmap.HitObjects[1]).TimeFadeIn == 480
+            });
+        }
     }
 }

```

</details>

The reason that this is happening is a data dependency. Freeze Frame
modifies `TimePreempt` of hitobjects:


https://github.com/ppy/osu/blob/54c0b2c20c3209f1f17be81b8883ef66ec8a83bb/osu.Game.Rulesets.Osu/Mods/OsuModFreezeFrame.cs#L53

while Hidden uses `TimePreempt` to set `TimeFadeIn`:


https://github.com/ppy/osu/blob/54c0b2c20c3209f1f17be81b8883ef66ec8a83bb/osu.Game.Rulesets.Osu/Mods/OsuModHidden.cs#L45

Therefore the final value of `TimeFadeIn` with these two mods active
depends on the order of application.

The reason why I'm bothering to do this is that I was pinged from the PP
development server about this again in the context of some ongoing
'rework' and I wish to get ahead of this before it becomes a bigger
problem than it already is.

The current order of application of these mods as done in `Player` is
constant, but essentially undefined. I'm not even sure what even
enforces the current order. It's currently Hidden, then Freeze Frame. If
I were to guess, the thing "enforcing" (insert 400 tonne solid lead air
quotes) it is probably the mod select overlay with its "I need to own
all of the mod instances in the global bindable" substitution logic.

I'm already getting pushback for this from the PP server crowd who are
attempting to justify the current "behaviour" by saying that the player
base wants this or by saying that it's already broken so it should
remain that way forever. I am however not willing to accept
[stable-taiko-tier stupidity
again](https://github.com/ppy/osu/pull/27136#issuecomment-1957055402)
and am not willing to accept the complexity this would invite everywhere
else.

I do not see any other easy way of fixing this problem at this point in
time. I had hoped that I could inline the `TimePreempt` read in
`OsuModHidden`, but it's not that easy because it's set in multiple
places.

Existing HDFF scores would probably need to be delisted from the
leaderboards. I'm not even sure I can get myself to pretend to care.

Bartłomiej Dach · 2026-01-29 16:35:13 +09:00

9bf52034d7

Merge pull request #36517 from YHSabc233/localisation/editor-show-storyboard

Localise "Show storyboard" in `Editor`

Bartłomiej Dach · 2026-01-29 08:35:01 +01:00

a53ba5e4ef

Merge pull request #36516 from peppy/fix-beatmap-invalidation-F-A-I-L

Fix star ratings sometimes not updating after editing a beatmap

Bartłomiej Dach · 2026-01-29 08:31:56 +01:00

35b9c74cf8

Localise "Show storyboard" in Editor

YHSabc233 · 2026-01-29 02:07:46 +08:00

64a29313a8

Update iOS app icon to iOS 26 Liquid Glass variants (#36510 )

Removes the previous `AppIcon.appiconset` bundle and replaces it with
all of the necessary asset slices to enable all of the Liquid Glass
variants of the app icon on iOS 26, while also preserving backwards
compatibility with older iOS versions.

<img width="1164" height="388" alt="LiquidGlass"
src="https://github.com/user-attachments/assets/7d6e7a90-3fe5-4853-9c63-35144359f49e"
/>

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Tim Oliver · 2026-01-29 02:12:41 +09:00

2026.129.0-tachyon 8e5eed63e1

Fix BeatmapDifficultyCache's bindable tracking not correctly updating BeatmapInfo metadata on invalidation

Dean Herbert · 2026-01-29 01:47:13 +09:00

b705313d3f

Add failing test coverage

Dean Herbert · 2026-01-29 01:47:13 +09:00

5dd34f165f

Avoid triggering bindable updates if mods haven't actually changed

Dean Herbert · 2026-01-29 00:28:58 +09:00

10651512a5

More aggressively cancel debounced tracked bindable updates

If we've run an update since we can cancel the scheduled debounce run.

Dean Herbert · 2026-01-29 00:28:58 +09:00

4c2ffa0f79

Add assertion that we always get the up-to-date beatmap file in a WorkingBeatmap

Dean Herbert · 2026-01-29 00:28:58 +09:00

6997f89698

Merge pull request #36511 from MayoCollector/localisation/sample-set-chooser

Localise "Custom sample sets" caption in `FormSampleSetChooser` dropdown

Bartłomiej Dach · 2026-01-28 14:48:37 +01:00

0ed4a8dbe5

Localise "Custom sample sets" in FormSampleSetChooser dropdown

BoomboxRapsody · 2026-01-28 22:06:54 +09:00

c47f9c5259

Merge pull request #36498 from smoogipoo/ranked-play-models

Add server-side models for ranked play

Bartłomiej Dach · 2026-01-28 11:31:57 +01:00

2026.128.0 a401c7d5e9

Merge pull request #36504 from peppy/fix-double-checking-sounds

Fix `FormCheckbox` playing sounds twice

Bartłomiej Dach · 2026-01-28 11:07:17 +01:00

6185a81bd5

Apply default value changes from review

Dan Balasescu · 2026-01-28 17:45:15 +09:00

6d54d20943

Merge pull request #36500 from peppy/playlist-ssv2-all-mods-display

Fix "ALL MODS" display not displaying in new playlist song select

Bartłomiej Dach · 2026-01-28 09:39:35 +01:00

02fbcaba23

Fix FormCheckbox playing sounds twice

This removes the disabled sound, but I think that's fine. If we want
that, it should be handled by `HoverClickSounds` (which I'm currently
intentionally not using because it can be a bit noisy).

Closes #36503.

Dean Herbert · 2026-01-28 16:55:43 +09:00

7b7777bb56

Remove leaking knowledge of freestyle in normal song select component

Dean Herbert · 2026-01-28 16:37:39 +09:00

ca7b850c8c

Merge pull request #36499 from peppy/fix-dropdown-animations

Fix dropdown margins and animations being weird

Bartłomiej Dach · 2026-01-28 08:09:40 +01:00

88e5ac4834

Limit maximum size of mod tooltip to avoid it going offscreen

Dean Herbert · 2026-01-28 16:08:02 +09:00

b9d5606fd4

Combine implementation of mods text drawable

I don't want to have to update things in multiple places with different
code in each place.

This also closes https://github.com/ppy/osu/issues/36412.

Dean Herbert · 2026-01-28 16:02:14 +09:00

c8c91cedfa

Fix mod count overlay flashing when switching freestyle on and off

Dean Herbert · 2026-01-28 15:01:23 +09:00

0c90cf3cef

Fix "ALL MODS" display not displaying in new playlist song select

Closes https://github.com/ppy/osu/issues/36411.

Dean Herbert · 2026-01-28 14:42:41 +09:00

1a0193001d

Fix dropdown margins and animations being weird

This was attempted to be fixed by frenzibyte using some hack workaround
logic, but this is the true fix.

Things were never matching due to `UpdateSize` spamming `Resize`
transforms every frame, causing the fade out to complete before
transforms have reached a final state.

Dean Herbert · 2026-01-28 14:22:41 +09:00

6bdb0e1cbb

Remove workaround for dropdowns animating weirdly

Dean Herbert · 2026-01-28 14:22:31 +09:00

0d3b7ab6be

Add comments

Dan Balasescu · 2026-01-28 14:00:44 +09:00

8202ad18d0

Add ranked play match type

Dan Balasescu · 2026-01-28 13:42:59 +09:00

fa5a278cf3

Add ranked play models

Dan Balasescu · 2026-01-28 13:42:59 +09:00

70321e2f89

Add type parameter to pool retrieval method

Dan Balasescu · 2026-01-28 13:42:58 +09:00

c1fc1edd9c

Add type to matchmaking pools

Dan Balasescu · 2026-01-28 13:38:40 +09:00

40e55ecb6e

Merge pull request #36486 from peppy/ui-tweaking

First pass adjustments to new settings design

Bartłomiej Dach · 2026-01-27 14:33:25 +01:00

2026.128.0-tachyon cffeb92248

Fix panel expansion not being set on initial song select load (#36456 )

Closes #36445.

Fixes a regression from #36404

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Eeli Ogata · 2026-01-27 14:32:51 +01:00

2c56419fe9

Apply extracted background in one more location

Bartłomiej Dach · 2026-01-27 12:09:31 +01:00

add67b95c7

Add insult to injury for autosize workaround

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-01-27 19:58:45 +09:00

6fad798227

Add localisation support for "Device:" prefix

Dean Herbert · 2026-01-27 19:03:23 +09:00

60690cbccc

Add back FinishTransforms at what cost

Dean Herbert · 2026-01-27 19:02:28 +09:00

6329e3ee1b

Use enum for background states

Dean Herbert · 2026-01-27 18:58:03 +09:00

fa22d1f202

Remove unnecessary depth change

Dean Herbert · 2026-01-27 18:51:04 +09:00

12eeab581e

Fix mismatching spacing in dropdown form menus

Dean Herbert · 2026-01-27 18:49:53 +09:00

b5e93b98c9

Fix revert button not always matching control's size

Dean Herbert · 2026-01-27 18:36:49 +09:00

786ea35274

Fix border showing for inner text boxes incorrectly

I turned masking back on on these for better visuals (text masking
aligns with rest of elements) but turns out this implicitly makes
borders draw.

Dean Herbert · 2026-01-27 18:36:37 +09:00

d6bf4fd90d

Adjust paddings to give more width to settings

Dean Herbert · 2026-01-27 17:43:28 +09:00

c407e07514

Adjust size and icon of revert-to-default button

Dean Herbert · 2026-01-27 17:06:15 +09:00

ed0051d119

Make binding configuration button bigger

It's one of the more important sections so I want to make it easier to
find.

Dean Herbert · 2026-01-27 17:06:14 +09:00

99ea19d55c

Standardise hover sounds for form elements

Closes #36444.

Dean Herbert · 2026-01-27 17:06:14 +09:00

dba17b1fa6

Add prefix for input device header

Dean Herbert · 2026-01-27 17:06:13 +09:00

fdf28474bf

Standardise animations

Dean Herbert · 2026-01-27 17:06:13 +09:00

42dc73d849

Various metrics and visual tweaks

Dean Herbert · 2026-01-27 17:06:13 +09:00

6983227240

Fix button spacing being weirdly small

Dean Herbert · 2026-01-27 17:06:12 +09:00

585ce682ef

Fix revert button height

Dean Herbert · 2026-01-27 17:06:12 +09:00

3db3b603bc

76462 Commits