35 Commits

• Fix HitWindows.WindowFor() returning values for invalid results

  This fell out of my work on hit window-related replay issues. In my WIP
  branch (that is probably going to get PR'd as draft soon) I refactored
  `HitWindows` and found a few straggling test failures due to some places
  reading hit windows for results that were not actually supported by the
  underlying `HitWindows` implementations, leading to returning garbage
  (mostly zeroes).
  
  Importantly, there is one actual usage in game code with impact here -
  `TaikoModSingleTap` was attempting to read the hit window for MEH, when
  MEH was never actually a valid hit result in taiko (OK is). This was a
  result of a copy-paste oversight from osu!, specifically from
  
  	https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58

  Bartłomiej Dach · 2025-05-09 09:40:20 +02:00
  ceb58a1141
• Fix test compile failures
  Bartłomiej Dach · 2024-10-21 13:57:34 +02:00
  1e03bd11a3
• Add flag to allow backwards seeks in tests
  Dean Herbert · 2024-02-29 23:05:28 +08:00
  4184a5c1ef
• Fix test compile failures from Audio hoisting
  Bartłomiej Dach · 2023-02-21 21:03:00 +01:00
  d59d153654
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix number of judgements shown potentially exceeding upper limit
  Dean Herbert · 2022-11-15 12:31:25 +09:00
  308ed1abd1
• small fix
  Mk-56spn · 2022-09-09 08:21:33 +02:00
  5852a09003
• Test fix
  Mk-56spn · 2022-09-08 20:42:55 +02:00
  38ccd06d5e
• Test fix
  Mk-56spn · 2022-09-06 03:00:13 +02:00
  cfa1ebd0cb
• Fix some test issues
  Mk-56spn · 2022-09-05 04:49:48 +02:00
  aace334fb3
• Add messages to all InvalidOperationExceptions

  Without this, they can be very non-descript and hard to track down

  Dean Herbert · 2022-06-28 01:34:25 +09:00
  569fde4b47
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add failing test coverage showing hit meters don't update when not visible
  Dean Herbert · 2022-06-13 16:36:22 +09:00
  17eaf7bb5c
• Merge branch 'master' into pp-counter-alloc-reduction
  Dean Herbert · 2022-03-15 13:31:57 +09:00
  6fb06d69cc
• Provide correct HitResult type for random judgements in TestSceneHitErrorMeter
  Dean Herbert · 2022-03-14 19:16:19 +09:00
  b31ff679fb
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Replace pragma with add/remove => throw
  Salman Ahmed · 2021-11-05 09:10:38 +03:00
  b723975767
• Remove hacky code with explicit pragma disable
  Salman Ahmed · 2021-11-05 03:49:35 +03:00
  af6ae1cce5
• Add tests for clearing HitErrorMeter

  Works with both `BarHitErrorMeter` and `ColourHitErrorMeter`

  sh0ckR6 · 2021-09-19 14:15:22 -04:00
  93ca615c02
• Ignore non-scorable and bonus judgements
  smoogipoo · 2021-06-08 23:09:23 +09:00
  c8e14d7710
• Adjust test scene to avoid cross-test interference

  * Move steps from ctor to a separate basic test.
  * Wait for barrage to complete in basic test, as not doing so polluted
    state of other tests.
  * Reset score processor after every test.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  1b4771655a
• Add failing assertions to hit error meter test
  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  37d062c7cd
• Remove bogus CatchHitWindows

  `CatchHitWindows` were a vestige from the past, and were not actually
  used anywhere except for the hit error meter test, giving off an
  appearance that the hit error meter was working properly.
  `CatchHitObject` actually specifies empty hit windows.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  122a624b7f
• Add framestable-bypassing seek for spectator
  smoogipoo · 2021-06-03 17:27:21 +09:00
  420df124b5
• Update HitErrorDisplay tests
  Dean Herbert · 2021-05-18 15:12:29 +09:00
  c885ad87d5
• Fix regressed HitErrorDisplay behaviour (and localise binding to meter implementations)
  Dean Herbert · 2021-05-10 15:24:13 +09:00
  97e72849af
• Add support for bottom-anchored hit error display
  Dean Herbert · 2020-10-15 19:14:02 +09:00
  70806deba1
• Make osu/taiko/catch use Ok+Great
  smoogipoo · 2020-09-29 17:16:55 +09:00
  f439c1afbc
• Remove all RequiredTypes usages
  smoogipoo · 2020-05-16 18:17:12 +09:00
  648999a2de
• Merge branch 'master' into fix-dho-lifetimes-via-judgements
  Dean Herbert · 2020-02-25 19:07:57 +09:00
  29e2e17144
• Revert changes to make HitObject abstract
  Dean Herbert · 2020-02-25 19:07:15 +09:00
  a047456354
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Expire old judgement lines if too many exist
  Dean Herbert · 2020-02-23 03:53:51 +09:00
  e8ebb31517
• Merge remote-tracking branch 'upstream/master' into colour-score-meter
  Dean Herbert · 2020-01-24 11:45:33 +09:00
  c390348eab
• Improve testing
  Andrei Zavatski · 2019-12-21 14:30:49 +03:00
  5af1260094